* [PATCH] Exclude tst-realloc from tests-mcheck
@ 2021-07-06 16:01 Siddhesh Poyarekar
2021-07-06 16:12 ` Siddhesh Poyarekar
2021-07-06 17:59 ` Carlos O'Donell
0 siblings, 2 replies; 7+ messages in thread
From: Siddhesh Poyarekar @ 2021-07-06 16:01 UTC (permalink / raw)
To: libc-alpha; +Cc: Stefan Liebler
The realloc (NULL, 0) test in tst-realloc fails with gcc 7.x but
passes with newer gcc. This is because a newer gcc transforms the
realloc call to malloc (0), thus masking the bug in mcheck.
Disable the test with mcheck for now. The malloc removal patchset
will fix this and then remove this test from the exclusion list.
I'll push this soon if there are no objections. I'll also post an
updated malloc hooks patchset with these issues fixed.
Reported-by: Stefan Liebler <stli@linux.ibm.com>
---
malloc/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/malloc/Makefile b/malloc/Makefile
index 2f9b3d596d..2af1203a0a 100644
--- a/malloc/Makefile
+++ b/malloc/Makefile
@@ -93,7 +93,8 @@ tests-exclude-mcheck = tst-mallocstate \
tst-malloc-usable-tunables \
tst-malloc_info \
tst-memalign \
- tst-posix_memalign
+ tst-posix_memalign \
+ tst-posix-realloc
tests-mcheck = $(filter-out $(tests-exclude-mcheck), $(tests))
--
2.31.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Exclude tst-realloc from tests-mcheck
2021-07-06 16:01 [PATCH] Exclude tst-realloc from tests-mcheck Siddhesh Poyarekar
@ 2021-07-06 16:12 ` Siddhesh Poyarekar
2021-07-06 17:58 ` Carlos O'Donell
2021-07-06 17:59 ` Carlos O'Donell
1 sibling, 1 reply; 7+ messages in thread
From: Siddhesh Poyarekar @ 2021-07-06 16:12 UTC (permalink / raw)
To: Siddhesh Poyarekar, libc-alpha; +Cc: Stefan Liebler, Carlos O'Donell
On 7/6/21 9:31 PM, Siddhesh Poyarekar via Libc-alpha wrote:
> The realloc (NULL, 0) test in tst-realloc fails with gcc 7.x but
> passes with newer gcc. This is because a newer gcc transforms the
> realloc call to malloc (0), thus masking the bug in mcheck.
>
> Disable the test with mcheck for now. The malloc removal patchset
> will fix this and then remove this test from the exclusion list.
>
> I'll push this soon if there are no objections. I'll also post an
> updated malloc hooks patchset with these issues fixed.
>
> Reported-by: Stefan Liebler <stli@linux.ibm.com>
I just remembered that the tree is in slushy freeze. Carlos, would you
approve this? I will rebase the malloc hooks patchset on top of this.
Thanks,
Siddhesh
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Exclude tst-realloc from tests-mcheck
2021-07-06 16:12 ` Siddhesh Poyarekar
@ 2021-07-06 17:58 ` Carlos O'Donell
0 siblings, 0 replies; 7+ messages in thread
From: Carlos O'Donell @ 2021-07-06 17:58 UTC (permalink / raw)
To: Siddhesh Poyarekar, Siddhesh Poyarekar, libc-alpha; +Cc: Stefan Liebler
On 7/6/21 12:12 PM, Siddhesh Poyarekar wrote:
> On 7/6/21 9:31 PM, Siddhesh Poyarekar via Libc-alpha wrote:
>> The realloc (NULL, 0) test in tst-realloc fails with gcc 7.x but
>> passes with newer gcc. This is because a newer gcc transforms the
>> realloc call to malloc (0), thus masking the bug in mcheck.
>>
>> Disable the test with mcheck for now. The malloc removal patchset
>> will fix this and then remove this test from the exclusion list.
>>
>> I'll push this soon if there are no objections. I'll also post an
>> updated malloc hooks patchset with these issues fixed.
>>
>> Reported-by: Stefan Liebler <stli@linux.ibm.com>
>
> I just remembered that the tree is in slushy freeze. Carlos, would you approve this? I will rebase the malloc hooks patchset on top of this.
This is a non-ABI bug fix which is OK in the slushy freeze which only
coves ABI changes.
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Exclude tst-realloc from tests-mcheck
2021-07-06 16:01 [PATCH] Exclude tst-realloc from tests-mcheck Siddhesh Poyarekar
2021-07-06 16:12 ` Siddhesh Poyarekar
@ 2021-07-06 17:59 ` Carlos O'Donell
2021-07-07 7:49 ` Stefan Liebler
1 sibling, 1 reply; 7+ messages in thread
From: Carlos O'Donell @ 2021-07-06 17:59 UTC (permalink / raw)
To: Siddhesh Poyarekar, libc-alpha; +Cc: Stefan Liebler
On 7/6/21 12:01 PM, Siddhesh Poyarekar via Libc-alpha wrote:
> The realloc (NULL, 0) test in tst-realloc fails with gcc 7.x but
> passes with newer gcc. This is because a newer gcc transforms the
> realloc call to malloc (0), thus masking the bug in mcheck.
>
> Disable the test with mcheck for now. The malloc removal patchset
> will fix this and then remove this test from the exclusion list.
>
> I'll push this soon if there are no objections. I'll also post an
> updated malloc hooks patchset with these issues fixed.
>
> Reported-by: Stefan Liebler <stli@linux.ibm.com>
> ---
> malloc/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/malloc/Makefile b/malloc/Makefile
> index 2f9b3d596d..2af1203a0a 100644
> --- a/malloc/Makefile
> +++ b/malloc/Makefile
> @@ -93,7 +93,8 @@ tests-exclude-mcheck = tst-mallocstate \
> tst-malloc-usable-tunables \
> tst-malloc_info \
> tst-memalign \
> - tst-posix_memalign
> + tst-posix_memalign \
> + tst-posix-realloc
>
> tests-mcheck = $(filter-out $(tests-exclude-mcheck), $(tests))
LGTM.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Exclude tst-realloc from tests-mcheck
2021-07-06 17:59 ` Carlos O'Donell
@ 2021-07-07 7:49 ` Stefan Liebler
2021-07-07 7:59 ` Siddhesh Poyarekar
0 siblings, 1 reply; 7+ messages in thread
From: Stefan Liebler @ 2021-07-07 7:49 UTC (permalink / raw)
To: Carlos O'Donell, Siddhesh Poyarekar, libc-alpha
On 06/07/2021 19:59, Carlos O'Donell wrote:
> On 7/6/21 12:01 PM, Siddhesh Poyarekar via Libc-alpha wrote:
>> The realloc (NULL, 0) test in tst-realloc fails with gcc 7.x but
>> passes with newer gcc. This is because a newer gcc transforms the
>> realloc call to malloc (0), thus masking the bug in mcheck.
>>
>> Disable the test with mcheck for now. The malloc removal patchset
>> will fix this and then remove this test from the exclusion list.
>>
>> I'll push this soon if there are no objections. I'll also post an
>> updated malloc hooks patchset with these issues fixed.
>>
>> Reported-by: Stefan Liebler <stli@linux.ibm.com>
>> ---
>> malloc/Makefile | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/malloc/Makefile b/malloc/Makefile
>> index 2f9b3d596d..2af1203a0a 100644
>> --- a/malloc/Makefile
>> +++ b/malloc/Makefile
>> @@ -93,7 +93,8 @@ tests-exclude-mcheck = tst-mallocstate \
>> tst-malloc-usable-tunables \
>> tst-malloc_info \
>> tst-memalign \
>> - tst-posix_memalign
>> + tst-posix_memalign \
>> + tst-posix-realloc
>>
>> tests-mcheck = $(filter-out $(tests-exclude-mcheck), $(tests))
>
> LGTM.
>
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
>
Hi Siddhesh,
Thanks for adding the test to the exclude list.
But unfortunately it is still failing as there is a typo. The test is
named "tst-realloc" instead of "tst-posix-realloc".
Bye,
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Exclude tst-realloc from tests-mcheck
2021-07-07 7:49 ` Stefan Liebler
@ 2021-07-07 7:59 ` Siddhesh Poyarekar
2021-07-07 8:07 ` Stefan Liebler
0 siblings, 1 reply; 7+ messages in thread
From: Siddhesh Poyarekar @ 2021-07-07 7:59 UTC (permalink / raw)
To: Stefan Liebler, Carlos O'Donell, libc-alpha
On 7/7/21 1:19 PM, Stefan Liebler wrote:
> Thanks for adding the test to the exclude list.
> But unfortunately it is still failing as there is a typo. The test is
> named "tst-realloc" instead of "tst-posix-realloc".
Terribly sorry about that, I have pushed the correct fix now.
Siddhesh
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Exclude tst-realloc from tests-mcheck
2021-07-07 7:59 ` Siddhesh Poyarekar
@ 2021-07-07 8:07 ` Stefan Liebler
0 siblings, 0 replies; 7+ messages in thread
From: Stefan Liebler @ 2021-07-07 8:07 UTC (permalink / raw)
To: Siddhesh Poyarekar, Carlos O'Donell, libc-alpha
On 07/07/2021 09:59, Siddhesh Poyarekar wrote:
> On 7/7/21 1:19 PM, Stefan Liebler wrote:
>> Thanks for adding the test to the exclude list.
>> But unfortunately it is still failing as there is a typo. The test is
>> named "tst-realloc" instead of "tst-posix-realloc".
>
> Terribly sorry about that, I have pushed the correct fix now.
>
> Siddhesh
No problem.
Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-07-07 8:07 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-06 16:01 [PATCH] Exclude tst-realloc from tests-mcheck Siddhesh Poyarekar
2021-07-06 16:12 ` Siddhesh Poyarekar
2021-07-06 17:58 ` Carlos O'Donell
2021-07-06 17:59 ` Carlos O'Donell
2021-07-07 7:49 ` Stefan Liebler
2021-07-07 7:59 ` Siddhesh Poyarekar
2021-07-07 8:07 ` Stefan Liebler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).