From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-83460-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 58345 invoked by alias); 18 Aug 2017 13:58:39 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 57926 invoked by uid 89); 18 Aug 2017 13:58:39 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mail-qt0-f176.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:subject:from:to:references:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=sajXUGwCT/BtfYjVmI6E0m2usKjTvGY5XvohfhgJ4SE=;
        b=n97VJMe7KvCK+ZEhm2/xuT9N0H5Gl9o6xDv2Fc4M8G7JblOBKmP/blLxwWTwhZbcEj
         jV+AEE1JomcCFOMeFCkep7uEj/XBy9V9NrJmlCwsqwRL8xCES/waFLp9sUFTZtYHhz33
         rlZKR0tOhIkp9zSzX2Us6DVD0xmW/DVrL9vsJYr0Fw+KNTvd4if5LhVxdXkkLFA8GdiF
         y2GlXQ9KzGBKSVgkOcq427pMIINufpLOUvXN3gYs87rseevR/7kX0TV5JJbYvNzhL7Zv
         bXLzkUxVj/O5DCKvPMuRHffGrzIceX0s4+PJAkMuZMNyJxDK+bOa+eGG2T8i2K3wliXa
         62vg==
X-Gm-Message-State: AHYfb5j+XM4BMC9xRH6zvJ44sTChFBFbKjS9gnuPNUb0stJ38vmNt2Up
	ToDeyYhJSC/HuIYfR4E1vw==
X-Received: by 10.200.47.146 with SMTP id l18mr12086943qta.176.1503064715848;
        Fri, 18 Aug 2017 06:58:35 -0700 (PDT)
Subject: Re: [PATCH 04/14] Consolidate non cancellable openat call
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
References: <1501765874-6201-1-git-send-email-adhemerval.zanella@linaro.org>
 <1501765874-6201-5-git-send-email-adhemerval.zanella@linaro.org>
 <e5bbf68b-a4a9-d13a-9c72-0ac35804af54@linaro.org>
Message-ID: <3d4927fb-e34c-c989-5dd1-619324ecc4c0@linaro.org>
Date: Fri, 18 Aug 2017 13:58:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <e5bbf68b-a4a9-d13a-9c72-0ac35804af54@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-08/txt/msg00876.txt.bz2



On 18/08/2017 10:55, Adhemerval Zanella wrote:
> Since this is a refactor, if no one opposes I will commit it shortly.

>> diff --git a/sysdeps/unix/sysv/linux/openat.c b/sysdeps/unix/sysv/linux/openat.c
>> index 1587305..f995775 100644
>> --- a/sysdeps/unix/sysv/linux/openat.c
>> +++ b/sysdeps/unix/sysv/linux/openat.c
>> @@ -19,6 +19,7 @@
>>  #include <stdarg.h>
>>  
>>  #include <sysdep-cancel.h>
>> +#include <not-cancel.h>
>>  
>>  #ifndef __OFF_T_MATCHES_OFF64_T
>>  
>> @@ -43,4 +44,23 @@ weak_alias (__libc_openat, __openat)
>>  libc_hidden_weak (__openat)
>>  weak_alias (__libc_openat, openat)
>>  
>> +# if !IS_IN (rtld)
>> +int
>> +__openat_nocancel (int fd, const char *file, int oflag, ...)
>> +{
>> +  mode_t mode = 0;
>> +  if (__OPEN_NEEDS_MODE (oflag))
>> +    {
>> +      va_list arg;
>> +      va_start (arg, oflag);
>> +      mode = va_arg (arg, mode_t);
>> +      va_end (arg);
>> +    }
>> +
>> +  return SYSCALL_CANCEL (openat, fd, file, oflag, mode);

And this is blatantly wrong, I will fix it.