From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x332.google.com (mail-ot1-x332.google.com [IPv6:2607:f8b0:4864:20::332]) by sourceware.org (Postfix) with ESMTPS id A9ACC388301F for ; Mon, 5 Jun 2023 17:14:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A9ACC388301F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ot1-x332.google.com with SMTP id 46e09a7af769-6b160f3f384so1150524a34.3 for ; Mon, 05 Jun 2023 10:14:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685985289; x=1688577289; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Yo1wyHS1+YKwn76y0Eyd26N2SUSAS4bs8VPtJS9PjkE=; b=c2Zk937a4Ra9pja3M3zBZ/vqFQktKC9ofNM4iVSTQ7xp4pUiH017cjhs8AYz356SBA Kd+EED+xELeG6MXk36Oe3Bvbdg9MSUOvYv+uExEyzRu5+iiUfojf4NNdntVAb4XOiesv HqO/DTUMeoNMdKvu2EjNWvPBRKmWzHcHjCW64i+OsZnltw24DsnoYz0fo8oGoY8Q9h9+ DfbXLQWnsJl7L71t2lhlqYmMhngjVSUWqtLwnUURpl/7akFaeFh6w6hPAO+/ABkDYMpA BgyG1qhp2yJFptdjDsndHZ7XTQo3GwZ5Hgad7DSavTiMS0/HOwbflrdpkZpoENpWbLVC EWdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685985289; x=1688577289; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Yo1wyHS1+YKwn76y0Eyd26N2SUSAS4bs8VPtJS9PjkE=; b=X2WU4BHs+7L5Jnw6CmyLU6PbNB16MCPgBLYToUFPwGHYMQJQRtTu7HowLBB05aeCqv ELptbdzKRLddEsOZg4soIm1ESywqvhzZ0Rz0XOg6A+HJBwRb6PCDGdeiyFN0bI2A3VeP HPgEu67BToBfev7Bxgz6RpDTvhK5tc/3oC+sL4AIBbEuti0Txi3+t0BcNaAm/KsmY6x7 mE9iRDThanW7AfR00/7YMNHwYhWfojbqUNAXRzmyWU1duoMfVHfUl5xT0Z0JkCsbhNg3 OXINfZ4uPvzb+3Da1ztzVFkV4Qie5VYuLTJEl3prmeDrEboci7856aCnYvv3Tmu6E48+ M3bw== X-Gm-Message-State: AC+VfDyBy+K+AW8MTrJt/EWEo8JWNrsH2AqQcpH2+dMhbTKY0UvWTvbG DVa+GbjPPr105rQTHDK7EFeyZBlsUvMY6G3/TGPCxg== X-Google-Smtp-Source: ACHHUZ6J+ZmjEyl/2Ok9MrwkH9I9fPmkj1OBR9QbY0yJgkJYuPbXqi8bMAALyyjsMgQwmEsk5X5hMw== X-Received: by 2002:a05:6830:151a:b0:6b1:9646:2ef with SMTP id k26-20020a056830151a00b006b1964602efmr2093814otp.27.1685985288982; Mon, 05 Jun 2023 10:14:48 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c1:fe49:680c:a97a:ffe6:9a8f? ([2804:1b3:a7c1:fe49:680c:a97a:ffe6:9a8f]) by smtp.gmail.com with ESMTPSA id b17-20020a9d6b91000000b006adbf08a7d2sm3523606otq.53.2023.06.05.10.14.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jun 2023 10:14:48 -0700 (PDT) Message-ID: <3d708678-6d74-b527-2e50-89255fcd65d1@linaro.org> Date: Mon, 5 Jun 2023 14:14:46 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH] linux: Split tst-ttyname Content-Language: en-US To: Florian Weimer , Adhemerval Zanella via Libc-alpha References: <20230601174432.456518-1-adhemerval.zanella@linaro.org> <87pm6ayqzq.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <87pm6ayqzq.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 05/06/23 10:32, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> sysdeps/unix/sysv/linux/Makefile | 1 + >> sysdeps/unix/sysv/linux/tst-ttyname-common.c | 416 ++++++++++++++ >> .../unix/sysv/linux/tst-ttyname-namespace.c | 147 +++++ >> sysdeps/unix/sysv/linux/tst-ttyname.c | 512 +----------------- >> 4 files changed, 567 insertions(+), 509 deletions(-) >> create mode 100644 sysdeps/unix/sysv/linux/tst-ttyname-common.c >> create mode 100644 sysdeps/unix/sysv/linux/tst-ttyname-namespace.c > > I'd prefer if we could stop using the original tst-ttyname name for > clarity. Do you mean for the new tst-ttyname-namespace or for tst-ttyname as well? The test idea is really to check ttyname, so what exactly do you suggest us to change?