public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v2] io: Reorganize the getcwd implementation
Date: Mon, 31 Aug 2020 15:27:03 -0300	[thread overview]
Message-ID: <3d7d2084-b1df-f6bd-bc55-5e868b6acaa9@linaro.org> (raw)
In-Reply-To: <f121ab25-0dcb-8627-7e56-131ace619d2a@cs.ucla.edu>



On 27/08/2020 20:44, Paul Eggert wrote:
> This patch doesn't apply to glibc master. 'git am' says:
> 
> Applying: io: Reorganize the getcwd implementation
> error: patch failed: sysdeps/posix/getcwd.c:89
> error: sysdeps/posix/getcwd.c: patch does not apply
> Patch failed at 0001 io: Reorganize the getcwd implementation
> 
> and plain 'patch' says:
> 
> patching file io/getcwd-generic.c (renamed from sysdeps/posix/getcwd.c)
> Hunk #1 FAILED at 89.
> Hunk #2 FAILED at 154.
> Hunk #3 succeeded at 529 with fuzz 1 (offset 43 lines).
> 2 out of 3 hunks FAILED -- saving rejects to file io/getcwd-generic.c.rej
> 
> Perhaps I should be applying it to some particular commit? Or perhaps you need to rebase it or something.

Sorry, I should have make it explicit it is an updated for the 4/4 patch
on the set [1]. I will send a updated version now you updated gnulib side
along with some changes on the linux implementation and probably a fix for
BZ#26545 as well.

[1] https://sourceware.org/pipermail/libc-alpha/2020-August/117296.html

  reply	other threads:[~2020-08-31 18:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-26 21:02 [PATCH 1/4] Sync getcwd with gnulib Adhemerval Zanella
2020-08-26 21:02 ` [PATCH 2/4] linux: Remove __ASSUME_ATFCTS Adhemerval Zanella
2020-08-26 21:02 ` [PATCH 3/4] Use LFS readdir in generic POSIX getcwd [BZ# 22899] Adhemerval Zanella
2020-08-27  9:58   ` Florian Weimer
2020-08-26 21:02 ` [PATCH 4/4] io: Reorganize the getcwd implementation Adhemerval Zanella
2020-08-26 22:39   ` Paul Eggert
2020-08-27 12:35   ` Adhemerval Zanella
2020-08-27 13:21     ` Florian Weimer
2020-08-27 13:40       ` Adhemerval Zanella
2020-08-27 17:29     ` Adhemerval Zanella
2020-08-27 19:20   ` [PATCH v2] " Adhemerval Zanella
2020-08-27 23:44     ` Paul Eggert
2020-08-31 18:27       ` Adhemerval Zanella [this message]
2020-08-26 22:39 ` [PATCH 1/4] Sync getcwd with gnulib Paul Eggert
2020-08-27 11:07   ` Adhemerval Zanella
2020-08-27  8:14 ` Florian Weimer
2020-08-27 10:53   ` Adhemerval Zanella
2020-08-27 10:58     ` Florian Weimer
2020-08-27 11:06       ` Adhemerval Zanella
2020-08-27 11:10         ` Florian Weimer
2020-08-27 11:33           ` Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d7d2084-b1df-f6bd-bc55-5e868b6acaa9@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=eggert@cs.ucla.edu \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).