From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 781EB3858D34 for ; Wed, 21 Feb 2024 17:19:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 781EB3858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 781EB3858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708535965; cv=none; b=g4B8FVk9UZZ3IMz76cjxpQqJccvEFsxwhKpTpO5NVnA8aO+6od/2MCF9W7lWxsimFB2E0fD0f8n8rMxx8JbDlGrno7vrWwUdyrKJblgXbW0Ka5ampeu12B5MmjbmJ2NFG+NeQwm3422EqWRZOuYo04ha9MwQhsE+Kcya570ZlUk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708535965; c=relaxed/simple; bh=D7JicCU3n2TVw9sHfQBhbXRJpoXLFe1JDIhjEllnqVY=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=Axc9cOddLlXBbUwzjF1OWQiCHaH7UZUwE37Cq5ajPwubROIj94YHSikNUFaXF8UzNRYkFD3yn1cv8LdcrqAop/51uYPG4i9jRMAW4yfR6uEECWb/ffxddd9/xCeuPQLe34AkQT/3d+GR1DeCvY7nDaIxL4ihIbx8dmr7d68ZodA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708535963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hzH74UHyTROVf6SjPthlUWuxWcgfifuQLivB33trI9g=; b=cdRs9edxihyLZJXYuvjd8PTuq0sXbOZP1SxEmYxm/cLTH5EfWhvVMAgAwNw7hnn6ZhH2NT fYdsnItUfLtvq/7KTHZ3IGN7Sk8yvzc2BiaYEj78iEYG4Rx1wLjN0EfIQs+p+oWuxDlcXS 7zeUYagVYcDFWHB7g+SZdeLh2NM2MeU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-304-V2erHn_INaaqHwBlQ-QVpA-1; Wed, 21 Feb 2024 12:19:21 -0500 X-MC-Unique: V2erHn_INaaqHwBlQ-QVpA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-40fb505c97aso4381255e9.3 for ; Wed, 21 Feb 2024 09:19:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708535960; x=1709140760; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hzH74UHyTROVf6SjPthlUWuxWcgfifuQLivB33trI9g=; b=dO78BM7L1aChXQSIj8O7UGILrnNyxY4xBOYuiZfHEasuhMHhCT0bBSAJ2zMo/1wjKP eC0vBHr2PEdklPVwjWTvDkNI5kU46ZCDU7YWwXo7Pq9GxfakAuxJCDMyeLIeArii0R+H f9byszWtV6ixkXgQWiP8HRO7u+KwX4sAssj0TUU1Jm3SaIKVjRS+7/3hJVM7X8ILjkha wVoY0jAuBQ7GkoRnX4gdGh2VKMTGkMvZzRID0DMdJ0Xd5/5mI8QXN7gzyYX3cElsGIOh emZPYn6MVVCcByFY06deeso7tXnKHrKGuO37pRDdMglSeihuMaOMyHftx2z1ahI0ry2t y0KA== X-Gm-Message-State: AOJu0YxY2xL9tJ/KzjN4J/i8w8aQDju9gjCz8PVwaP0kLgM10xXO/xkf vpvk7X/T3tReQHla1NS7shF6gT7xY9syCeBCx8YH8bUl6NbxY3wp+WFpz94qT92GA2fFSpr7XCi eGwaB5laMAx7axoy6FCDXZl5xw66YGvw17pUyNce4oG5oqWxkI2xNy2ulxA== X-Received: by 2002:a05:600c:6010:b0:412:78c8:c659 with SMTP id az16-20020a05600c601000b0041278c8c659mr1161326wmb.16.1708535960232; Wed, 21 Feb 2024 09:19:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IHfSqC3OZwcPHo7RcS5vnwpf4WV6rqCJMe2VbdilRr4T/NDy7SOd3KpszrLwfslNWqnPHXfJw== X-Received: by 2002:a05:600c:6010:b0:412:78c8:c659 with SMTP id az16-20020a05600c601000b0041278c8c659mr1161316wmb.16.1708535959930; Wed, 21 Feb 2024 09:19:19 -0800 (PST) Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id f2-20020adfe902000000b0033cf24700e5sm17397505wrm.39.2024.02.21.09.19.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 09:19:19 -0800 (PST) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.95) (envelope-from ) id 1rcqFa-004CQG-KR; Wed, 21 Feb 2024 17:19:18 +0000 Date: Wed, 21 Feb 2024 17:19:18 +0000 (UTC) From: Joseph Myers To: Florian Weimer cc: libc-alpha@sourceware.org Subject: Re: [PATCH v3 10/32] elf: Make usable in ld.so In-Reply-To: <9c999f5c5ccb5d3850192760e40185cb1f04f603.1701944612.git.fweimer@redhat.com> Message-ID: <3d85d0a4-9a40-9046-d0a2-d7e5f0f345dd@redhat.com> References: <9c999f5c5ccb5d3850192760e40185cb1f04f603.1701944612.git.fweimer@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 7 Dec 2023, Florian Weimer wrote: > __libc_alloc_buffer_create_failure used to snprintf, which is not > available in ld.so. The size information in the error message > is probably not that useful, so remove it. This makes the size argument to __libc_alloc_buffer_create_failure unused; the start argument was already unused. Unless there is some reason to have unused arguments (to look at them under a debugger, or something like that), which would need comments explaining the reason, I think it would be best to remove both unused arguments. -- Joseph S. Myers josmyers@redhat.com