public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
	Florian Weimer <fw@deneb.enyo.de>
Cc: Xiaoming Ni <nixiaoming@huawei.com>,
	libc-alpha@sourceware.org, drepper.fsp@gmail.com, roland@gnu.org,
	carlos@redhat.com, wangle6@huawei.com, yukeji@huawei.com
Subject: Re: [PATCH v2] stdlib: realpath use malloc replace __alloca to reduce stack overflow risks [BZ #26341]
Date: Tue, 11 Aug 2020 02:54:01 -0700	[thread overview]
Message-ID: <3da08d2a-71ca-83ca-0938-5569dbf0b548@cs.ucla.edu> (raw)
In-Reply-To: <9fe6ee87-129b-29fa-d9df-eca359bd866f@linaro.org>

On 8/10/20 6:40 AM, Adhemerval Zanella wrote:
> Could we remove alloca as well? We can make 4k stack usage on most cases use the
> extra 4k only where link are seeing the path.

Yes, the only "cost" of that is that the function will always use 4K (or 
whatever) instead of typically using far less than 4K.

      reply	other threads:[~2020-08-11  9:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-07 10:16 Xiaoming Ni
2020-08-07 19:43 ` Adhemerval Zanella
2020-08-08  0:00   ` Paul Eggert
2020-08-08  9:14   ` Xiaoming Ni
2020-08-07 23:56 ` Paul Eggert
2020-08-08  8:54   ` Xiaoming Ni
2020-08-09  8:44     ` Paul Eggert
2020-08-09 12:38       ` Florian Weimer
2020-08-09 17:22         ` Paul Eggert
2020-08-10 13:40           ` Adhemerval Zanella
2020-08-11  9:54             ` Paul Eggert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3da08d2a-71ca-83ca-0938-5569dbf0b548@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=adhemerval.zanella@linaro.org \
    --cc=carlos@redhat.com \
    --cc=drepper.fsp@gmail.com \
    --cc=fw@deneb.enyo.de \
    --cc=libc-alpha@sourceware.org \
    --cc=nixiaoming@huawei.com \
    --cc=roland@gnu.org \
    --cc=wangle6@huawei.com \
    --cc=yukeji@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).