From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa32.google.com (mail-vk1-xa32.google.com [IPv6:2607:f8b0:4864:20::a32]) by sourceware.org (Postfix) with ESMTPS id 304AB3857813 for ; Fri, 22 Oct 2021 20:39:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 304AB3857813 Received: by mail-vk1-xa32.google.com with SMTP id r26so2126995vkq.0 for ; Fri, 22 Oct 2021 13:39:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=2rQRlXYLUKXgS44Xabz+lWqCy6S1wnwV6vdnKno86fA=; b=PqRO2oOATc/JC5VuEjMraLKjQ/XaQAzy7HSJDnBgLi8mBiziIYHa6m/iB6YEzRJGGv CCibOTRfqk2TQ4HESzKPhgnOSk6D3WHQT/LCHMT9VhRt2wiB6E6/cel1fMpnc9BfnNKK fIN+ALb+e2B5Q/nQ69w+qMSrSssRzdTo1AyoAQ+7zI0b9rxqajjuj9OZU/ec7i2z6GvP 2L4RhfpEPm5URj8vWp2RV7wXvoSx9PKOt6ZSNh3Lv8hNUMVFsnAjb2YFlQJVDHbGJ0ff 0/Ku1CRVWnBkroLwnwM/sElu0NF1yNWzJeaEA51M8iyDxMYS7Yck9lFr557+/WXNKXdC xFyw== X-Gm-Message-State: AOAM531Y45rkrf6JtT5wPnrB2lFuOVPboBDZe25lAhTmCPckT2Y8gsUt uG//UXjdUc0b1EHkNC7Wp0sh5g== X-Google-Smtp-Source: ABdhPJxarFNQXTKaq6RNuk4SSdGxoigNXkyZYk4ey22Vi8dsqNwsNoTx+Ok4/NlonI2qmq6cWvu7bQ== X-Received: by 2002:a05:6122:c89:: with SMTP id ba9mr2611617vkb.25.1634935139818; Fri, 22 Oct 2021 13:38:59 -0700 (PDT) Received: from ?IPV6:2804:431:c7ca:2654:4efb:b2d3:2dbc:5b5a? ([2804:431:c7ca:2654:4efb:b2d3:2dbc:5b5a]) by smtp.gmail.com with ESMTPSA id l20sm5789097vka.38.2021.10.22.13.38.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Oct 2021 13:38:59 -0700 (PDT) Message-ID: <3dc02603-3318-e0d3-8c67-8610e923e751@linaro.org> Date: Fri, 22 Oct 2021 17:38:57 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCH] Add missing math functions to benchtests Content-Language: en-US To: Sunil K Pandey , libc-alpha@sourceware.org References: <20211022190416.1736398-1-skpgkp2@gmail.com> From: Adhemerval Zanella In-Reply-To: <20211022190416.1736398-1-skpgkp2@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-14.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2021 20:39:02 -0000 On 22/10/2021 16:04, Sunil K Pandey via Libc-alpha wrote: > Add acosf, acoshf, asinf, asinhf, atan2f, atanf, atanhf, cbrtf, coshf, > erfcf, erff, expm1f, hypotf, log10f, log1pf, sinhf, tanf and tanhf > functions to math benchtests. Please split one patch per function and add a rationale on how each input were generate. Keep in mind that using pure random values might not be meaningful (as Joseph has noted for my recent hypot/hypotf one [1]. [1] https://sourceware.org/pipermail/libc-alpha/2021-October/131753.html > diff --git a/benchtests/Makefile b/benchtests/Makefile > index 4fcd73131a..a250a41664 100644 > --- a/benchtests/Makefile > +++ b/benchtests/Makefile > @@ -28,6 +28,9 @@ bench-math := acos acosh asin asinh atan atanh cos cosh exp exp2 log log2 \ > exp10f ilogb ilogbf cbrt erf erfc exp10 expm1 j0 j1 lgamma \ > log10 log1p tgamma y0 y1 atan2 > > +bench-math += acosf acoshf asinf asinhf atan2f atanf atanhf cbrtf coshf \ > + erfcf erff expm1f hypotf log10f log1pf sinhf tanf tanhf > + > ifneq (,$(filter yes,$(float96-fcts))) > bench-math += cbrtl > endif For new rules I is better one input per line. In this case: bench-math += \ acosf \ acoshf \ ... tanhf \ (the last line does have a line continuation, it helps git diff).