From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by sourceware.org (Postfix) with ESMTPS id 1086B3858016 for ; Mon, 8 Nov 2021 19:46:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1086B3858016 Received: by mail-qt1-x82e.google.com with SMTP id x10so14396942qta.6 for ; Mon, 08 Nov 2021 11:46:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=MKaHIl2ce80YpnAjx7ZpLWfRZX2TM5sGSgJqC7byfvw=; b=sXU27P8FbcMp5Dbp1TfCXwDNeuUm4EPuLlg+3hqCF5eslijrGtskEoC3BLS+WX/p9K fmjk09i1IBbkV1RZBZuTq2p3Iivtzb/6V2cXT4gU7ji1/H271Fg21FapHwdxFu1znTSV ZLMvECmPRX1UUlcp2JVLdzGE3ywmol/YD0oSccWNZtB6xK81AX1eaIq5SasVepow9TH5 K+xemO1gKnl5qwv7r/3K63OmzoRNwXmUO6Dc6C8gGEHhXAnIVCgDTIy9mZSF3CxymktB 4kL5+UKsFVM0x2WqLjsFKwEfu+nuaPZ04DiQH/m1SHsyNwdYZXFTFnWEbgPx+NUD30aY UDuw== X-Gm-Message-State: AOAM533FsPGwsNX3bjG0HITnaasG7D4QT8ArJI3UT4OVAMPDVoKVEa9u GV6O9s7QxVgaHus+j1xaXUhzgNjAPoN4NQ== X-Google-Smtp-Source: ABdhPJzgM8zVHFuF86vyVMjkGFrYW61YqkhwhZT3vbce+gumZ0/4g+Jr9NQop2SmJifM1lOqKXVS4Q== X-Received: by 2002:a05:622a:1a03:: with SMTP id f3mr2217624qtb.141.1636400791597; Mon, 08 Nov 2021 11:46:31 -0800 (PST) Received: from ?IPV6:2804:431:c7cb:55a:c067:29b:4c08:be99? ([2804:431:c7cb:55a:c067:29b:4c08:be99]) by smtp.gmail.com with ESMTPSA id m4sm1938700qtu.87.2021.11.08.11.46.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Nov 2021 11:46:31 -0800 (PST) Message-ID: <3de9481f-07fe-11fb-d00b-8ad5563fd831@linaro.org> Date: Mon, 8 Nov 2021 16:46:29 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH] test-memcpy.c: Double TIMEOUT to (8 * 60) Content-Language: en-US To: Noah Goldstein , "H.J. Lu" Cc: GNU C Library References: <20211107160829.1004634-1-hjl.tools@gmail.com> <2e15794f-555c-30f1-f774-f23839146da6@linaro.org> From: Adhemerval Zanella In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Nov 2021 19:46:34 -0000 On 08/11/2021 16:43, Noah Goldstein wrote: > On Mon, Nov 8, 2021 at 8:02 AM Noah Goldstein wrote: >> >> On Mon, Nov 8, 2021 at 7:14 AM H.J. Lu via Libc-alpha >> wrote: >>> >>> On Mon, Nov 8, 2021 at 3:39 AM Adhemerval Zanella >>> wrote: >>>> >>>> >>>> >>>> On 07/11/2021 13:08, H.J. Lu via Libc-alpha wrote: >>>>> commit d585ba47fcda99fdf228e3e45a01b11a15efbc5a >>>>> Author: Noah Goldstein >>>>> Date: Mon Nov 1 00:49:48 2021 -0500 >>>>> >>>>> string: Make tests birdirectional test-memcpy.c >>>>> >>>>> This commit updates the memcpy tests to test both dst > src and dst < >>>>> src. This is because there is logic in the code based on the >>>>> >>>>> Signed-off-by: Noah Goldstein >>>>> Reviewed-by: H.J. Lu >>>>> >>>>> significantly increased the number of tests. On Intel Core i7-1165G7, >>>>> test-memcpy takes 120 seconds to run when machine is idle. Double >>>>> TIMEOUT to (8 * 60) for test-memcpy to avoid timeout when machine is >>>>> under heavy load. >>>> >>>> Shouldn't we split the test instead? If it takes 120s on a high-end chip, >>>> it might take way more in other chips. It also optimizes the testsuite, >>>> since it would allow to better use parallel builds. >>> >>> This sounds like a good idea. Noah, can you do that? > > The reality is 95% of the extra test time is from the additional large > memcpy tests in `#ifdef DO_EXTRA_TESTS` region. Not sure > there is really any value in making a seperate test for them as > I think the runtime would still require the larger timeout. > > Do we still want it? Alternatively I could cut out some of the tests. Maybe spawn multiple processes to cover different sizes within the loop (something analogous to #omp for)?