From: Qingqing Li <liqingqing3@huawei.com>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
<hjl.tools@gmail.com>, Hushiyuan <hushiyuan@huawei.com>
Subject: Re: [PATCH]x86: update REP_STOSB_THRESHOLD's default value from 2k to 1M
Date: Tue, 22 Dec 2020 09:02:26 +0800 [thread overview]
Message-ID: <3e1ed68a-0bfe-8769-8542-8f5c44355168@huawei.com> (raw)
In-Reply-To: <df69422b-404d-82fb-bc7e-d71603bea197@gotplt.org>
OK, thanks.
On 2020/12/21 12:38, Siddhesh Poyarekar wrote:
> On 5/23/20 9:40 AM, liqingqing wrote:
>> this commitid 830566307f038387ca0af3fd327706a8d1a2f595 optimize implementation of function memset,
>> and set macro REP_STOSB_THRESHOLD's default value to 2KB, when the input value is less than 2KB, the data flow is the same, and when the input value is large than 2KB,
>> this api will use STOB to instead of MOVQ
>>
>> but when I test this API on x86_64 platform
>> and found that this default value is not appropriate for some input length. here it's the enviornment and result
>
> This patch is not needed anymore since the threshold has been made a tunable: glibc.cpu.x86_rep_movsb_threshold.
>
> Siddhesh
> .
prev parent reply other threads:[~2020-12-22 1:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 7:30 pthread_cond performence Discussion liqingqing
2020-03-18 12:12 ` Carlos O'Donell
2020-03-18 12:53 ` Torvald Riegel
2020-03-18 14:42 ` Carlos O'Donell
2020-05-23 4:04 ` liqingqing
2020-05-23 4:10 ` [PATCH]x86: update REP_STOSB_THRESHOLD's default value from 2k to 1M liqingqing
2020-05-23 4:37 ` [PATCH] x86: Add thresholds for "rep movsb/stosb" to tunables H.J. Lu
2020-05-28 11:56 ` H.J. Lu
2020-05-28 13:47 ` liqingqing
2020-05-29 13:13 ` Carlos O'Donell
2020-05-29 13:21 ` H.J. Lu
2020-05-29 16:18 ` Carlos O'Donell
2020-06-01 19:32 ` H.J. Lu
2020-06-01 19:38 ` Carlos O'Donell
2020-06-01 20:15 ` H.J. Lu
2020-06-01 20:19 ` H.J. Lu
2020-06-01 20:48 ` Florian Weimer
2020-06-01 20:56 ` Carlos O'Donell
2020-06-01 21:13 ` H.J. Lu
2020-06-01 22:43 ` H.J. Lu
2020-06-02 2:08 ` Carlos O'Donell
2020-06-04 21:00 ` [PATCH] libc.so: Add --list-tunables H.J. Lu
2020-06-05 22:45 ` V2 " H.J. Lu
2020-06-06 21:51 ` V3 [PATCH] libc.so: Add --list-tunables support to __libc_main H.J. Lu
2020-07-02 18:00 ` Carlos O'Donell
2020-07-02 19:08 ` [PATCH] Update tunable min/max values H.J. Lu
2020-07-03 16:14 ` Carlos O'Donell
2020-07-03 16:54 ` [PATCH] x86: Add thresholds for "rep movsb/stosb" to tunables H.J. Lu
2020-07-03 17:43 ` Carlos O'Donell
2020-07-03 17:53 ` H.J. Lu
2020-12-21 4:38 ` [PATCH]x86: update REP_STOSB_THRESHOLD's default value from 2k to 1M Siddhesh Poyarekar
2020-12-22 1:02 ` Qingqing Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e1ed68a-0bfe-8769-8542-8f5c44355168@huawei.com \
--to=liqingqing3@huawei.com \
--cc=hjl.tools@gmail.com \
--cc=hushiyuan@huawei.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).