From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-74190-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 101396 invoked by alias); 28 Oct 2016 16:48:36 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 101379 invoked by uid 89); 28 Oct 2016 16:48:36 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=secret
X-HELO: mail-qk0-f180.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:subject:to:references:from:organization
         :message-id:date:user-agent:mime-version:in-reply-to
         :content-transfer-encoding;
        bh=FOHTLEycy6/oM1Ac2cvA9087enG+R+8rXN/Ad3IwY34=;
        b=BNIowH0zFtD6LeIpWGFoeTlvLKdrgUH6rfKCbh79U3Jb9gdGigTbi2/f3L1qohlO61
         x2vn1sdS6VkYDKH/62jvcNLTVCiVY2uQNNOGMuOQwHQZwuOT2G9sKswWhL22LAdgRkkU
         GKYAFuOpBxLslLXzuSZAX5jfKn8fh6wXnfzoSiBLn+NN5TddvYvyVxK8oEKjWl/Gayeg
         zDdhUmQuhjP6YeBwR30W7u8nQ7DGdbuZySJPiFFx0FgeDS8henic0boj6Z3w9wDDYecO
         I2V1lRPpGtRZu6xYi5lHL+TG3aXQCrM8Qww8KT2rS+U0bMFj0c2hohaTx2tIJLq4XNWN
         3RiA==
X-Gm-Message-State: ABUngvcvuhrUTLxww26EwI6G8N4NB/63bDk/oXI9fEL45r3tw57sqUGoqHp35zwHvXrQRL0w
X-Received: by 10.233.239.204 with SMTP id d195mr10955506qkg.313.1477673313583;
        Fri, 28 Oct 2016 09:48:33 -0700 (PDT)
Subject: Re: [PATCH] Generate additional secret keys for the heap protector
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
References: <20161028130509.A74DC439942E0@oldenburg.str.redhat.com>
 <b86a9fdf-65c5-fc19-3e9c-63d3545a34f1@redhat.com>
 <bd0185d8-1172-f9b8-eef1-1d01a71be23f@redhat.com>
From: Carlos O'Donell <carlos@redhat.com>
Message-ID: <3e430eea-43d5-fc47-bdb6-30cf327d38d4@redhat.com>
Date: Fri, 28 Oct 2016 16:48:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <bd0185d8-1172-f9b8-eef1-1d01a71be23f@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-10/txt/msg00550.txt.bz2

On 10/28/2016 11:39 AM, Florian Weimer wrote:
> On 10/28/2016 04:46 PM, Carlos O'Donell wrote:
>> Florian,
>>
>> Awesome patch. This is looking really good and the expansion of entropy
>> into the keys using sha256 looks great.
>>
>> OK to checkin if you:
>>
>> * Fix spelling.
>> * Remove _dl_setup_pointer_guard linux+generic implementation as unused.
>> * Remove _dl_setup_stack_chk_guard linux+generic implementation as unused
> 
> New version attached. I'm waiting until the libcrypt fix is checked
> in (I'll try to test on SPARC and commit if successful). And it only
> makes sense to have this change if we end up with the heap protector,
> so I'll wait for that, too.

This version looks good to me.

-- 
Cheers,
Carlos.