From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 43C7A3858D33 for ; Tue, 31 Jan 2023 22:38:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 43C7A3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675204691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RJOk/SdBU5B3FqC6tc1AMIO+qyOJG8iNWV0vQh+t0I0=; b=iOVPx30ABPellBcSWkmNYa0oRVvDLyyXwkDOTo56XEPBgiYwLhdzMB6ehHQ1yF5jOCtssH FVdUPwaiRhejFDZ97eyxqmY/CH7QjhEdAazR/Q5+5fwPIVloq+8ytPfWABlu1/aetwu1B/ 7k7qXzsFQhdt6cHbm+L3jRVwKspz88g= Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-635-JDVED22MMKGxyhz5cMc1VA-1; Tue, 31 Jan 2023 17:38:10 -0500 X-MC-Unique: JDVED22MMKGxyhz5cMc1VA-1 Received: by mail-il1-f198.google.com with SMTP id o10-20020a056e02102a00b003006328df7bso10387374ilj.17 for ; Tue, 31 Jan 2023 14:38:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RJOk/SdBU5B3FqC6tc1AMIO+qyOJG8iNWV0vQh+t0I0=; b=DpwqDish+69Jcyg0spKzMDL8p9gu2b2KkmrjvLxNGhQZOQqODFLBbx6Ocw83eux1oT 8BybgUdtAUMivyboeh93tgNe8ZoNNj+KeCY/R+iUAaWsNabfub1NioBzfHHAc7VUydPO 4elktpILoQjtemrRkw9UaeYwxhM/mLw03qCoTHUPEBTM813ge5u1VocJuFGgZ+0n2AFH q279uQJlgpt+v2YZgUCLMNfhU5HXXstp+eg319oJLmprWVtng05by3RzEueGc7BHBS8z tOPNEwH3qWNQLiC/QC7nWmj/R2MrTLvyq/tB0KujrSUUhxki+wb45Pn3pa/7OmMFYtB8 0t4g== X-Gm-Message-State: AO0yUKU2Cu4ePupmf4xkvBcxG2jwvFe9Ixh1yZwMp6ASwxFoV2LZZbeA ulhX8ErdY4AEPhh08ySJJJwcFxh91XsgIHxED279w+MW6OMM6ZdH+LKGLQV8hPGIfxi1ZjY5/Gt R3XYISdgZYgBruwfXfLxa X-Received: by 2002:a6b:8d4d:0:b0:704:cfbe:ce90 with SMTP id p74-20020a6b8d4d000000b00704cfbece90mr128567iod.7.1675204689764; Tue, 31 Jan 2023 14:38:09 -0800 (PST) X-Google-Smtp-Source: AK7set+vB4CtROb3j5vte1QWNmL5498JI2UdUt+SPloJTkHKxW7pstuXURGEzQW5gGV5P2nqFRWzqQ== X-Received: by 2002:a6b:8d4d:0:b0:704:cfbe:ce90 with SMTP id p74-20020a6b8d4d000000b00704cfbece90mr128559iod.7.1675204689527; Tue, 31 Jan 2023 14:38:09 -0800 (PST) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id y193-20020a6bc8ca000000b006e02c489089sm4224610iof.32.2023.01.31.14.38.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Jan 2023 14:38:09 -0800 (PST) Message-ID: <3e623ac3-aee1-2244-174c-12e57e2c592b@redhat.com> Date: Tue, 31 Jan 2023 17:38:08 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: revised patch for hp-timing.h To: "Tang, Jun" , GNU libc development , DJ Delorie References: <5eaed0800f8741658abb9073693660dd@amazon.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <5eaed0800f8741658abb9073693660dd@amazon.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/31/23 12:19, Tang, Jun via Libc-alpha wrote: > I have revised the patch to fix the hp-timing.h bug (bug 29329). Thanks for sending the new version. Out of curiosity, how are you sending the patch to the mailing list? The CI/CD system can't apply the patch as it would expect: https://patchwork.sourceware.org/project/glibc/patch/5eaed0800f8741658abb9073693660dd@amazon.com/ > Regards, > > Jun > > > ``` > diff --git a/sysdeps/aarch64/hp-timing.h b/sysdeps/aarch64/hp-timing.h > index f7f7ac7cae..c699effe6a 100644 > --- a/sysdeps/aarch64/hp-timing.h > +++ b/sysdeps/aarch64/hp-timing.h > @@ -41,7 +41,7 @@ typedef uint64_t hp_timing_t; > #define HP_TIMING_DIFF(Diff, Start, End) \ > ({ hp_timing_t freq; \ > __asm__ __volatile__ ("mrs %0, cntfrq_el0" : "=r" (freq)); \ > - (Diff) = ((End) - (Start)) * (UINT64_C(1000000000) / freq); \ > + (Diff) = (((End) - (Start)) * UINT64_C(1000000000)) / freq; \ > }) > #endif /* hp-timing.h */ > ``` -- Cheers, Carlos.