From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by sourceware.org (Postfix) with ESMTPS id 5ED113858D28 for ; Tue, 14 Dec 2021 12:10:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5ED113858D28 Received: by mail-qt1-x82e.google.com with SMTP id v22so18106876qtx.8 for ; Tue, 14 Dec 2021 04:10:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=wiZV28HfiCtxjbBaVv1XN2pFU4DbzphxYqFYesAbn9Q=; b=ou7qJVqt17yeIOO0wae/P/Q4pl5tSHWvqkp0wqf5E+0BblFmZrG2k5IbLcIC4TJBGe ccB+Jq0dJm5y/pdpzxFgGkknHy71rly/bzf99GgY/JxJrNrWpn7o1iSMajz9WwB49L6l 37aAQo+rkVAGkSGHSFxcCLZopbWZxf2bbt8MA03M29wvupfwDyUJL3ppvnBZtn74jZOR wBxyjsCtpKwydD468uAX215FaoB6QT3SNGDsW9X81uiPaQ6bEGmBkqgPstG38Y5CL3Iu cPa6j60LTTPzI4qpXr4Nd7vXO2+jWFtbN5wNlG9L8L/Ie69AusQKS2QGrj+IkVUP7Fhn YWEg== X-Gm-Message-State: AOAM530HMdqp9y8HcuqXu/mLsNzuMD6ZQPRXLQtTTZGPpo9PHQjvO91a TYCjepdkm0uESvSU6PhzBiY46Q== X-Google-Smtp-Source: ABdhPJxuIzJ3LM1G4bAXXFGCXkivBgFRy1j5yKw1dwg6ejGxyHz5XY9sh2q35mSDOHLzdjZJmLU28g== X-Received: by 2002:ac8:1088:: with SMTP id a8mr5246307qtj.653.1639483839899; Tue, 14 Dec 2021 04:10:39 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:a776:8dc8:480e:fc02:618b? ([2804:431:c7ca:a776:8dc8:480e:fc02:618b]) by smtp.gmail.com with ESMTPSA id v21sm12317093qta.0.2021.12.14.04.10.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Dec 2021 04:10:39 -0800 (PST) Message-ID: <3ecb8e35-e01d-4b38-898b-3ec8821ef187@linaro.org> Date: Tue, 14 Dec 2021 09:10:37 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH] elf: Use new dependency sorting algorithm by default Content-Language: en-US To: Florian Weimer , libc-alpha@sourceware.org References: <87fsqvqu62.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <87fsqvqu62.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-14.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Dec 2021 12:10:43 -0000 On 14/12/2021 08:53, Florian Weimer wrote: > The default has to change eventually, and there are no known failures > that require a delay. > > Tested on i686-linux-gnu and x86_64-linux-gnu. > LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > NEWS | 7 ++++--- > elf/dl-tunables.list | 2 +- > elf/tst-rtld-list-tunables.exp | 2 +- > manual/tunables.texi | 2 +- > 4 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/NEWS b/NEWS > index b53f230cca..2aaece42f5 100644 > --- a/NEWS > +++ b/NEWS > @@ -60,9 +60,10 @@ Major new features: > of the existing sorting algorithm when encountering particular circular > object dependency cases. > > -* A new tunable, glibc.rtld.dynamic_sort, can be used to select between the two > - DSO sorting algorithms. The default setting of '1' uses the current existing > - algorithm, while a value of '2' selects the new DFS-based algorithm. > +* A new tunable, glibc.rtld.dynamic_sort, can be used to select between > + the two DSO sorting algorithms. The default setting of '2' uses the > + new DFS-based algorithm. The setting '1' switches to the old > + algorithm used in glibc 2.33 and earlier. > > * ABI support for a new function '__memcmpeq'. '__memcmpeq' is meant > to be used by compilers for optimizing usage of 'memcmp' when its > diff --git a/elf/dl-tunables.list b/elf/dl-tunables.list > index 46ffb23784..ffcd7f18d4 100644 > --- a/elf/dl-tunables.list > +++ b/elf/dl-tunables.list > @@ -162,7 +162,7 @@ glibc { > type: INT_32 > minval: 1 > maxval: 2 > - default: 1 > + default: 2 > } > } > } > diff --git a/elf/tst-rtld-list-tunables.exp b/elf/tst-rtld-list-tunables.exp > index 9bf572715f..44e4834cfb 100644 > --- a/elf/tst-rtld-list-tunables.exp > +++ b/elf/tst-rtld-list-tunables.exp > @@ -10,6 +10,6 @@ glibc.malloc.tcache_max: 0x0 (min: 0x0, max: 0x[f]+) > glibc.malloc.tcache_unsorted_limit: 0x0 (min: 0x0, max: 0x[f]+) > glibc.malloc.top_pad: 0x0 (min: 0x0, max: 0x[f]+) > glibc.malloc.trim_threshold: 0x0 (min: 0x0, max: 0x[f]+) > -glibc.rtld.dynamic_sort: 1 (min: 1, max: 2) > +glibc.rtld.dynamic_sort: 2 (min: 1, max: 2) > glibc.rtld.nns: 0x4 (min: 0x1, max: 0x10) > glibc.rtld.optional_static_tls: 0x200 (min: 0x0, max: 0x[f]+) > diff --git a/manual/tunables.texi b/manual/tunables.texi > index 5d50b90f64..28ff502990 100644 > --- a/manual/tunables.texi > +++ b/manual/tunables.texi > @@ -318,7 +318,7 @@ value of @samp{2}, a different algorithm is used, which implements a > topological sort through depth-first search, and does not exhibit the > performance issues of @samp{1}. > > -The default value of this tunable is @samp{1}. > +The default value of this tunable is @samp{2}. > @end deftp > > @node Elision Tunables >