public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Szabolcs Nagy <szabolcs.nagy@arm.com>
To: libc-alpha@sourceware.org
Subject: [PATCH v4 06/10] elf: Avoid RELATIVE relocation for _dl_sysinfo
Date: Mon, 18 Jan 2021 16:24:48 +0000	[thread overview]
Message-ID: <3ed8c627e3f1353e5539b458e596c4112121b3ba.1610986541.git.szabolcs.nagy@arm.com> (raw)
In-Reply-To: <cover.1610986541.git.szabolcs.nagy@arm.com>

From: "H.J. Lu" <hjl.tools@gmail.com>

In static PIE, set the default _dl_sysinfo in _dl_aux_init, instead of
using the RELATIVE relocation to intialize it.

This is needed for fixing bug 27072 on x86.
---
 elf/dl-support.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/elf/dl-support.c b/elf/dl-support.c
index 384080dd80..5acd59290f 100644
--- a/elf/dl-support.c
+++ b/elf/dl-support.c
@@ -200,7 +200,12 @@ struct dl_scope_free_list *_dl_scope_free_list;
 
 #ifdef NEED_DL_SYSINFO
 /* Needed for improved syscall handling on at least x86/Linux.  */
-uintptr_t _dl_sysinfo = DL_SYSINFO_DEFAULT;
+uintptr_t _dl_sysinfo
+/* NB: Avoid RELATIVE relocation in static PIE.  */
+# ifndef BUILD_PIE_DEFAULT
+  = DL_SYSINFO_DEFAULT
+# endif
+;
 #endif
 #ifdef NEED_DL_SYSINFO_DSO
 /* Address of the ELF headers in the vsyscall page.  */
@@ -238,6 +243,11 @@ _dl_aux_init (ElfW(auxv_t) *av)
   uid_t uid = 0;
   gid_t gid = 0;
 
+#if defined NEED_DL_SYSINFO && BUILD_PIE_DEFAULT
+  /* NB: Avoid RELATIVE relocation in static PIE.  */
+  GL(dl_sysinfo) = DL_SYSINFO_DEFAULT;
+#endif
+
   _dl_auxv = av;
   for (; av->a_type != AT_NULL; ++av)
     switch (av->a_type)
-- 
2.17.1


  parent reply	other threads:[~2021-01-18 16:25 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18 16:22 [PATCH v4 00/10] fix ifunc with static pie [BZ #27072] Szabolcs Nagy
2021-01-18 16:23 ` [PATCH v4 01/10] configure: Require PI_STATIC_AND_HIDDEN for static pie Szabolcs Nagy
2021-01-18 16:23 ` [PATCH v4 02/10] libmvec: Add extra-test-objs to test-extras Szabolcs Nagy
2021-01-18 20:04   ` Adhemerval Zanella
2021-01-18 16:23 ` [PATCH v4 03/10] elf: Make the tunable struct definition internal only Szabolcs Nagy
2021-01-18 16:24 ` [PATCH v4 04/10] elf: Avoid RELATIVE relocs in __tunables_init Szabolcs Nagy
2021-01-18 16:24 ` [PATCH v4 05/10] Use hidden visibility for early static PIE code Szabolcs Nagy
2021-01-18 21:49   ` Adhemerval Zanella
2021-01-18 16:24 ` Szabolcs Nagy [this message]
2021-01-19 13:51   ` [PATCH v4 06/10] elf: Avoid RELATIVE relocation for _dl_sysinfo Adhemerval Zanella
2021-01-19 14:25     ` V2 " H.J. Lu
2021-01-19 14:35       ` Adhemerval Zanella
2021-01-18 16:25 ` [PATCH v4 07/10] Use <startup.h> in __libc_init_secure Szabolcs Nagy
2021-01-19 13:56   ` Adhemerval Zanella
2021-01-18 16:25 ` [PATCH v4 08/10] csu: Move static pie self relocation later [BZ #27072] Szabolcs Nagy
2021-01-19 14:07   ` Adhemerval Zanella
2021-01-19 14:35     ` Szabolcs Nagy
2021-01-19 14:36       ` Adhemerval Zanella
2021-01-19 14:48         ` H.J. Lu
2021-01-19 15:24           ` Szabolcs Nagy
2021-01-19 15:32             ` H.J. Lu
2021-01-19 16:47               ` H.J. Lu
2021-01-19 17:03                 ` Szabolcs Nagy
2021-01-19 17:10                   ` H.J. Lu
2021-01-19 17:25                     ` Fāng-ruì Sòng
2021-01-19 17:33                       ` H.J. Lu
2021-01-19 17:38                         ` Fāng-ruì Sòng
2021-01-19 17:38                     ` Szabolcs Nagy
2021-01-19 17:42                       ` H.J. Lu
2021-01-19 17:47                         ` Szabolcs Nagy
2021-01-19 17:53                           ` H.J. Lu
2021-01-19 17:59                             ` H.J. Lu
2021-01-18 16:25 ` [PATCH v4 09/10] x86: Check ifunc resolver with CPU_FEATURE_USABLE " Szabolcs Nagy
2021-01-19 14:11   ` Adhemerval Zanella
2021-01-19 14:37     ` V2 " H.J. Lu
2021-01-21 16:33       ` H.J. Lu
2021-01-18 16:26 ` [PATCH v4 10/10] Make libc symbols hidden in static PIE Szabolcs Nagy
2021-01-18 21:37 ` [PATCH v4 00/10] fix ifunc with static pie [BZ #27072] Adhemerval Zanella
2021-01-19 18:25   ` Szabolcs Nagy
2021-01-19 19:41     ` H.J. Lu
2021-01-19 20:16       ` Adhemerval Zanella
2021-01-19 21:38         ` H.J. Lu
2021-01-20 11:29           ` Adhemerval Zanella
2021-01-20 12:38             ` Szabolcs Nagy
2021-01-20 12:49               ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ed8c627e3f1353e5539b458e596c4112121b3ba.1610986541.git.szabolcs.nagy@arm.com \
    --to=szabolcs.nagy@arm.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).