From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2250 invoked by alias); 29 Jun 2018 14:29:05 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 890 invoked by uid 89); 29 Jun 2018 14:29:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1825 X-HELO: mx1.redhat.com Subject: Re: [PATCH 2/9] Add __vfscanf_internal and __vfwscanf_internal with flags arguments. To: Zack Weinberg , libc-alpha@sourceware.org, "Gabriel F. T. Gomes" References: <20180307193205.4751-1-zackw@panix.com> <20180307193205.4751-3-zackw@panix.com> From: Florian Weimer Message-ID: <3f28351e-4dad-a6f2-de1b-7ee379389e61@redhat.com> Date: Fri, 29 Jun 2018 14:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180307193205.4751-3-zackw@panix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2018-06/txt/msg00983.txt.bz2 On 03/07/2018 08:31 PM, Zack Weinberg wrote: > diff --git a/stdio-common/iovfscanf.c b/stdio-common/iovfscanf.c > new file mode 100644 > index 0000000000..fb347d60cb > --- /dev/null > +++ b/stdio-common/iovfscanf.c > @@ -0,0 +1,34 @@ > +/* Copyright (C) 1991-2018 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > +. */ > + > +#include > +#include > + > +#if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_28) > + > +int > +attribute_compat_text_section > +__IO_vfscanf (FILE *fp, const char *format, va_list ap, int *errp) > +{ > + int rv = __vfscanf_internal (fp, format, ap, 0); > + if (__glibc_unlikely (errp != 0)) > + *errp = (rv == -1); > + return rv; > +} > +ldbl_compat_symbol (libc, __IO_vfscanf, _IO_vfscanf, GLIBC_2_0); > + > +#endif Now that _IO_vfscanf is a compat symbol, its wrapper should be removed from the libnldbl_nonshared.a library. That is, the file sysdeps/ieee754/ldbl-opt/nldbl-iovfscanf.c should be deleted by this patch (and the makefile adjusted). Thanks, Florian