From: Paul E Murphy <murphyp@linux.ibm.com>
To: Raphael Moreira Zinsly <rzinsly@linux.ibm.com>,
libc-alpha@sourceware.org
Subject: Re: [PATCH] powerpc: fix ifunc implementation list for POWER9 strlen and stpcpy
Date: Thu, 17 Sep 2020 11:03:29 -0500 [thread overview]
Message-ID: <3f651e98-689c-4bf4-dcf7-d444fd455cf3@linux.ibm.com> (raw)
In-Reply-To: <20200917141636.10543-1-rzinsly@linux.ibm.com>
Good catch. I was surprised no warnings were generated, but looking at
the macros, the type information about the ifuncs is stripped away.
LGTM, and pushed.
On 9/17/20 9:16 AM, Raphael Moreira Zinsly wrote:
> __strlen_power9 and __stpcpy_power9 were added to their ifunc lists
> using the wrong function names.
> ---
> sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c b/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c
> index ea10b00417..dd54e7d6bb 100644
> --- a/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c
> +++ b/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c
> @@ -99,7 +99,7 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
> /* Support sysdeps/powerpc/powerpc64/multiarch/stpcpy.c. */
> IFUNC_IMPL (i, name, stpcpy,
> #ifdef __LITTLE_ENDIAN__
> - IFUNC_IMPL_ADD (array, i, strncmp, hwcap2 & PPC_FEATURE2_ARCH_3_00,
> + IFUNC_IMPL_ADD (array, i, stpcpy, hwcap2 & PPC_FEATURE2_ARCH_3_00,
> __stpcpy_power9)
> #endif
> IFUNC_IMPL_ADD (array, i, stpcpy, hwcap2 & PPC_FEATURE2_ARCH_2_07,
> @@ -112,7 +112,7 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
> /* Support sysdeps/powerpc/powerpc64/multiarch/strlen.c. */
> IFUNC_IMPL (i, name, strlen,
> #ifdef __LITTLE_ENDIAN__
> - IFUNC_IMPL_ADD (array, i, strcpy, hwcap2 & PPC_FEATURE2_ARCH_3_00,
> + IFUNC_IMPL_ADD (array, i, strlen, hwcap2 & PPC_FEATURE2_ARCH_3_00,
> __strlen_power9)
> #endif
> IFUNC_IMPL_ADD (array, i, strlen, hwcap2 & PPC_FEATURE2_ARCH_2_07,
>
next prev parent reply other threads:[~2020-09-17 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 14:16 Raphael Moreira Zinsly
2020-09-17 16:03 ` Paul E Murphy [this message]
2020-09-18 15:24 ` Paul A. Clarke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f651e98-689c-4bf4-dcf7-d444fd455cf3@linux.ibm.com \
--to=murphyp@linux.ibm.com \
--cc=libc-alpha@sourceware.org \
--cc=rzinsly@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).