* [PATCH] powerpc: fix ifunc implementation list for POWER9 strlen and stpcpy
@ 2020-09-17 14:16 Raphael Moreira Zinsly
2020-09-17 16:03 ` Paul E Murphy
0 siblings, 1 reply; 3+ messages in thread
From: Raphael Moreira Zinsly @ 2020-09-17 14:16 UTC (permalink / raw)
To: libc-alpha; +Cc: murphyp, tuliom, Raphael Moreira Zinsly
__strlen_power9 and __stpcpy_power9 were added to their ifunc lists
using the wrong function names.
---
sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c b/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c
index ea10b00417..dd54e7d6bb 100644
--- a/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c
+++ b/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c
@@ -99,7 +99,7 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
/* Support sysdeps/powerpc/powerpc64/multiarch/stpcpy.c. */
IFUNC_IMPL (i, name, stpcpy,
#ifdef __LITTLE_ENDIAN__
- IFUNC_IMPL_ADD (array, i, strncmp, hwcap2 & PPC_FEATURE2_ARCH_3_00,
+ IFUNC_IMPL_ADD (array, i, stpcpy, hwcap2 & PPC_FEATURE2_ARCH_3_00,
__stpcpy_power9)
#endif
IFUNC_IMPL_ADD (array, i, stpcpy, hwcap2 & PPC_FEATURE2_ARCH_2_07,
@@ -112,7 +112,7 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
/* Support sysdeps/powerpc/powerpc64/multiarch/strlen.c. */
IFUNC_IMPL (i, name, strlen,
#ifdef __LITTLE_ENDIAN__
- IFUNC_IMPL_ADD (array, i, strcpy, hwcap2 & PPC_FEATURE2_ARCH_3_00,
+ IFUNC_IMPL_ADD (array, i, strlen, hwcap2 & PPC_FEATURE2_ARCH_3_00,
__strlen_power9)
#endif
IFUNC_IMPL_ADD (array, i, strlen, hwcap2 & PPC_FEATURE2_ARCH_2_07,
--
2.26.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: fix ifunc implementation list for POWER9 strlen and stpcpy
2020-09-17 14:16 [PATCH] powerpc: fix ifunc implementation list for POWER9 strlen and stpcpy Raphael Moreira Zinsly
@ 2020-09-17 16:03 ` Paul E Murphy
2020-09-18 15:24 ` Paul A. Clarke
0 siblings, 1 reply; 3+ messages in thread
From: Paul E Murphy @ 2020-09-17 16:03 UTC (permalink / raw)
To: Raphael Moreira Zinsly, libc-alpha
Good catch. I was surprised no warnings were generated, but looking at
the macros, the type information about the ifuncs is stripped away.
LGTM, and pushed.
On 9/17/20 9:16 AM, Raphael Moreira Zinsly wrote:
> __strlen_power9 and __stpcpy_power9 were added to their ifunc lists
> using the wrong function names.
> ---
> sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c b/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c
> index ea10b00417..dd54e7d6bb 100644
> --- a/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c
> +++ b/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c
> @@ -99,7 +99,7 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
> /* Support sysdeps/powerpc/powerpc64/multiarch/stpcpy.c. */
> IFUNC_IMPL (i, name, stpcpy,
> #ifdef __LITTLE_ENDIAN__
> - IFUNC_IMPL_ADD (array, i, strncmp, hwcap2 & PPC_FEATURE2_ARCH_3_00,
> + IFUNC_IMPL_ADD (array, i, stpcpy, hwcap2 & PPC_FEATURE2_ARCH_3_00,
> __stpcpy_power9)
> #endif
> IFUNC_IMPL_ADD (array, i, stpcpy, hwcap2 & PPC_FEATURE2_ARCH_2_07,
> @@ -112,7 +112,7 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
> /* Support sysdeps/powerpc/powerpc64/multiarch/strlen.c. */
> IFUNC_IMPL (i, name, strlen,
> #ifdef __LITTLE_ENDIAN__
> - IFUNC_IMPL_ADD (array, i, strcpy, hwcap2 & PPC_FEATURE2_ARCH_3_00,
> + IFUNC_IMPL_ADD (array, i, strlen, hwcap2 & PPC_FEATURE2_ARCH_3_00,
> __strlen_power9)
> #endif
> IFUNC_IMPL_ADD (array, i, strlen, hwcap2 & PPC_FEATURE2_ARCH_2_07,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: fix ifunc implementation list for POWER9 strlen and stpcpy
2020-09-17 16:03 ` Paul E Murphy
@ 2020-09-18 15:24 ` Paul A. Clarke
0 siblings, 0 replies; 3+ messages in thread
From: Paul A. Clarke @ 2020-09-18 15:24 UTC (permalink / raw)
To: Paul E Murphy; +Cc: Raphael Moreira Zinsly, libc-alpha
On Thu, Sep 17, 2020 at 11:03:29AM -0500, Paul E Murphy via Libc-alpha wrote:
> Good catch. I was surprised no warnings were generated, but looking at the
> macros, the type information about the ifuncs is stripped away.
Should we create a test for this type of error, since it went otherwise
undetected?
>
> LGTM, and pushed.
>
> On 9/17/20 9:16 AM, Raphael Moreira Zinsly wrote:
> > __strlen_power9 and __stpcpy_power9 were added to their ifunc lists
> > using the wrong function names.
> > ---
> > sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c b/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c
> > index ea10b00417..dd54e7d6bb 100644
> > --- a/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c
> > +++ b/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c
> > @@ -99,7 +99,7 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
> > /* Support sysdeps/powerpc/powerpc64/multiarch/stpcpy.c. */
> > IFUNC_IMPL (i, name, stpcpy,
> > #ifdef __LITTLE_ENDIAN__
> > - IFUNC_IMPL_ADD (array, i, strncmp, hwcap2 & PPC_FEATURE2_ARCH_3_00,
> > + IFUNC_IMPL_ADD (array, i, stpcpy, hwcap2 & PPC_FEATURE2_ARCH_3_00,
> > __stpcpy_power9)
> > #endif
> > IFUNC_IMPL_ADD (array, i, stpcpy, hwcap2 & PPC_FEATURE2_ARCH_2_07,
> > @@ -112,7 +112,7 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
> > /* Support sysdeps/powerpc/powerpc64/multiarch/strlen.c. */
> > IFUNC_IMPL (i, name, strlen,
> > #ifdef __LITTLE_ENDIAN__
> > - IFUNC_IMPL_ADD (array, i, strcpy, hwcap2 & PPC_FEATURE2_ARCH_3_00,
> > + IFUNC_IMPL_ADD (array, i, strlen, hwcap2 & PPC_FEATURE2_ARCH_3_00,
> > __strlen_power9)
> > #endif
> > IFUNC_IMPL_ADD (array, i, strlen, hwcap2 & PPC_FEATURE2_ARCH_2_07,
> >
PC
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-18 15:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-17 14:16 [PATCH] powerpc: fix ifunc implementation list for POWER9 strlen and stpcpy Raphael Moreira Zinsly
2020-09-17 16:03 ` Paul E Murphy
2020-09-18 15:24 ` Paul A. Clarke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).