public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>,
	DJ Delorie via Libc-alpha <libc-alpha@sourceware.org>
Cc: Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com>
Subject: Re: ppc64le: gcc 12 vs -mabi=ibmlongdouble
Date: Mon, 24 Jan 2022 14:37:15 -0300	[thread overview]
Message-ID: <3f70ef4a-43d5-fbad-5b8a-0efb1dcdc5c9@linaro.org> (raw)
In-Reply-To: <87bl012lfs.fsf@oldenburg.str.redhat.com>



On 24/01/2022 12:38, Florian Weimer via Libc-alpha wrote:
> * DJ Delorie via Libc-alpha:
> 
>> I've been working on updating glibc for Fedora Rawhide, and have
>> stumbled upon this issue (after working around the -Wuse-after-free
>> issues with a cflags hack)...  A few of the math tests explicitly add
>> -mlong-double-64 but configure adds -mabi=ibmlongdouble
>>
>> I would guess that we need a "CFLAGS -= -mabi=ibmlongdouble" in all
>> the places we add -mlong-double-64 but I don't see an easy way of
>> doing that, nor am I sure that's a valid solution.  Alternately, gcc
>> could be changed to accept the conflicting flags in a meaningful way,
>> if there is one.  Is there an -mabi= that undoes the
>> -mabi=ibmlongdouble that we can just add to the -mlong-double-64 flag
>> lines?
> 
>> cc1: error: '-mabi=ibmlongdouble' requires '-mlong-double-128'
> 
> I was able to reproduce with a GCC 12 build configured using
> --with-long-double-format=ieee.
> 
> I tried the attached patch to remove the unwanted -mabi=ibmlongdouble,
> but it does not work: it removes CFLAGS-*.c processing as a side effect.
> 
> Any suggestions how we can fix this properly?

I think we will need add a concept of CFLAGS to build glibc itself and CFLAGS 
to build tests regarding ABI.  The '-mabi=ibmlongdouble' will
be added only libraries.

On sysdeps/powerpc/powerpc64/le/Makefile, add type-ldouble-CFLAGS but filtering
out $(tests), $(tests-internal), $(xtests), $(test-srcs), $(tests-time64),
and  $(xtests-time64) (maybe add a new rule to add all tests) and then 
add the required on each tests (we might know the default from configure,
but I think it would be simple to always add the long double abi flags).

  parent reply	other threads:[~2022-01-24 17:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-22  6:34 DJ Delorie
2022-01-24 15:38 ` Florian Weimer
2022-01-24 16:44   ` Bill Schmidt
2022-01-24 18:32     ` Florian Weimer
2022-01-24 17:37   ` Adhemerval Zanella [this message]
2022-01-24 17:46   ` Paul E Murphy
2022-01-24 17:56     ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f70ef4a-43d5-fbad-5b8a-0efb1dcdc5c9@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=tuliom@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).