From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A07AD3942018 for ; Mon, 5 Dec 2022 15:57:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A07AD3942018 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670255822; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s8PiWbkWccSHtaoW35HTCPgGS8V7A1pWJXaVJpSdsG8=; b=BZHqludTohnln1FcgREawMHwZBhlCzBqGLEcZQ/4mzYv488XUSNFggR+mUph77ygnBtroD tJ8l1fvJNuCJa6e7nyhUV0qFDI0XBYusclWcXu/f83Fg8bKkTqxL1dCn1S79+FIt14D0/y HgltjVFvfehM8hItEll8OOqxuBOIiT0= Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-45-psTnR0gXPMWihuOqz5aOig-1; Mon, 05 Dec 2022 10:57:01 -0500 X-MC-Unique: psTnR0gXPMWihuOqz5aOig-1 Received: by mail-io1-f71.google.com with SMTP id k21-20020a5e8915000000b006de391b332fso9882236ioj.4 for ; Mon, 05 Dec 2022 07:57:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s8PiWbkWccSHtaoW35HTCPgGS8V7A1pWJXaVJpSdsG8=; b=vcLJJsMdBCg+fnYzOmd5vXPfhGY5pBvVDDxcSO1wvTmk9Oq0yhmcffrxPwlph8X0R0 haAoqtO88+69wJXbZYhLWiVTvcw69Y/jqqXXmzcdktGP2pqUQe8+dk6A40nPh+sybMa2 /yRbw9nnvwZFT0FTP8rlZx1cYUJ3elGffsSqtrLxUKYeCczQJnjTjY0lls2rKdrx6Fji PlQJwAXIsABHvBbecDj7HKWQFsQEWfLHwAkI41NxIxPlLKAOYuhiv/GVjIfkQMg+iFm6 j6fLR8I7qF8/QomrK8dXhF12L+6udQxpR1MlOAMbaiVTTNGIiWqD2am9ySteFZXTZjI4 /+cg== X-Gm-Message-State: ANoB5pn5JQR7ze36hdm6exv6p1gfSLqNONHH77X2gBst2utewmcmiLEo /oVmTaOFQn7bkoqHeEAIYZr8JK1X3d7HlxMwahQwEoQdjxDbWmxSkxabCttAa831FC8tKiFSEiQ M5hsInZeI4X7+7+dDCgXw X-Received: by 2002:a05:6638:11d0:b0:38a:fdf:fad4 with SMTP id g16-20020a05663811d000b0038a0fdffad4mr8804971jas.186.1670255820357; Mon, 05 Dec 2022 07:57:00 -0800 (PST) X-Google-Smtp-Source: AA0mqf6YEgCNSH5YZ9rqux4NZaTRzHNnUsG7dQmChPXUP4TTsPfEPV8IRFPar11oIhk9UWLIjUUHtQ== X-Received: by 2002:a05:6638:11d0:b0:38a:fdf:fad4 with SMTP id g16-20020a05663811d000b0038a0fdffad4mr8804969jas.186.1670255820166; Mon, 05 Dec 2022 07:57:00 -0800 (PST) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id a4-20020a056638058400b0038a13e116a1sm4592338jar.61.2022.12.05.07.56.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Dec 2022 07:56:59 -0800 (PST) Message-ID: <3f7184fd-02e3-42f7-46de-b9f7e5fbbace@redhat.com> Date: Mon, 5 Dec 2022 10:56:58 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 5/6] configure: Allow user override LD, AR, OBJCOPY, and GPROF To: Adhemerval Zanella , libc-alpha@sourceware.org, Vineet Gupta , =?UTF-8?Q?Ludovic_Court=c3=a8s?= References: <20221202190030.1671870-1-adhemerval.zanella@linaro.org> <20221202190030.1671870-6-adhemerval.zanella@linaro.org> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <20221202190030.1671870-6-adhemerval.zanella@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/2/22 14:00, Adhemerval Zanella via Libc-alpha wrote: > The only way to override LD, AR, OBJCOPY, and GPROF is through > --with-binutils (setting the environments variables on configure is > overridden by LIBC_PROG_BINUTILS). If this is true then doesn't build-many-glibcs.py need --with-binutils? We set LD, AR, OBJCOPY in bmg (not GPROF though). I'd think we'd either set them or let the defaults be used (remove their setting). > --- > aclocal.m4 | 16 ++++++++++++---- > configure | 16 ++++++++++++---- > 2 files changed, 24 insertions(+), 8 deletions(-) > > diff --git a/aclocal.m4 b/aclocal.m4 > index 7ab8ac023b..cbe3c4698a 100644 > --- a/aclocal.m4 > +++ b/aclocal.m4 > @@ -118,12 +118,20 @@ case "$CC" in > *fuse-ld=lld*) LDNAME=ld.lld;; > *) LDNAME=ld;; > esac > -LD=`$CC -print-prog-name=$LDNAME` > -AR=`$CC -print-prog-name=ar` > +if test -z "$LD"; then > + LD=`$CC -print-prog-name=$LDNAME` > +fi > +if test -z "$AR"; then > + AR=`$CC -print-prog-name=ar` > +fi > AC_SUBST(AR) > -OBJCOPY=`$CC -print-prog-name=objcopy` > +if test -z "$OBJCOPY"; then > + OBJCOPY=`$CC -print-prog-name=objcopy` > +fi > AC_SUBST(OBJCOPY) > -GPROF=`$CC -print-prog-name=gprof` > +if test -z "$GPROF"; then > + GPROF=`$CC -print-prog-name=gprof` > +fi > AC_SUBST(GPROF) > ]) OK. > > diff --git a/configure b/configure > index 62c2581cb0..8f91bb6e11 100755 > --- a/configure > +++ b/configure Regenerate. > @@ -4145,12 +4145,20 @@ case "$CC" in > *fuse-ld=lld*) LDNAME=ld.lld;; > *) LDNAME=ld;; > esac > -LD=`$CC -print-prog-name=$LDNAME` > -AR=`$CC -print-prog-name=ar` > +if test -z "$LD"; then > + LD=`$CC -print-prog-name=$LDNAME` > +fi > +if test -z "$AR"; then > + AR=`$CC -print-prog-name=ar` > +fi > > -OBJCOPY=`$CC -print-prog-name=objcopy` > +if test -z "$OBJCOPY"; then > + OBJCOPY=`$CC -print-prog-name=objcopy` > +fi > > -GPROF=`$CC -print-prog-name=gprof` > +if test -z "$GPROF"; then > + GPROF=`$CC -print-prog-name=gprof` > +fi > > > -- Cheers, Carlos.