From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B251D384AB47 for ; Mon, 13 May 2024 14:04:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B251D384AB47 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B251D384AB47 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715609071; cv=none; b=d4K5aK6htgI9oT1ezfRSJD2d5iAa6u2hf51cnzsg1Pl/yrcrIK9uOm0EJfV9T9XcSFMRHrPCD6xP/nXLmm4pqLRQx+5vEQl1WKk2RsIpFRJpb2Jb6cXJ8RVce4154axTwAaWehqHl+P8prxZwfpsfBMuQmB/e0TDLzKj8hjZh3g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715609071; c=relaxed/simple; bh=iczzg7KaUZZ5DnHsJuhyGw4d/DF8myh00GqLkwrCmNQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=OUAC7T+6bTFn75KGoG9PBKQC70CBkDF/NQbKbmrkb5SgptsECM/N/2h2e3GlLP5Da0KTWioqOVxY369RQO89SKjj1IRdHtv6NXVXgTg6KbOWGs3umKKSriOoKV12nXRGEpmJRULJ/YNtMJ0+RfjaH5viXm0RzsgRjUfhjS7ZlYE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715609069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XM1mALto6wSCPCsCs01n3t/BKyB7cOBHpmIxyKRBYLk=; b=W1NYgGbOu4Aswd8238Q1pnUIPSLJoLpJKQz+1EcDyIF80s/DAcFwHbMsrbi+SKYb7RmrlE HnfZUyXn+WzWaSyZSZ08+ENM1UXXW9yEWwskE6Rg0ov8SokTrp3xRqF+0TilNc+5xsk+PC +caT3dG+aVwIa7xvQ5zFWud8NKbp1Sg= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-517-AE-UL7tFNZ2IXmN5zmxGUg-1; Mon, 13 May 2024 10:04:26 -0400 X-MC-Unique: AE-UL7tFNZ2IXmN5zmxGUg-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6a0e2c337bfso51945606d6.1 for ; Mon, 13 May 2024 07:04:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715609066; x=1716213866; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XM1mALto6wSCPCsCs01n3t/BKyB7cOBHpmIxyKRBYLk=; b=VbOJeLR8AIFcihLTD3pcMPDCUN7ZQWGKEwbsS+xuL1kt1tS7HOp7FzD0k+dwje3JFa Loky3EB1Xu1nhWqHTjnKRQ03Wb5M3dke22SO9eBoJ1R2N/QPehpxpSWxVf03PLIcKsWF q4HULuRSxZZCmIbJySlhQ87HKDkwW7kJNmNaKlx+7RMcft0/4JOALylBbrHxsWSIOqqY m1IC+JFm/anxvg0eUJaZ33arx7Di2xrczzrxw7WVlhQYqVDvorLx5otTL3MvdvD3oRvT exDaRrgxcKxsqQFJsbBzGXVFn+N6Ut/uxy0vVLYwERAnNzuJO2PPzhb/sI5lNiRNEHcy vQpA== X-Forwarded-Encrypted: i=1; AJvYcCXkrYwWFGhBexszJ3P2ja2oG8F70wjzWo1gw+PXcbe4e0VuXSSuJjDP/fnfO5F/woXVoDT8O4fAXlI5e0pso+qWN3tQSoNfEytU X-Gm-Message-State: AOJu0Ywz+7S/JBezhG6FQNNQPoXyQdK9rr3P4udvdGaFkdLOXrikYnlb BjTy9w7b6Vz17l1daMcGxoxDkKHEya/qS8SdMh7ADoqESCe3MDOUMgNVc28KkwP50bJK4d25CG3 T+MlE+d6XOoWFsVAr+a1SKChdnNFwSl/Y47VaoD12oM3eVvvIUHi491JrYw== X-Received: by 2002:a05:6214:450f:b0:6a0:cd6b:4149 with SMTP id 6a1803df08f44-6a168140ee1mr115811286d6.1.1715609065845; Mon, 13 May 2024 07:04:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEX7tMhgGinu9/3axmFONHQwuiIkf805BEv/YRUZ8MWzyZaJzJUz7M3/LpWQaKiFa71hqy9HA== X-Received: by 2002:a05:6214:450f:b0:6a0:cd6b:4149 with SMTP id 6a1803df08f44-6a168140ee1mr115810506d6.1.1715609064900; Mon, 13 May 2024 07:04:24 -0700 (PDT) Received: from [192.168.0.241] ([198.48.244.52]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6a15f18543fsm43584896d6.34.2024.05.13.07.04.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 May 2024 07:04:24 -0700 (PDT) Message-ID: <3f8f8f3a-6c54-4b94-a666-001150ebbb32@redhat.com> Date: Mon, 13 May 2024 10:04:23 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Halving the number of recursive calls To: Viktor Reznov , libc-alpha@sourceware.org References: From: Carlos O'Donell Autocrypt: addr=carlos@redhat.com; keydata= xsFNBFef5BoBEACvJ15QMMZh4stKHbz0rs78XsOdxuug37dumTx6ngrDCwZ61k7nHQ+uxLuo QvLSc6YJGBEfiNFbs1hvhRFNR7xJbzRYmin7kJZZ/06fH2cgTkQhN0mRBP8KsKKT+7SvvBL7 85ZfAhArWf5m5Tl0CktZ8yoG8g9dM4SgdvdSdzZUaWBVHc6TjdAb9YEQ1/jpyfHsQp+PWLuQ ZI8nZUm+I3IBDLkbbuJVQklKzpT1b8yxVSsHCyIPFRqDDUjPL5G4WnUVy529OzfrciBvHdxG sYYDV8FX7fv6V/S3eL6qmZbObivIbLD2NbeDqw6vNpr+aehEwgwNbMVuVfH1PVHJV8Qkgxg4 PqPgQC7GbIhxxYroGbLJCQ41j25M+oqCO/XW/FUu/9x0vY5w0RsZFhlmSP5lBDcaiy3SUgp3 MSTePGuxpPlLVMePxKvabSS7EErLKlrAEmDgnUYYdPqGCefA+5N9Rn2JPfP7SoQEp2pHhEyM 6Xg9x7TJ+JNuDowQCgwussmeDt2ZUeMl3s1f6/XePfTd3l8c8Yn5Fc8reRa28dFANU6oXiZf 7/h3iQXPg81BsLMJK3aA/nyajRrNxL8dHIx7BjKX0/gxpOozlUHZHl73KhAvrBRaqLrr2tIP LkKrf3d7wdz4llg4NAGIU4ERdTTne1QAwS6x2tNa9GO9tXGPawARAQABzSpDYXJsb3MgTydE b25lbGwgKFdvcmspIDxjYXJsb3NAcmVkaGF0LmNvbT7CwZUEEwEIAD8CGwMGCwkIBwMCBhUI AgkKCwQWAgMBAh4BAheAFiEEcnNUKzmWLfeymZMUFnkrTqJTQPgFAmStkMYFCQ8AA6UACgkQ FnkrTqJTQPjRTxAAnKmRztRqcP4bgMeweR3rMxDEtwQhciDybB7RgBeuZHCbY6Hmqx2so4gH 2rG9EoBJM1RZKyqztVJ2WbGPzEb4ZAW/AjmttIoN1tSdACGBbd8kPNUzJd+QsCiWGNtyaJw6 /HTLj9JRdGN16b+DzUJxww3gYZYTTkhSNUVjcrw7hzXU0Zb3z9/evXv26SDbNCqSfhAm7tNE 8ceH9H8dTcalNUPJO7bgXRhXORj9OciJrMnpPs6P4U5f/IkcVSZS1t+6R0KPWeEUXGlegTFK F1cKsSoil8mYajqAheuqbjtPHPh55dHTbG35ngjNSZyiM54PdMW5SR6zog3RAlYnuPg09g21 n9Y/ihuEZZve57Gp5wHUwNE+RKRByLlRF3Zezz6jKfjLyHqJYK8d8+vuFO1vca5OfxCEf33Y 8pLhARmHXG6mzRdji1e7Ugob2OQbvM1XWkInA+NyGeqLlE7ZnzVME5kmYVa/+qjdoqEgAqKz EdcknAZ0uud8xuAqven5X17+bBY16RZHOysOcBiGGC2E1A8Xni8cO+vH6NTCjK+OAk7UXgWB +9MFvsi7WHDJAjVlpOwuRYDWjZ8o8HhkByMAhPEzjySR9G1bzHKNOVQNFpHPTP8a5LJR6nX/ QdjKAC0bOR1TxNeK6T0h+E0iPnwWIJ6ezimzwdRl0oCbj02giyPOwU0EV5/kGgEQAKvTJke+ QSjATmz11ALKle/SSEpUwL5QOpt3xomEATcYAamww0HADfGTKdUR+aWgOK3vqu6Sicr1zbuZ jHCs2GaIgRoqh1HKVgCmaJYjizvidHluqrox6qqc9PG0bWb0f5xGQw+X2z+bEinzv4qaep1G 1OuYgvG49OpHTgZMiJq9ncHCxkD2VEJKgMywGJ4Agdl+NWVn0T7w6J+/5QmBIE8hh4NzpYfr xzWCJ9iZ3skG4zBGB4YEacc3+oeEoybc10h6tqhQNrtIiSRJH+SUJvOiNH8oMXPLAjfFVy3d 4BOgyxJhE0UhmQIQHMJxCBw81fQD10d0dcru0rAIEldEpt2UXqOr0rOALDievMF/2BKQiOA7 PbMC3/dwuNHDlClQzdjil8O7UsIgf3IMFaIbQoUEvjlgf5cm9a94gWABcfI1xadAq9vcIB5v +9fM71xDgdELnZThTd8LByrG99ExVMcG2PZYXJllVDQDZqYA1PjD9e0yHq5whJi3BrZgwDaL 5vYZEb1EMyH+BQLO3Zw/Caj8W6mooGHgNveRQ1g9FYn3NUp7UvS22Zt/KW4pCpbgkQZefxup KO6QVNwwggV44cTQ37z5onGbNPD8+2k2mmC0OEtGBkj+VH39tRk+uLOcuXlGNSVk3xOyxni0 Nk9M0GvTvPKoah9gkvL/+AofN/31ABEBAAHCwXwEGAEIACYCGwwWIQRyc1QrOZYt97KZkxQW eStOolNA+AUCZK2RDAUJDwAD8gAKCRAWeStOolNA+B0MEACVxFO++NroEQxSQ0NCWod3aDmY mYn+/08wLTeMP+ajq19FEjU0Lh/GBJl6WlSHeJ5ZJlNSiXZuiSYGMYm73DBaoZlyjbD+H9NL LwLXgtfCZYlN6Iu8JRMfk9yevVBay7Be9DkPAk565ggo0UkIjpYftiLF4TUfqnI1yO6QKXgr J2DDwlP3iiCYnWFpHdBTB2/BRurpZoRquhRGzgcdGfRDtp16Pzm/u8BjfaU5/AFRjM0IDYQ6 PaQld0uZSZ0qOn0ts6usJws5gANq4U1oWJlqL/PHOFy9mbwUnKqq0oiWrmj+Mb+Ic6m9fqB3 5CHWUhxC1QozvkuY/sTsmXnG/mnbq2oFIVcgXDsnrDHf+0GyR+TrE4AQw1Pt2utsmU67LqNB Ru/2NbSFgwPv5wWjtNwDVGSZEXlV4qJGjh8S9aaGXhRTwJsnN6qkFS1m6vHKwqnRb5Qy4XDg 7kDrhFnTWe+XSwQt+HtGvIiXcR3EScJky76YlVsWDtvZMo3NePaC3qV5HAC8d2ZL3sFqxJRu sRyjE2l6s0EEK2MUgV/dwodftECrMdGktndVTYPqLnsua/PWWKYwYrNvD8slL6VFkXDZvLLv nat9vl9mBm15b76RHvKNlRcPbB9YYCbS5fhN2ObAsVbV1c5TdBCp8lp1Fa3YK0TA+WpNZVHK vjq6hMJAjA== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/12/24 10:40 PM, Viktor Reznov wrote: > From b4813bd1d7f48014e24f8a8749da49f7749c4f37 Mon Sep 17 00:00:00 2001 > From: Reznov > Date: Mon, 13 May 2024 05:27:05 +0300 > Subject: [PATCH] Halving the number of recursive calls Thank you for contributing to glibc! :-) Please note that this patch fails to pass pre-commit CI: https://patchwork.sourceware.org/project/glibc/patch/CAKs8_O+FRyB3kpzxQZPVrQGwVzRzwViK17kVpWzQAEzQtHi9VQ@mail.gmail.com/ - Patch fails to apply due to line wrapping. Please have a look at the contribution checklist here: https://sourceware.org/glibc/wiki/Contribution%20checklist In particular: - You can use `git send-email` to send the message to the list to avoid wrapping issues with mail clients. - You must choose one of the processes for copyright for your patch, either disclaim, assign, or developer certificate of origin. Lastly, How did you test the performance gains? Does this change show up visibly in a microbenchmark or workload? > --- > stdlib/qsort.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/stdlib/qsort.c b/stdlib/qsort.c > index be47aebbe0..30ba492869 100644 > --- a/stdlib/qsort.c > +++ b/stdlib/qsort.c > @@ -198,16 +198,15 @@ msort_with_tmp (const struct msort_param *p, > void *b, size_t n) > char *b1, *b2; > size_t n1, n2; > > - if (n <= 1) > - return; > - > n1 = n / 2; > n2 = n - n1; > b1 = b; > b2 = (char *) b + (n1 * p->s); > > - msort_with_tmp (p, b1, n1); > - msort_with_tmp (p, b2, n2); > + if (n1 > 1) > + msort_with_tmp (p, b1, n1); > + if (n2 > 1) > + msort_with_tmp (p, b2, n2); > > char *tmp = p->t; > const size_t s = p->s; -- Cheers, Carlos.