From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by sourceware.org (Postfix) with ESMTPS id F1FDD386FC1B for ; Tue, 8 Jun 2021 13:18:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F1FDD386FC1B Received: by mail-lf1-x12c.google.com with SMTP id a1so22308086lfr.12 for ; Tue, 08 Jun 2021 06:18:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tZorGvclpOPbhfWPZaOjzmooZyvoUCWVkBUywkX8hVE=; b=thU3zeTulTG4fxGrcF3RIB/WxxEAlomNYUK5gkkKql9haiKdkFjKuH+FidZPqqynoK 4x7bUfjHAMONH4OL9yjcK66L1Wg8M/96/dpstebRHfoxpHHFozdjGuGObyLEbwY3y3H+ pz/I1f7lejLfNiTZVFE2KAs1mpTR06ckqhHLSgOrG5Dm5rno/d4mFxg18si2ESerVaWA /UU4r42jBXLL8taY9N4mA59HgsBj3P6k6Q0fxzXLpNU7dVdsdDVqqzqSiSM4SfQ4EUJe O3XqaPcI//Ou5jK96sVtC2JqpPi9D/qGfnZrugRdmjP7H3vW6r9Qe3qhYDyKi6UeX31X tgdg== X-Gm-Message-State: AOAM533CQNkhVQoKZWTQrH4Nutia8LxHiV8JAyouYaJa0LDyeoANHHQi kF33nLghs+W3JZk2RAkJExM= X-Google-Smtp-Source: ABdhPJwrZLqSS8selXX297l/UST/YtonGUnayP2LjZk04lHR17IUaOnVAsD5CaOitjDBhBs2FLhF9Q== X-Received: by 2002:ac2:47f7:: with SMTP id b23mr15844488lfp.522.1623158324713; Tue, 08 Jun 2021 06:18:44 -0700 (PDT) Received: from [192.168.1.2] (broadband-5-228-51-184.ip.moscow.rt.ru. [5.228.51.184]) by smtp.gmail.com with ESMTPSA id t12sm1160270ljk.116.2021.06.08.06.18.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Jun 2021 06:18:43 -0700 (PDT) Subject: Re: [PATCH v4 00/15] Add futex2 syscalls To: Greg KH Cc: Nicholas Piggin , =?UTF-8?Q?Andr=c3=a9_Almeida?= , acme@kernel.org, Sebastian Andrzej Siewior , corbet@lwn.net, Davidlohr Bueso , Darren Hart , fweimer@redhat.com, joel@joelfernandes.org, kernel@collabora.com, krisman@collabora.com, libc-alpha@sourceware.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, malteskarupke@fastmail.fm, Ingo Molnar , Peter Zijlstra , pgriffais@valvesoftware.com, Peter Oskolkov , Steven Rostedt , shuah@kernel.org, Thomas Gleixner , z.figura12@gmail.com References: <1622799088.hsuspipe84.astroid@bobo.none> <1622853816.mokf23xgnt.astroid@bobo.none> <6d8e3bb4-0cef-b991-9a16-1f03d10f131d@gmail.com> <1622980258.cfsuodze38.astroid@bobo.none> <1623114630.pc8fq7r5y9.astroid@bobo.none> <8fa8b7fd-58ae-9467-138d-4ff4f32f68f7@gmail.com> From: Andrey Semashev Message-ID: <3fca0afa-d9db-a176-aad1-ff7db21ba4a2@gmail.com> Date: Tue, 8 Jun 2021 16:18:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2021 13:18:55 -0000 On 6/8/21 3:35 PM, Greg KH wrote: > On Tue, Jun 08, 2021 at 03:06:48PM +0300, Andrey Semashev wrote: >> On 6/8/21 2:13 PM, Greg KH wrote: > >>> So what's keeping the futex2 code from doing all that futex1 does so >>> that the futex1 code can be deleted internally? >> >> I think, André will answer this, but my guess is, as stated above, this is a >> lot of work and time while the intermediate version is already useful. > > useful to who? I still do not understand what users will be needing > this. All I can tell is a single userspace program wants to use it, and > that is a fork from the real project it was based on and that the > maintainers have no plan to merge it back. > > So who does need/want this? I mentioned C++ std::atomic and Boost.Atomic before. Those need variable sized futexes. The project you mention is probably Wine and its derivatives. Those need variable sized futexes and "wait for multiple" operation. I'm not sure about the "no plan to merge it back" part, I probably missed it in an earlier discussion. There are multiple different patches and versions out there, and I don't know which one it refers to. But WaitOnAddress and WaitForMultipleObjects APIs are very important and I would assume Wine wants to emulate those with best efficiency. I have a media processing engine application that needs 64-bit futexes would benefit from a "wait for multiple" function. Its source code is not open currently, so I'm not sure if you can count it as a valid user. There is a generic std::lock algorithm in C++ and an equivalent in Boost.Thread that is supposed to lock multiple lockables (a mutex-like object). Those could benefit from the "wait for multiple" function in some cases, e.g. when the objects are actually futex-based mutexes, and the function can access the internal futex. I'm not saying this will definitely be implemented, it just looks like a possible optimization to me. I think someone mentioned databases earlier in the discussion, but I don't know the details. I hope someone will be able to expand.