From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by sourceware.org (Postfix) with ESMTPS id AF84B38923E7 for ; Thu, 8 Dec 2022 18:24:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AF84B38923E7 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ot1-x32d.google.com with SMTP id l8-20020a056830054800b006705fd35eceso1350801otb.12 for ; Thu, 08 Dec 2022 10:24:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=gL8tXk8t8HOnMNNtHMDwQVpxpt+cEaJEQHUihan7lA0=; b=TAclCvrjZ2cec3Ww6BrEBWfiwYLLroSOGx0+9XG84P53HVR83CQi1vun93kK6kdUw0 1RhHR6WxV7GLb4m0hJNFA/rVbBAU84LyLbHvQXKiADu43PRgTo7IbaPJt8Nta7eOUU0C +DO/ExOHKaosCNsDV6IVoYlwmZPVPMFsNZtx6FCkd0OYRHj20gh7V+FGtwyB70UtCBXy K7EUgz16LM3GRzAYf9bNpL4a1z3jaaCfmxeTkrqfHoy8NMXFBB1loqxHWgfI20Dkc1uT jX5EZlHl/AfLjmNfNEL7pcUcxa7ZbkCeBWvrX3HU0NDFtC2fCivXHLFrH5ZQOKMZzpBh fB7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gL8tXk8t8HOnMNNtHMDwQVpxpt+cEaJEQHUihan7lA0=; b=u0cDAgB/gC62Kys7TPp3/ZItsN6HlSmy1tOd/88mDbcQtQs9vsuepVa4HnWyyMa63c I89kUM19onjSRFS1kZlcjyA+aaz/76bfAtvLiwRbo8s/dICH9AumVtfgdlpj9029ft5t jVdgT0qHXVPugx9/pyANqDGgV+6fr6Z9m9VBe/8I1U+L5rgyvggaZS08tHgWmDChFiT+ G8EpoRZwqTYPx8N+c5sepiJ/pZhUfGdHdIcst3Y0YxyIEDftyjmn9LY5pC9MRXX6b3XD zh3SvUbkeLwqxMjw0pxoTW7LZScTjI2azS0qKIn9ZR0RLIsoYYHCdp2dfRFVbw0gzARi ppXw== X-Gm-Message-State: ANoB5pkT5hlPRUf74z2oja6ycvS56VOq2gNKwQhJFRwtkVTw23hHFhfV za5G//3DFnzVVBa03dvyRjgxdw== X-Google-Smtp-Source: AA0mqf4cplVhSILmX20mNGt1JI7amd6Ea/FiiF3xlHPau7oxs2Vg5L5x/gSa0ibvI4/T59hRVJseDQ== X-Received: by 2002:a05:6830:1d94:b0:655:cda4:b46a with SMTP id y20-20020a0568301d9400b00655cda4b46amr45625112oti.262.1670523853999; Thu, 08 Dec 2022 10:24:13 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c2:6793:d83e:e871:6162:c8c0? ([2804:1b3:a7c2:6793:d83e:e871:6162:c8c0]) by smtp.gmail.com with ESMTPSA id k10-20020a05680808ca00b003547a3401e6sm1625534oij.43.2022.12.08.10.24.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Dec 2022 10:24:13 -0800 (PST) Message-ID: <3fde724b-e864-6baa-0279-781aad416e86@linaro.org> Date: Thu, 8 Dec 2022 15:24:12 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v2] : Make strptime available by default Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org References: <87cz97rv5u.fsf@oldenburg.str.redhat.com> <2af38d17-f641-d36a-b090-a3e00f8cd14e@linaro.org> <87mt7xhigo.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <87mt7xhigo.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 08/12/22 15:13, Florian Weimer wrote: > * Adhemerval Zanella Netto: > >> On 28/11/22 11:49, Florian Weimer via Libc-alpha wrote: >>> This matches what FreeBSD does. >>> >> >> >> LGTM, thanks. >> >> Reviewed-by: Adhemerval Zanella >> >>> --- >>> v2: Remove unneccesary parentheses. >>> time/time.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/time/time.h b/time/time.h >>> index d18089116e..0919e578d4 100644 >>> --- a/time/time.h >>> +++ b/time/time.h >>> @@ -101,7 +101,7 @@ extern size_t strftime (char *__restrict __s, size_t __maxsize, >>> const char *__restrict __format, >>> const struct tm *__restrict __tp) __THROW; >>> >>> -#ifdef __USE_XOPEN >>> +#if defined __USE_XOPEN || defined __USE_MISC >>> /* Parse S according to FORMAT and store binary time information in TP. >>> The return value is a pointer to the first unparsed character in S. */ >>> extern char *strptime (const char *__restrict __s, >>> >>> base-commit: f704192911c6c7b65a54beab3ab369fca7609a5d >>> > > I think this change has been vetoed by Andreas. I assume he wants us to > define __USE_XOPEN by default to check all visiblities at once. > > Florian > Alright then, defining __USE_XOPEN works as well.