From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Matt Turner <mattst88@gmail.com>, Florian Weimer <fweimer@redhat.com>
Cc: Matt Turner via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCHv2] alpha: Remove anonymous union in struct stat [BZ #27042]
Date: Thu, 17 Dec 2020 16:10:03 -0300 [thread overview]
Message-ID: <408e386d-188f-f0ee-cbfb-01a8d70533fb@linaro.org> (raw)
In-Reply-To: <CAEdQ38FW3o5XTsvi+=Xwag3ZDE7Aq4fP2agOKXOxxV2Ee2kP1A@mail.gmail.com>
On 17/12/2020 15:18, Matt Turner wrote:
> On Tue, Dec 15, 2020 at 11:56 AM Florian Weimer <fweimer@redhat.com> wrote:
>>
>> * Matt Turner via Libc-alpha:
>>
>>> On Thu, Dec 10, 2020 at 4:18 PM Adhemerval Zanella via Libc-alpha
>>> <libc-alpha@sourceware.org> wrote:
>>>> On 09/12/2020 22:19, Matt Turner via Libc-alpha wrote:
>>>>> This is clever, but it confuses downstream detection in at least zstd
>>>>> and GNOME's glib. zstd has preprocessor tests for the 'st_mtime' macro,
>>>>> which is not provided by the path using the anonymous union; glib checks
>>>>> for the presence of 'st_mtimensec' in struct stat but then tries to
>>>>> access that field in struct statx (which might be a bug on its own).
>>>>> ---
>>>>> The macros affect the definitions in kernel_stat.h, so rename them. Not
>>>>> thrilled.
>>>>
>>>> LGTM, thanks.
>>>>
>>>> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>>>
>>> Thank you. Should we wait for any other input?
>>
>> I think Adhemerval's review is sufficient. Thanks.
>
> Thank you both. Could I bother one of you to push the patch?
>
I will handle it.
prev parent reply other threads:[~2020-12-17 19:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 16:20 [PATCH] " Matt Turner
2020-12-09 17:11 ` Florian Weimer
2020-12-10 1:25 ` Matt Turner
2020-12-10 1:19 ` [PATCHv2] " Matt Turner
2020-12-10 21:18 ` Adhemerval Zanella
2020-12-15 16:43 ` Matt Turner
2020-12-15 16:48 ` Adhemerval Zanella
2020-12-15 16:56 ` Florian Weimer
2020-12-17 18:18 ` Matt Turner
2020-12-17 19:10 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=408e386d-188f-f0ee-cbfb-01a8d70533fb@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=mattst88@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).