From: Carlos O'Donell <carlos@redhat.com>
To: Aurelien Jarno <aurelien@aurel32.net>, libc-alpha@sourceware.org
Subject: Re: [PATCH v2 1/2] arm: remove string/tst-memmove-overflow XFAIL
Date: Wed, 15 Jul 2020 16:51:52 -0400 [thread overview]
Message-ID: <40c77f27-0bae-bb2e-126d-46d4fb2ac8ac@redhat.com> (raw)
In-Reply-To: <20200713212347.385792-1-aurelien@aurel32.net>
On 7/13/20 5:23 PM, Aurelien Jarno wrote:
> The arm string/tst-memmove-overflow XFAIL has been added in commit
> eca1b233322 ("arm: XFAIL string/tst-memmove-overflow due to bug 25620")
> as a way to reproduce the reported bug.
>
> Now that this bug has been fixed in commits 79a4fa341b8 ("arm:
> CVE-2020-6096: fix memcpy and memmove for negative length [BZ #25620]")
> and beea3610507 ("arm: CVE-2020-6096: Fix multiarch memcpy for negative
> length [BZ #25620]"), let's remove the XFAIL.
OK for 2.32.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> ---
> sysdeps/arm/Makefile | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/sysdeps/arm/Makefile b/sysdeps/arm/Makefile
> index a0cb7f3c32e..ad2042b93a1 100644
> --- a/sysdeps/arm/Makefile
> +++ b/sysdeps/arm/Makefile
> @@ -68,8 +68,3 @@ ifeq ($(subdir),nptl)
> libpthread-sysdep_routines += pt-arm-unwind-resume
> libpthread-shared-only-routines += pt-arm-unwind-resume
> endif
> -
> -ifeq ($(subdir),string)
> -# This test fails on arm due to bug 25620 and related issues.
> -test-xfail-tst-memmove-overflow = yes
> -endif
>
--
Cheers,
Carlos.
prev parent reply other threads:[~2020-07-15 20:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 21:23 Aurelien Jarno
2020-07-13 21:23 ` [PATCH v2 2/2] Add NEWS entry for CVE-2020-6096 (bug 25620) Aurelien Jarno
2020-07-15 20:52 ` Carlos O'Donell
2020-07-15 20:51 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40c77f27-0bae-bb2e-126d-46d4fb2ac8ac@redhat.com \
--to=carlos@redhat.com \
--cc=aurelien@aurel32.net \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).