From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by sourceware.org (Postfix) with ESMTPS id 69E643857C75 for ; Fri, 10 Dec 2021 19:28:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 69E643857C75 Received: by mail-qt1-x831.google.com with SMTP id 8so9390568qtx.5 for ; Fri, 10 Dec 2021 11:28:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=5jpEwhkc9WYBzssyYGyWogavqLy5NC2ruPljpI0697o=; b=54cNUD4ZAIEKm/6ayXn3BJkZCMq62vPgcY+qOqTSrYW6N8NKCsvY6hLFH0FIlKKSZB DU0cR4aHN+a7WjfI6CkJ2bKBusi18KYtafbMeE4ry0h973Zsg/7r6MzayxYdd80nf8Oh GdiEEl2XRr1qJAZGOKv4RBbZ5qf96AJE+Q1LZhRhmPReQp4ByVYkipI7+pubwfWjSOWJ 3BdpAJ5JoFirtZsnbTLAUKo/nTypNIw2Q6UM6DmrxPKcCy+XuYmMZvMaMdCgKYrfBPJ1 +yvWRYOluK2j9kBILA7DXKeUJzR9QW6csMcvZEmgvI6TmIji1ZlC0e92wd3q/b8kHURd mODg== X-Gm-Message-State: AOAM531t22oLXQpqK7Te5oXxe07S6LM7n2oHMq95xYfRTPN66zO8ILXf eqRYuU9laYj19rVkF+OCXzMfcg== X-Google-Smtp-Source: ABdhPJyJ4ZwS5MxcOp+Fz83JgZ4SmrxYmSahNUFwd42edf9o8ReIddbJglw8/5rg8hxj8y9tAJ9WTA== X-Received: by 2002:ac8:590d:: with SMTP id 13mr28219764qty.295.1639164532926; Fri, 10 Dec 2021 11:28:52 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:a776:ce11:d591:8bd5:613f? ([2804:431:c7ca:a776:ce11:d591:8bd5:613f]) by smtp.gmail.com with ESMTPSA id j14sm1801493qkp.28.2021.12.10.11.28.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Dec 2021 11:28:52 -0800 (PST) Message-ID: <420f5562-87b0-a618-1438-124316746aa2@linaro.org> Date: Fri, 10 Dec 2021 16:28:50 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH v2] linux: Use 'long int' for timespec tv_nsec on x32 (BZ #16437) Content-Language: en-US To: Florian Weimer , "H.J. Lu via Libc-alpha" References: <20211210110233.1401640-1-adhemerval.zanella@linaro.org> <87mtl879ch.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <87mtl879ch.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Dec 2021 19:28:55 -0000 On 10/12/2021 12:44, Florian Weimer wrote: > * H. J. Lu via Libc-alpha: > >> On Fri, Dec 10, 2021 at 3:03 AM Adhemerval Zanella via Libc-alpha >> wrote: >>> >>> Although the kernel ABI uses 64-bit (so it can re-use the syscall >>> logic from x86_64), POSIX states the type to be 'long int'. It >>> requires to explicit signal extend the value on syscalls that >>> take the value to avoid requiring bumping the minimum kernel version >>> (ea2ce8f3514e ("time: Fix get_timespec64() for y2038 safe compat >>> interfaces") got merged into v4.18, futex and recvmsg followed in v5.1, >>> but v5.6 is considered 'complete'). >>> >>> The fix uses 'long long int' array to represent 'struct timespec', >>> since it allows a simpler code than define a kernel specific timespec. >>> >>> There is no need to compat symbol, the now high-bits are not used >>> to represent the nanoseconds and for some syscalls it only issues >>> an error (which hardly indicates the need of compat symbol). >>> >>> Checked on x86_64-linux-gnu-x32 with kernel 4.4.0 and 5.13. >> >> Isn't it an ABI change for x32? > > I agree. I said so repeatedly. Right, I will just drop this patch and set the patch as WONTFIX.