From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107826 invoked by alias); 15 Nov 2016 14:52:55 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 107758 invoked by uid 89); 15 Nov 2016 14:52:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Subject: Re: [PATCH] s390x: Add hidden definition for __sigsetjmp To: Stefan Liebler , libc-alpha@sourceware.org References: <20161114145753.3DF6D439942E0@oldenburg.str.redhat.com> From: Florian Weimer Message-ID: <42238612-9c67-2a26-ad23-2cc35908e7c5@redhat.com> Date: Tue, 15 Nov 2016 14:52:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00495.txt.bz2 On 11/15/2016 02:18 PM, Stefan Liebler wrote: >> -#endif /* !IS_IN (rtld) */ >> +#if !IS_IN (rtld) && defined SHARED && SHLIB_COMPAT (libc, >> GLIBC_2_19, GLIBC_2_20) > This line is too long and there are two spaces between && and SHLIB_COMPAT. > The same applies to sysdeps/s390/s390-64/setjmp.S. Thanks. Fixed & re-tested & pushed. Florian