From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72804 invoked by alias); 9 Jan 2019 10:21:50 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 72783 invoked by uid 89); 9 Jan 2019 10:21:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=speaker, improves, him, Hx-spam-relays-external:ESMTPA X-HELO: catfish.maple.relay.mailchannels.net X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Lyrical-Average: 39a96cd853666c6c_1547029304736_1560509393 X-MC-Loop-Signature: 1547029304736:4033711855 X-MC-Ingress-Time: 1547029304736 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=eboykd oLoFamwkUztnEokLd1GRg=; b=HjpZxVjQKigEyykQOyKznhHToBX4tEFYiHrqZ4 9aaRCUzq7xOo0lZBl4AYNrwlIdDRciV8Fq7UCDEc89wlUbvWPKer4kzjTVcHa+u9 YFqv89k5NQizRKxNxpfDu+Uf1e2WgfWvqFYYedaZTtmyJtUSWlnFrnxFvZzbSvIK qRoDQ= Subject: Re: [PATCH v5 1/5] strftime: Add missing uses of L_ macro, etc. [BZ #23758] To: Rafal Luzynski , TAMUKI Shoichi , libc-alpha@sourceware.org References: <201901060628.AA04156@tamuki.linet.gr.jp> <201901060633.AA04157@tamuki.linet.gr.jp> <553127895.95059.1547028145705@poczta.nazwa.pl> X-DH-BACKEND: pdx1-sub0-mail-a12 From: Siddhesh Poyarekar Message-ID: <432d9335-239d-b2c1-4324-c374dd76eee4@gotplt.org> Date: Wed, 09 Jan 2019 10:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <553127895.95059.1547028145705@poczta.nazwa.pl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtledrfedugdduhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefuvfhfhffkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpefuihguughhvghshhcurfhohigrrhgvkhgrrhcuoehsihguughhvghshhesghhothhplhhtrdhorhhgqeenucfkphepuddtfedrkedrudegkedruddvnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopegludelvddrudeikedruddrudeingdpihhnvghtpedutdefrdekrddugeekrdduvddprhgvthhurhhnqdhprghthhepufhiugguhhgvshhhucfrohihrghrvghkrghruceoshhiugguhhgvshhhsehgohhtphhlthdrohhrgheqpdhmrghilhhfrhhomhepshhiugguhhgvshhhsehgohhtphhlthdrohhrghdpnhhrtghpthhtohepughighhithgrlhhfrhgvrghksehlihhnghhonhgsohhrohhughhhrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-SW-Source: 2019-01/txt/msg00195.txt.bz2 On 09/01/19 3:32 PM, Rafal Luzynski wrote: > Hello Tamuki Shoichi, > > Thank you for the next version of your patches. > > 1. Please remove any reference to [BZ #23758] from this patch > because it is not related with the bug. The changes are minor > and not visible for the users therefore they don't need any > Bugzilla report, documentation, etc. > > 2. Regarding the subject of this email, which is also the first > line of the commit message, I would write something like this: > > "strftime: Consequently use the "L_" macro with character literals." > > As always, I am not a native speaker so other people may provide > better hints. > > 6.01.2019 07:33 TAMUKI Shoichi wrote: >> >> At first, make an unrelated changes for the consistency. > > If it is the part of the commit message then something like: > > "Make unrelated changes for the consistency." > > (The core problem is that "an" is incorrect for plural numbers.) > >> >> ChangeLog: >> >> [BZ #23758] >> * time/strftime_l.c (__strftime_internal): Add missing uses of L_ >> macro, also add a missing space after the cast of _NL_CURRENT. > > Good but again, Bugzilla mention should be removed and "missing > uses" seems incorrect to me, "Add "L_" macros" or "Use "L_" macros" > is sufficient and seems correct to me. > > I cut the patch body here because it is correct and trivial, also > I think it does not introduce any changes in the binary code but > it's good because it improves the readability of the source code. > Therefore I think it is OK to push it now with the changes above. > But due to the freeze period I'd like to hear "OK" from Siddhesh > therefore I'm adding CC: to him. OK. Siddhesh