public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Carlos O'Donell <carlos@redhat.com>
To: Paul Eggert <eggert@cs.ucla.edu>, DJ Delorie <dj@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [v2] posix/glob.c: update from gnulib
Date: Mon, 4 Apr 2022 17:25:38 -0400	[thread overview]
Message-ID: <4332d713-b94c-de9f-ea57-87de71e14314@redhat.com> (raw)
In-Reply-To: <9615c653-4e61-d3f8-e90b-0576387057f3@cs.ucla.edu>

On 3/31/22 21:55, Paul Eggert wrote:
> Thanks, this looks good to me.
> 

Fails CI/CD on i686 :>

https://patchwork.sourceware.org/project/glibc/patch/xnmth5vqnv.fsf@greed.delorie.com/

In file included from ../sysdeps/unix/sysv/linux/glob64-time64.c:43:
../posix/glob.c: In function 'glob_lstat':
../posix/glob.c:217:49: error: passing argument 3 of '__fstatat64' from incompatible pointer type [-Werror=incompatible-pointer-types]
  217 |           : GLOB_FSTATAT64 (AT_FDCWD, fullname, &ust.st64,
      |                                                 ^~~~~~~~~
      |                                                 |
      |                                                 struct __stat64_t64 *

-- 
Cheers,
Carlos.


  reply	other threads:[~2022-04-04 21:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-30 21:55 DJ Delorie
2022-03-30 23:40 ` Paul Eggert
2022-03-30 23:45   ` Paul Eggert
2022-03-30 23:54   ` DJ Delorie
2022-03-31 10:56 ` Adhemerval Zanella
2022-03-31 17:38   ` DJ Delorie
2022-03-31 17:44     ` Adhemerval Zanella
2022-03-31 19:29       ` DJ Delorie
2022-03-31 19:38         ` Adhemerval Zanella
2022-03-31 20:00       ` [v2] " DJ Delorie
2022-04-01  1:55         ` Paul Eggert
2022-04-04 21:25           ` Carlos O'Donell [this message]
2022-04-14 23:40             ` [v3] " DJ Delorie
2022-04-27 21:16               ` Carlos O'Donell
2022-04-27 21:21                 ` DJ Delorie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4332d713-b94c-de9f-ea57-87de71e14314@redhat.com \
    --to=carlos@redhat.com \
    --cc=dj@redhat.com \
    --cc=eggert@cs.ucla.edu \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).