From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 8D3213858D37 for ; Mon, 4 Apr 2022 21:25:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8D3213858D37 Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-339-j3p4GGqjNrWHelInc_98aw-1; Mon, 04 Apr 2022 17:25:41 -0400 X-MC-Unique: j3p4GGqjNrWHelInc_98aw-1 Received: by mail-qv1-f72.google.com with SMTP id j15-20020a05621419cf00b00443ce184f48so5110366qvc.20 for ; Mon, 04 Apr 2022 14:25:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=m/0E97VyICK8PMFpjC+9X60PTy4qJwWWIwhf4W+XVSc=; b=Bwlxb3Vb6oSnReDzahRarQpK8HdFmZXhWbvfwrFPaWcTc+RroMfO9hBMGUYamIn19w eVen9AX3jUKoWszo/71bSFChaXinypeYSHA29LCK2Jw3fssCTUVnnbcZzCxvlPPiDSgg mogR6ukXopEFCjiiTneWBwq6TMCOqUEJMMDqClkzIU9QZxP9PXZtBBprotXcokOk1l8q jnMmFhe4TMgZhhCTswMYDq3ic+IrkC30dYhu9TAr/SIwj2q16nM1khtvvEhhN0bQ8BLi iXg8XqVnEPje09/LiA+US6gDKTthqJhD9kt7gZkjFgFnHRXZpUM2KrWENWduTb3PnRMV AESw== X-Gm-Message-State: AOAM531EQQNfAEeh7qYtha2Ke+yFDHM9RkttldGV4AYJshCqbP18eNgR J+nospX6PoN9qf6seMzjc7vqLWdf9NBgH8H76Tw5p5JfT6SLTA88J63FKeFDRYh5zTUg1n8jvN3 wCSU1ubZvOsD2rlGQz+xM X-Received: by 2002:ae9:ed8a:0:b0:67d:6a0d:2a82 with SMTP id c132-20020ae9ed8a000000b0067d6a0d2a82mr163784qkg.561.1649107540638; Mon, 04 Apr 2022 14:25:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwQxhh0AgDUVCjEQlpeBhkYfOpXksqz+fjnDpQ0sMCGD+muB/NF6h7q/ZvY6jrMXunM+2Ff3Q== X-Received: by 2002:ae9:ed8a:0:b0:67d:6a0d:2a82 with SMTP id c132-20020ae9ed8a000000b0067d6a0d2a82mr163772qkg.561.1649107540432; Mon, 04 Apr 2022 14:25:40 -0700 (PDT) Received: from [192.168.0.241] (135-23-175-80.cpe.pppoe.ca. [135.23.175.80]) by smtp.gmail.com with ESMTPSA id r7-20020ac85c87000000b002e234014a1fsm9626385qta.81.2022.04.04.14.25.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Apr 2022 14:25:39 -0700 (PDT) Message-ID: <4332d713-b94c-de9f-ea57-87de71e14314@redhat.com> Date: Mon, 4 Apr 2022 17:25:38 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [v2] posix/glob.c: update from gnulib To: Paul Eggert , DJ Delorie Cc: libc-alpha@sourceware.org References: <9615c653-4e61-d3f8-e90b-0576387057f3@cs.ucla.edu> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <9615c653-4e61-d3f8-e90b-0576387057f3@cs.ucla.edu> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Apr 2022 21:25:44 -0000 On 3/31/22 21:55, Paul Eggert wrote: > Thanks, this looks good to me. > Fails CI/CD on i686 :> https://patchwork.sourceware.org/project/glibc/patch/xnmth5vqnv.fsf@greed.delorie.com/ In file included from ../sysdeps/unix/sysv/linux/glob64-time64.c:43: ../posix/glob.c: In function 'glob_lstat': ../posix/glob.c:217:49: error: passing argument 3 of '__fstatat64' from incompatible pointer type [-Werror=incompatible-pointer-types] 217 | : GLOB_FSTATAT64 (AT_FDCWD, fullname, &ust.st64, | ^~~~~~~~~ | | | struct __stat64_t64 * -- Cheers, Carlos.