From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) by sourceware.org (Postfix) with ESMTPS id CD3CE3850400 for ; Wed, 2 Jun 2021 13:11:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CD3CE3850400 Received: by mail-qk1-x72b.google.com with SMTP id u30so2217751qke.7 for ; Wed, 02 Jun 2021 06:11:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BgNMWGjv4E9EUkWGYwbHRwTd8fAP9f2maJDbfbgGagM=; b=CSzVsQMqVm8vcVelqMW8pp9IR3plujpHdgsqK0ueKJ70Kd9HLK0Tch8zpgsLv/vjzL rR8vAl0MtohqoO782aU8G44Z37+drRvax4IJCE1DHvsWVVlz9o3JUSiQLbRs01wThe0M ceQER5cDCkd9tnqvdh6Ab0Bqr30ln9ryJbgmW4yeSncmh8lYUbnP1+qU0jPl9/LeUqYI ocwY5MW7ObxexMjsqAKmg1c96M5m7jBaRvxJRCkBA8S/u9grBk7LrV3PpkDeJGqarKab wkiKHwfjgGMRo3YUqIufuT5+M4x56RE7P4sA9X3YZsNqlSqfC19bMoKawm6xxPX+Nv5+ VbPA== X-Gm-Message-State: AOAM533r67vbJItMWd4AfSg9s3db0V6o1KrqpEJHmhNZaOQ36RXYeFlj xpkyRu0Hl4IN81IctIszb7G8b4RcKt5qEw== X-Google-Smtp-Source: ABdhPJzJmV38OHoGx/LOq3qcUZgNe7oDxIp41DY3dvEEIaT7qggAWzTT/x3aU8BItHGvC6OCkq+8IA== X-Received: by 2002:a05:620a:906:: with SMTP id v6mr27991855qkv.5.1622639484127; Wed, 02 Jun 2021 06:11:24 -0700 (PDT) Received: from [192.168.1.4] ([177.194.59.218]) by smtp.gmail.com with ESMTPSA id i10sm13614984qko.68.2021.06.02.06.11.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jun 2021 06:11:23 -0700 (PDT) Subject: Re: [PATCH v2 6/9] nptl: Move cancel type out of cancelhandling To: Florian Weimer , Adhemerval Zanella via Libc-alpha References: <20210527172823.3461314-1-adhemerval.zanella@linaro.org> <20210527172823.3461314-7-adhemerval.zanella@linaro.org> <87o8cp69rt.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Message-ID: <4344d96f-8477-fcf6-f6d9-6615985193d0@linaro.org> Date: Wed, 2 Jun 2021 10:11:21 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <87o8cp69rt.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2021 13:11:35 -0000 On 01/06/2021 09:37, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> Now that the thread cancellation type is not accessed concurrently >> anymore, it is possible to move it out the cancelhandling. >> >> By removing the cancel state out of the internal thread cancel handling >> state there is no need to check if cancelled bit was set in CAS >> operation. >> >> It allows simplifing the cancellation wrappers and the >> CANCEL_CANCELED_AND_ASYNCHRONOUS is removed. > > Patch looks okay to me. Maybe this should be merged with the other > patch that changes the cancel state handling. I don't have a strong preference, I split just to make easier to review and see the logical changes. I will merge when commit then.