From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-91264-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 41270 invoked by alias); 27 Mar 2018 15:20:17 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 40231 invoked by uid 89); 27 Mar 2018 15:20:16 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-24.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=Hx-languages-length:905, (unknown)
X-HELO: mail-qt0-f180.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:subject:to:references:from:organization
         :message-id:date:user-agent:mime-version:in-reply-to
         :content-language:content-transfer-encoding;
        bh=fujPbJeyTDHP8j//GM8kDJYYi4dK5J30iWmG2zC58Kg=;
        b=FLR6aVU3pSRhbsCRu6OpA8bk04YErHSKr04jbTIa1Qt6G2iLkURk5M9axXZ/7O9yt6
         4ew6QWL9/Ys/OA9Cg4ZZP+PW2aDTlij61Tyo6zRx48KOYS3pv59aoWrJRRmI6+9vpV1A
         GGwMi0ex3Jv8ZTqmzWVcvnDXAYkpOANtu3yg5zMKQMgvC5G4ZxfWl8vEyxbzyqjLGUF/
         bbUJpQjyd4snH1df9eyCykhRvK4BK7Ij5oaapdNQf3iS/IDjFuMG0ClptyvtBx+Enpjb
         XlZSj5V6+0QBCpngY/f+GGQ0WeSuI/IyGHBnpY0KTAPcPonK4iGc0UbX1pjUxp/ivUhQ
         6sgg==
X-Gm-Message-State: AElRT7HsRIJaK2SACgWsKizkeB/EIjDdav4GMo5LIw9g20zV190r2llq
	wsS5XqKoRiDvbjYgStX0hCMBb2nDRJY=
X-Google-Smtp-Source: AG47ELv9o8WBGzGNFCV9yEcq/VGKF+3K9CPmhwHCh8oLJsqVD5lEnELFcEaj2JPZ5+ELNqZHYflnmA==
X-Received: by 10.237.55.33 with SMTP id i30mr64575467qtb.340.1522164009543;
        Tue, 27 Mar 2018 08:20:09 -0700 (PDT)
Subject: Re: [PATCH] Fix crash in resolver on memory allocation failure (bug
 23005)
To: Andreas Schwab <schwab@suse.de>, libc-alpha@sourceware.org
References: <mvmo9j9byo9.fsf@suse.de>
From: Carlos O'Donell <carlos@redhat.com>
Message-ID: <436cba8c-94ce-5c3b-e429-dba6256c67c0@redhat.com>
Date: Tue, 27 Mar 2018 15:20:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <mvmo9j9byo9.fsf@suse.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-03/txt/msg00571.txt.bz2

On 03/27/2018 05:28 AM, Andreas Schwab wrote:
> 	[BZ #23005]
> 	* resolv/res_send.c (__res_context_send): Return ENOMEM if
> 	allocation of private copy of nsaddr_list fails.
> ---
>  resolv/res_send.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/resolv/res_send.c b/resolv/res_send.c
> index dde0425a33..7debf143f7 100644
> --- a/resolv/res_send.c
> +++ b/resolv/res_send.c
> @@ -471,6 +471,11 @@ __res_context_send (struct resolv_context *ctx,
>  					'\0',
>  					sizeof (struct sockaddr_in6)
>  					- sizeof (struct sockaddr_in));
> +			else
> +			  {
> +			    __set_errno (ENOMEM);

OK.

> +			    return -1;

OK, I reviewed the call chain to get there and it looks like -1 should
go all the way to the caller.

> +			  }
>  		}
>  		EXT(statp).nscount = statp->nscount;
>  	}
> 

LGTM.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

-- 
Cheers,
Carlos.