From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 03C6C3858D1E for ; Tue, 7 Feb 2023 08:22:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 03C6C3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3177C988009782 for ; Tue, 7 Feb 2023 08:22:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=pGBNwJNP2NR2Ty9ppxTJhI5m7ibs0+XDDHCetLiqav8=; b=Ybcm/k1Ze9DX2qwIjeOdqDgp3mkP3Ghe9zysz8DMg86wJQWhGAW9cjdUwcIZSONtpk3H G3SKPpmXzevWQ5mDb/bhoDodqQggC5lU/URm67ked+Q1DPTFRwAKlrgv8L1Ai39kUncZ Xg6a5J1RgsabsUKAlv4PhzFNYEmPurSKhaW/uKOz0KHWeLQKXvQlRuVq8y4ervVcqIsT 2DRLYuybXSVCgA/zHv1/ICx+e4DqY5zP98+PmAtJ7N8KPRvHv+2+HWrkIuSgndRzQgey 2wpmHbX5zCXwHnNObHgHPsZpoy/4bDGXCC4K/67RZ2+at6UcsWKq+oj8ZcbRDCBse2Dr 9A== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nkj1nhsag-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 07 Feb 2023 08:22:28 +0000 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3178AKWO031208 for ; Tue, 7 Feb 2023 08:22:28 GMT Received: from ppma06fra.de.ibm.com (48.49.7a9f.ip4.static.sl-reverse.com [159.122.73.72]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nkj1nhs9x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Feb 2023 08:22:28 +0000 Received: from pps.filterd (ppma06fra.de.ibm.com [127.0.0.1]) by ppma06fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 316DmNFt017584; Tue, 7 Feb 2023 08:22:25 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma06fra.de.ibm.com (PPS) with ESMTPS id 3nhemfjckd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Feb 2023 08:22:25 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3178MNt122479238 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Feb 2023 08:22:23 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1684C20043; Tue, 7 Feb 2023 08:22:23 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D8F2720040; Tue, 7 Feb 2023 08:22:22 +0000 (GMT) Received: from [9.171.17.28] (unknown [9.171.17.28]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 7 Feb 2023 08:22:22 +0000 (GMT) Message-ID: <44632a28-0ceb-4eba-28d2-7c7c3a7533d9@linux.ibm.com> Date: Tue, 7 Feb 2023 09:22:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] S390: Influence hwcaps/stfle via GLIBC_TUNABLES. To: Florian Weimer , Stefan Liebler via Libc-alpha References: <20230202135750.1632859-1-stli@linux.ibm.com> <87lelavpq1.fsf@oldenburg.str.redhat.com> Content-Language: en-US From: Stefan Liebler In-Reply-To: <87lelavpq1.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: z4HluBpGpjYoWXqI4NB6qdw7STiolXFM X-Proofpoint-ORIG-GUID: 7LzJ2RqDafCojlmyyQm1fvyE0G8NVETF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-02-07_02,2023-02-06_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 mlxscore=0 clxscore=1015 suspectscore=0 spamscore=0 malwarescore=0 bulkscore=0 mlxlogscore=943 priorityscore=1501 impostorscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302070068 X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 06.02.23 15:21, Florian Weimer wrote: > * Stefan Liebler via Libc-alpha: > >> This patch enables the option to influence hwcaps and stfle bits used >> by the s390 specific ifunc-resolvers. The currently x86-specific >> tunable glibc.cpu.hwcaps is also used on s390x to achieve the task. In >> addition the user can also set a CPU arch-level like z13 instead of >> single HWCAP and STFLE features. >> >> Note that the tunable only handles the features which are really used >> in the IFUNC-resolvers. All others are ignored as the values are only >> used inside glibc. Thus we can influence: >> - HWCAP_S390_VXRS (z13) >> - HWCAP_S390_VXRS_EXT (z14) >> - HWCAP_S390_VXRS_EXT2 (z15) >> - STFLE_MIE3 (z15) >> >> The influenced hwcap/stfle-bits are stored in the s390-specific >> cpu_features struct which also contains reserved fields for future >> usage. >> >> The ifunc-resolvers and users of stfle bits are adjusted to use the >> information from cpu_features struct. >> >> On 31bit, the ELF_MACHINE_IRELATIVE macro is now also defined. >> Otherwise the new ifunc-resolvers segfaults as they depend on >> the not yet processed_rtld_global_ro@GLIBC_PRIVATE relocation. >> --- > > I think you are updating all the right places. You should probably push > this as the hardware maintainer. > > Thanks, > Florian > Sure. I've just committed the patch. Thanks for having a look at the patch. Bye Stefan