From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) by sourceware.org (Postfix) with ESMTPS id AB05238515E3 for ; Thu, 25 Mar 2021 11:36:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AB05238515E3 Received: by mail-qv1-xf2b.google.com with SMTP id j17so925368qvo.13 for ; Thu, 25 Mar 2021 04:36:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=x5qZQdBTEV11d9tIv7m7xqG2q4gBv8q8By4aRobZVzk=; b=EL8cpPKksgy66nNtMe6HnyX/UoQ2IN9joNcWrZKJOj3Umrpf8R7+NXqfzKZcu8EPrw GkDblxebyBZSrMG1gKCT1GqmKIxivwpQd2cI9kcXQDY02MzRlTDKOcnNDI7npKZPmBFa 1HsZyMRF7zEIDgRq+n0V6kXF0I6ODQ+W/FI+HHt91TErHY4b2beXL5I0bm5S0i1h81bU CCNA5iwtmnUVzKM0pdVKBjjfXwvXvxkI9OeKkOmycAjgJCcQ0h+YF1tr0owxu9x/iNu3 ae85HAyrLNH+VRnmD//Z9ToDDwpn2BpNDIGSkLp/KtIHuVuusoFwSFEGQz3exQYq5ONx zPKA== X-Gm-Message-State: AOAM532kqTJazjO9dkE7z8Dbp9/Hoojbi8owU3isfaDNozATWZVIKi/k T7VEwwiiRgR1sa40HYDPsUic2IHjsCi5hQ== X-Google-Smtp-Source: ABdhPJxP+4YbuQRX0li9hCOPKuFggSD7+8YCV7UD8HbywEzhxuFY59JrCBZ3rjyGnPbL9fbd3/6tpw== X-Received: by 2002:a05:6214:80d:: with SMTP id df13mr7926151qvb.55.1616672161136; Thu, 25 Mar 2021 04:36:01 -0700 (PDT) Received: from [192.168.1.132] ([177.194.41.149]) by smtp.gmail.com with ESMTPSA id t6sm3339223qti.2.2021.03.25.04.35.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Mar 2021 04:36:00 -0700 (PDT) Subject: Re: [PATCH] tst: Provide test for select To: "H.J. Lu" Cc: Samuel Thibault , GNU C Library References: <20210314164625.9312-1-lukma@denx.de> <20210322123213.58775fbd@jawa> <39ac5960-73ef-f838-4409-20384c83b59d@linaro.org> <9dc782d3-c151-1dcb-0a2e-f6397c781761@linaro.org> <20210324213543.4ixrs66lloe7x6lx@begin> <96e005ac-0e0c-e0f9-a33e-18ce2840f542@linaro.org> From: Adhemerval Zanella Message-ID: <44af9ddb-de82-d354-7bab-e096e1215a8b@linaro.org> Date: Thu, 25 Mar 2021 08:35:58 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Mar 2021 11:36:03 -0000 On 24/03/2021 19:30, H.J. Lu wrote: >>>>>> How does it work? It looks like a NOP to me. >>>>> >>>>> The idea is to clear the nanosecond precision from the xclock_now call. >>> >>> It should rather be >>> >>> ts.tv_nsec = (ts.tv_nsec / 1000) * 1000; >>> >>> shouldn't it? >> >> Indeed, thanks for spotting it. Could you check if this helps the tests H.J? > > The test failed with "nohup make check" since select returned immediately. > Do you have a strace of why select is returning? It uses 2 (STDERR_FILENO) as on the read set, so it should trigger the timeout.