From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zimbra.cs.ucla.edu (zimbra.cs.ucla.edu [131.179.128.68]) by sourceware.org (Postfix) with ESMTPS id 9B6C23858C27 for ; Wed, 13 Oct 2021 16:45:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9B6C23858C27 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=cs.ucla.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.ucla.edu Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E3BFD160083; Wed, 13 Oct 2021 09:45:23 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id HCsGxss8M_lK; Wed, 13 Oct 2021 09:45:23 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 3CA731600FB; Wed, 13 Oct 2021 09:45:23 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Qr-ZW-l66auN; Wed, 13 Oct 2021 09:45:23 -0700 (PDT) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 17D6E160083; Wed, 13 Oct 2021 09:45:23 -0700 (PDT) To: Stafford Horne , Adhemerval Zanella Cc: GLIBC patches References: <20210607203613.282543-1-adhemerval.zanella@linaro.org> <20210607203613.282543-19-adhemerval.zanella@linaro.org> From: Paul Eggert Organization: UCLA Computer Science Department Subject: Re: [PATCH v3 18/24] y2038: Add support for 64-bit time on legacy ABIs Message-ID: <4532ccfd-971b-2a4d-c751-799b1962401e@cs.ucla.edu> Date: Wed, 13 Oct 2021 09:45:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Oct 2021 16:45:26 -0000 On 10/13/21 4:44 AM, Stafford Horne via Libc-alpha wrote: >> +@item >> +@code{_TIME_BITS=3D64} and port from the outset uses 64-bit >> +@code{time_t} and word size equals to @w{32 bits} (e.g. ARC, RV32) >> +- no action >=20 > OpenRISC falls into this category. We have 64-bit support but word siz= e is > 32 bits. If OpenRISC has always had 64-bit time_t, the -D_TIME_BITS=3D64 option=20 should have no effect on compilation. I.e., time_t used to be 64 bits,=20 and it'll still be 64 bits regardless of whether you use that option. > On OpenRISC we have __TIMESIZE =3D=3D 64, so __USE_TIME_BITS64 does not= get > defined. That sounds OK. If time_t has always been 64 bits, there's no need for=20 the 32- vs 64-bit time_t complexity. The diagnostics you gave don't seem to have anything to do with time_t.=20 However, if you're getting them with -D_TIME_BITS=3D64 but not getting=20 them without that option, that suggests there's a glitch somewhere that=20 needs to be tracked down more carefully.