public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Xi Ruoyao <xry111@xry111.site>, caiyinyu <caiyinyu@loongson.cn>,
	libc-alpha@sourceware.org
Cc: Chenghua Xu <xuchenghua@loongson.cn>,
	Lulu Cheng <chenglulu@loongson.cn>, Wang Xuerui <i@xen0n.name>,
	liuzhensong <liuzhensong@loongson.cn>
Subject: Re: [PATCH v3 1/1] LoongArch: Add static PIE support
Date: Fri, 30 Sep 2022 09:54:07 -0300	[thread overview]
Message-ID: <4538abfd-ec05-bab5-1759-e3b12c6f1eed@linaro.org> (raw)
In-Reply-To: <3848ed3c5915a2363ffa8bdd43f74152da125885.camel@xry111.site>



On 30/09/22 09:47, Xi Ruoyao via Libc-alpha wrote:
> On Thu, 2022-09-29 at 21:32 +0800, caiyinyu wrote:
>> Here are some mistakes:
> 
> Sorry for the stupid mistake...`
> 
> I need to be AFK for several days, will send v4 once I'm back.
> 
>> diff --git a/sysdeps/loongarch/configure b/sysdeps/loongarch/configure
>> index 70d6fec5c1..6edd6d08a5 100644
>> --- a/sysdeps/loongarch/configure
>> +++ b/sysdeps/loongarch/configure
>> @@ -14,10 +14,10 @@ else
>>   .global _start
>>   .type _start, @function
>>   _start:
>> -  li.w $a7, 93
>> +  li.w \$a7, 93
>>     /* This ensures the assembler supports explicit reloc.  */
>> -  pcalau12i $a0, %pc_hi20(x)
>> -  ld.w $a0, $a0, %pc_lo12(x)
>> +  pcalau12i \$a0, %pc_hi20(x)
>> +  ld.w \$a0, \$a0, %pc_lo12(x)
>>     syscall 0
> 


I was committed upstream nevertheless  (8b10727a9af3e2aa4b27dff0116bb8d3c9afce3d).
It upstream correct or does it require a the above fix?

  reply	other threads:[~2022-09-30 12:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-24  7:45 [PATCH v3 0/1] " Xi Ruoyao
2022-09-24  7:45 ` [PATCH v3 1/1] " Xi Ruoyao
2022-09-29 13:32   ` caiyinyu
2022-09-30 12:47     ` Xi Ruoyao
2022-09-30 12:54       ` Adhemerval Zanella Netto [this message]
2022-09-30 13:55         ` Xi Ruoyao
2022-09-30 20:10         ` Joseph Myers
2022-10-01 13:07           ` Xi Ruoyao
2022-10-02 14:25             ` Xi Ruoyao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4538abfd-ec05-bab5-1759-e3b12c6f1eed@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=caiyinyu@loongson.cn \
    --cc=chenglulu@loongson.cn \
    --cc=i@xen0n.name \
    --cc=libc-alpha@sourceware.org \
    --cc=liuzhensong@loongson.cn \
    --cc=xry111@xry111.site \
    --cc=xuchenghua@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).