From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x92e.google.com (mail-ua1-x92e.google.com [IPv6:2607:f8b0:4864:20::92e]) by sourceware.org (Postfix) with ESMTPS id 31C41385841A for ; Fri, 30 Sep 2022 12:54:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 31C41385841A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ua1-x92e.google.com with SMTP id b7so1668452uas.2 for ; Fri, 30 Sep 2022 05:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date; bh=EHncxuCBVR7P+sRe/Rm45I61/qEUjGT0Xh5Q7M/0Lcc=; b=c9a8YyrfnP/NwFzEry7E36TvH0iFNDRDaFs6zZOhav9xSHRqYKdouP+g/rS2oz3Nyp yPBs4NA6sRlOFVbRSXTIfEUQjL/4DklGF5L9b/YB7oEcyu28JqJCXcPsfiOa7k8v1jCO qNwSbWETiiHBc3TtG9mwoY0YcUbeX9w0OPo1G/f+La0OWEGpeBR6RVzJcNBtlx72efwy OwM8vI0o11LJ2ZI0UR1rMWxubnGZRU0Xztv8x7eXbrTMAcsZMkqrSa5b3R3FGx5WPvC6 YZpBvdF1vaBImTI4Fskf8UVb9TTtc4AN6qi6uKwtx9IMAdGgJbLhWr/sD3m9YjhjCS3O PXZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=EHncxuCBVR7P+sRe/Rm45I61/qEUjGT0Xh5Q7M/0Lcc=; b=yitS/NCcl46qzEIe0poZpCLuLAeGqvD/nzLiHyvRdAAw7WgBJBp1vmeGRZIPbbVHO8 v7U0eorVvw/z2RdmKQMiJpzvyVjb74EB+Zjl9jEqGermQgNCaHuT6nfBDXKRZm9ZY5tE VgzRark3Owxpy8guyHyGyIF4CJ14vB1/pLC3CgIlSY3teTeAw0G61yuzG65sD8mty+X6 gHZVwiMuLlErQFim3bfvG8WobQqQNHkFkqpsBasM24hBI8uQTMpG1TXVDDYTLTsPsQUh A6rBQuIlXMoDDqw8x+W9giNU3FnkaR41pUj46DebNPGYwBcSSt8+tDbsfMuim5fcxnEA MIng== X-Gm-Message-State: ACrzQf0284UqCu+TciU7gQQSy4qQ/uFG+mv0MlZXQWanhgk8/kdN2dpv MWtmlgQ2kQEMhpF5Hcwkc8qBRUr2zQHyuIgR X-Google-Smtp-Source: AMsMyM6PMviH/gf4XJ8xPLQcHzLjvMtM7NqjGm2xa0oWDqex5w9ipaYXGhhTEjWN+TDh5DueMr/ykw== X-Received: by 2002:ab0:6451:0:b0:3b8:7f95:f20e with SMTP id j17-20020ab06451000000b003b87f95f20emr4595970uap.31.1664542450485; Fri, 30 Sep 2022 05:54:10 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c2:3736:5474:7f48:dc74:6616? ([2804:1b3:a7c2:3736:5474:7f48:dc74:6616]) by smtp.gmail.com with ESMTPSA id c10-20020ab00b8a000000b003abe183b6a0sm1420267uak.35.2022.09.30.05.54.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Sep 2022 05:54:09 -0700 (PDT) Message-ID: <4538abfd-ec05-bab5-1759-e3b12c6f1eed@linaro.org> Date: Fri, 30 Sep 2022 09:54:07 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v3 1/1] LoongArch: Add static PIE support Content-Language: en-US To: Xi Ruoyao , caiyinyu , libc-alpha@sourceware.org Cc: Chenghua Xu , Lulu Cheng , Wang Xuerui , liuzhensong References: <20220924074534.1566173-1-xry111@xry111.site> <20220924074534.1566173-2-xry111@xry111.site> <3848ed3c5915a2363ffa8bdd43f74152da125885.camel@xry111.site> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <3848ed3c5915a2363ffa8bdd43f74152da125885.camel@xry111.site> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 30/09/22 09:47, Xi Ruoyao via Libc-alpha wrote: > On Thu, 2022-09-29 at 21:32 +0800, caiyinyu wrote: >> Here are some mistakes: > > Sorry for the stupid mistake...` > > I need to be AFK for several days, will send v4 once I'm back. > >> diff --git a/sysdeps/loongarch/configure b/sysdeps/loongarch/configure >> index 70d6fec5c1..6edd6d08a5 100644 >> --- a/sysdeps/loongarch/configure >> +++ b/sysdeps/loongarch/configure >> @@ -14,10 +14,10 @@ else >>   .global _start >>   .type _start, @function >>   _start: >> -  li.w $a7, 93 >> +  li.w \$a7, 93 >>     /* This ensures the assembler supports explicit reloc.  */ >> -  pcalau12i $a0, %pc_hi20(x) >> -  ld.w $a0, $a0, %pc_lo12(x) >> +  pcalau12i \$a0, %pc_hi20(x) >> +  ld.w \$a0, \$a0, %pc_lo12(x) >>     syscall 0 > I was committed upstream nevertheless (8b10727a9af3e2aa4b27dff0116bb8d3c9afce3d). It upstream correct or does it require a the above fix?