From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by sourceware.org (Postfix) with ESMTPS id BD56D3851C01 for ; Mon, 1 Jun 2020 14:42:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BD56D3851C01 Received: by mail-qt1-x842.google.com with SMTP id i16so1184994qtr.7 for ; Mon, 01 Jun 2020 07:42:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:references:autocrypt:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=eBVMOX9FeD3RuS37GZ6ae6+f6aAoRYNzkpYFDetY5rM=; b=W5EeSY4HKrtaeyz1vDHLUpWJXqPMJ14UBvRrz8m72q1RWBRI8aj5arzKD1EuLy5UwJ B8eV1eRgJ67T/46ikR/5tRTkXOU5l/2POMQfB3ieYcv5hX52HMqXGbktGtrAUq7QOFoU df05oNVVmPQ5KVlSQzS+3st27+fd7o/O8cde/cI+xjXZLmrdppN64P44TgjRlkBy1xQE LoBLqrTqrDcy7KlL6Bb2ILCzUsl1YB3Fph+1j6qrSKumaYiNbomOUiaeMijwTxMES5Jp RDg09V3s2K7vS8NGxpd48Whim7QhbKga+rs4xwmgS6KzNrW/H3Ghq0DoPV2x8HPcIB+d KEYw== X-Gm-Message-State: AOAM531XeXxn3zPxkUWTdjQJr1qiK4RXcrZ6xK7ICozsMnFqAieonZK4 xfef+Da6TUSjflXJFndt9yF+OVXK5/g= X-Google-Smtp-Source: ABdhPJyITE3WgD3Gr3GzyMLHynJN/AUL2bVPHM9jUnOx4l5ABA6i1IThDwlLbdXscFqgMmGl/C0BFQ== X-Received: by 2002:ac8:60b:: with SMTP id d11mr16914018qth.218.1591022528925; Mon, 01 Jun 2020 07:42:08 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id a188sm14410338qkg.11.2020.06.01.07.42.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jun 2020 07:42:08 -0700 (PDT) From: Adhemerval Zanella To: Vineet Gupta , libc-alpha@sourceware.org Cc: linux-snps-arc@lists.infradead.org References: <20200530020047.5490-1-vgupta@synopsys.com> <20200530020047.5490-3-vgupta@synopsys.com> <1f8c98ba-481c-1463-29ff-c0dec7add324@linaro.org> Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Subject: Re: [PATCH 2/5] iee754: prvoide gcc builtins based generic sqrt functions Message-ID: <45540801-e568-54ef-ad29-c3c2130eddb5@linaro.org> Date: Mon, 1 Jun 2020 11:42:06 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <1f8c98ba-481c-1463-29ff-c0dec7add324@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-15.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jun 2020 14:42:11 -0000 On 01/06/2020 11:13, Adhemerval Zanella wrote: > > > On 29/05/2020 23:00, Vineet Gupta wrote: > > LGTM, thanks. > > Reviewed-by: Adhemerval Zanella > >> --- >> sysdeps/generic/math-use-builtins.h | 3 +++ >> sysdeps/ieee754/dbl-64/e_sqrt.c | 6 ++++++ >> sysdeps/ieee754/flt-32/e_sqrtf.c | 6 ++++++ >> 3 files changed, 15 insertions(+) >> >> diff --git a/sysdeps/generic/math-use-builtins.h b/sysdeps/generic/math-use-builtins.h >> index 8a39ef58bc95..fc724c824a17 100644 >> --- a/sysdeps/generic/math-use-builtins.h >> +++ b/sysdeps/generic/math-use-builtins.h >> @@ -60,4 +60,7 @@ >> # define USE_COPYSIGNF128_BUILTIN 0 >> #endif >> >> +#define USE_SQRT_BUILTIN 0 >> +#define USE_SQRTF_BUILTIN 0 >> + >> #endif /* math-use-builtins.h */ > > Ok. > >> diff --git a/sysdeps/ieee754/dbl-64/e_sqrt.c b/sysdeps/ieee754/dbl-64/e_sqrt.c >> index d42a1a4eb6e9..518a8ae5cdaf 100644 >> --- a/sysdeps/ieee754/dbl-64/e_sqrt.c >> +++ b/sysdeps/ieee754/dbl-64/e_sqrt.c >> @@ -41,6 +41,7 @@ >> #include >> #include >> #include >> +#include >> >> /*********************************************************************/ >> /* An ultimate sqrt routine. Given an IEEE double machine number x */ > > Ok. > >> @@ -50,6 +51,10 @@ >> double >> __ieee754_sqrt (double x) >> { >> +#if USE_SQRT_BUILTIN >> + return __builtin_sqrt (x); >> +#else >> + /* Use generic implementation. */ >> static const double >> rt0 = 9.99999999859990725855365213134618E-01, >> rt1 = 4.99999999495955425917856814202739E-01, >> @@ -138,6 +143,7 @@ __ieee754_sqrt (double x) >> return (x - x) / (x - x); /* sqrt(-ve)=sNaN */ >> return 0x1p-256 * __ieee754_sqrt (x * 0x1p512); >> } >> +#endif /* ! USE_SQRT_BUILTIN */ >> } >> #ifndef __ieee754_sqrt >> libm_alias_finite (__ieee754_sqrt, __sqrt) > > Ok. > >> diff --git a/sysdeps/ieee754/flt-32/e_sqrtf.c b/sysdeps/ieee754/flt-32/e_sqrtf.c >> index b339444301aa..68fc80e1e1ee 100644 >> --- a/sysdeps/ieee754/flt-32/e_sqrtf.c >> +++ b/sysdeps/ieee754/flt-32/e_sqrtf.c >> @@ -16,12 +16,17 @@ >> #include >> #include >> #include >> +#include >> >> static const float one = 1.0, tiny=1.0e-30; You will need to move this definitions inside the !USE_SQRTF_BUILTIN to avoid defined by not used warnings. Current practice is to just open code the constants and let compiler optimize the constant pool: diff --git a/sysdeps/ieee754/flt-32/e_sqrtf.c b/sysdeps/ieee754/flt-32/e_sqrtf.c index 68fc80e..d85a041 100644 --- a/sysdeps/ieee754/flt-32/e_sqrtf.c +++ b/sysdeps/ieee754/flt-32/e_sqrtf.c @@ -18,8 +18,6 @@ #include #include -static const float one = 1.0, tiny=1.0e-30; - float __ieee754_sqrtf(float x) { @@ -75,10 +73,10 @@ __ieee754_sqrtf(float x) /* use floating add to find out rounding direction */ if(ix!=0) { - z = one-tiny; /* trigger inexact flag */ - if (z>=one) { - z = one+tiny; - if (z>one) + z = 0x1p0 - 0x1.4484cp-100; /* trigger inexact flag */ + if (z >= 0x1p0) { + z = 0x1p0 + 0x1.4484cp-100; + if (z > 0x1p0) q += 2; else q += (q&1); >> >> float >> __ieee754_sqrtf(float x) >> { >> +#if USE_SQRTF_BUILTIN >> + return __builtin_sqrtf (x); >> +#else >> + /* Use generic implementation. */ >> float z; >> int32_t sign = (int)0x80000000; >> int32_t ix,s,q,m,t,i; >> @@ -83,6 +88,7 @@ __ieee754_sqrtf(float x) >> ix += (m <<23); >> SET_FLOAT_WORD(z,ix); >> return z; >> +#endif /* ! USE_SQRTF_BUILTIN */ >> } >> #ifndef __ieee754_sqrtf >> libm_alias_finite (__ieee754_sqrtf, __sqrtf) >> > > Ok. >