public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Joseph Myers <joseph@codesourcery.com>, libc-alpha@sourceware.org
Subject: Re: Add MOVE_MOUNT_BENEATH from Linux 6.5 to sys/mount.h
Date: Thu, 14 Sep 2023 10:06:53 -0300	[thread overview]
Message-ID: <457efdfd-bbb3-56ec-8705-802926aea942@linaro.org> (raw)
In-Reply-To: <5885c06a-a563-4c-e314-4075af50d275@codesourcery.com>



On 13/09/23 17:28, Joseph Myers wrote:
> This patch adds the MOVE_MOUNT_BENEATH constant from Linux 6.5 to
> glibc's sys/mount.h and updates tst-mount-consts.py to reflect these
> constants being up to date with that Linux kernel version.
> 
> Tested with build-many-glibcs.py.
> 

LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

> diff --git a/sysdeps/unix/sysv/linux/sys/mount.h b/sysdeps/unix/sysv/linux/sys/mount.h
> index c6da841d99..a692c0e092 100644
> --- a/sysdeps/unix/sysv/linux/sys/mount.h
> +++ b/sysdeps/unix/sysv/linux/sys/mount.h
> @@ -226,6 +226,7 @@ struct mount_attr
>  #define MOVE_MOUNT_T_AUTOMOUNTS 0x00000020 /* Follow automounts on to path */
>  #define MOVE_MOUNT_T_EMPTY_PATH 0x00000040 /* Empty to path permitted */
>  #define MOVE_MOUNT_SET_GROUP    0x00000100 /* Set sharing group instead */
> +#define MOVE_MOUNT_BENEATH      0x00000200 /* Mount beneath top mount */
>  
>  
>  /* fspick flags.  */
> diff --git a/sysdeps/unix/sysv/linux/tst-mount-consts.py b/sysdeps/unix/sysv/linux/tst-mount-consts.py
> index bea27e204c..b5c52a4bb2 100755
> --- a/sysdeps/unix/sysv/linux/tst-mount-consts.py
> +++ b/sysdeps/unix/sysv/linux/tst-mount-consts.py
> @@ -39,10 +39,10 @@ def main():
>          sys.exit (77)
>  
>      linux_version_headers = glibcsyscalls.linux_kernel_version(args.cc)
> -    # Constants in glibc were updated to match Linux v6.4.  When glibc
> +    # Constants in glibc were updated to match Linux v6.5.  When glibc
>      # constants are updated this value should be updated to match the
>      # released kernel version from which the constants were taken.
> -    linux_version_glibc = (6, 4)
> +    linux_version_glibc = (6, 5)
>      def check(cte, exclude=None):
>          return glibcextract.compare_macro_consts(
>                  '#include <sys/mount.h>\n',
> 

      reply	other threads:[~2023-09-14 13:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-13 20:28 Joseph Myers
2023-09-14 13:06 ` Adhemerval Zanella Netto [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=457efdfd-bbb3-56ec-8705-802926aea942@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).