From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) by sourceware.org (Postfix) with ESMTPS id 6BAC2385DC22 for ; Mon, 7 Jun 2021 18:53:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6BAC2385DC22 Received: by mail-qv1-xf2d.google.com with SMTP id u14so6548418qvq.6 for ; Mon, 07 Jun 2021 11:53:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MpGDtAhea5Xlfd4d3Iy0nXBqEzf8tw+x+yi87IKWCCc=; b=bf5OlVU5ZUK8PgTVyy+KWe1Qs9DNK+ZOjlNlcQY+9bc8UF0eb3H/t1FVGEHx7JoUok iLFekYsQxTsm3+2UKLe9JmikIvt9dJdzRMYEEHOCOh9Hehdf3plxKpsrNBRPUf2cfWJp OAFP+VU1i1RdrXGiVpKYn4SyZqXhKghS21DmBkxZfgmjMnhFnVY5g9k0RqoeJCz5oK5O cZhN5KJ3/emFW36MWibDyq3E0iF5qJFRQDW7Hk/i4pXt31AESDdbRYeNh4BkD6OYsb9f JHOztTUVvR7AUNlnPyeNRDMQOkyol9Fws9KK2S618FS0MsNtUmfAJuMhq7UsOCN4P7T8 Dt1Q== X-Gm-Message-State: AOAM530MhW/hLcfw3rB8RJCvTj/9BSAfsMdemyEuFDTsfN6jE97aqudK hWhp84MzDH+jJkHhHt05uxirTw== X-Google-Smtp-Source: ABdhPJxS710w+rs1WM/2EkumrISfNmxppuHL5AJk52BDSl2+evG1PXlYHWHMyxg5ktNfbpZ1G5U8MQ== X-Received: by 2002:ad4:478e:: with SMTP id z14mr11408197qvy.52.1623091980997; Mon, 07 Jun 2021 11:53:00 -0700 (PDT) Received: from [192.168.1.4] ([177.194.59.218]) by smtp.gmail.com with ESMTPSA id u27sm10093395qku.33.2021.06.07.11.52.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Jun 2021 11:53:00 -0700 (PDT) Subject: Re: [PATCH v2 20/25] posix: Add glob64 with 64 bit time_t support To: Carlos O'Donell , libc-alpha@sourceware.org References: <20210518205613.1487824-1-adhemerval.zanella@linaro.org> <20210518205613.1487824-21-adhemerval.zanella@linaro.org> From: Adhemerval Zanella Message-ID: <458799cd-479a-4434-3f43-90d6941e44c3@linaro.org> Date: Mon, 7 Jun 2021 15:52:58 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2021 18:53:02 -0000 On 04/06/2021 16:39, Carlos O'Donell wrote: > On 5/18/21 4:56 PM, Adhemerval Zanella wrote: >> The glob might pass a different stat struct for gl_stat and gl_lstat >> when GLOB_ALTDIRFUNC is used. This requires add a new 64 time >> version that also uses 64 time stat functions. > > Needs a v3 please. See below. Minor mistake in the test list? Ok, although the mistake is pretty obvious (the extra shm-directory entry in routines). Do you think it would be worth to resend the v3 upstream? > > No regressions on x86_64, i686, ppc64le, aarch64, s390x. > > Tested-by: Carlos O'Donell > >> diff --git a/posix/Makefile b/posix/Makefile >> index fa0dc0ea20..84204b1270 100644 >> --- a/posix/Makefile >> +++ b/posix/Makefile >> @@ -67,7 +67,10 @@ routines := \ >> get_child_max sched_cpucount sched_cpualloc sched_cpufree \ >> streams-compat \ >> shm-directory \ >> - execveat >> + execveat \ >> + shm-directory \ > > This is not correct since it duplicates shm-directory. I expect you intended > to fix the silly "\" way on the end. > > We should make all of those routines clearly into one entry per line to make > merging easier. > >> + glob64-time64 \ >> + globfree64-time64 >> >> aux := init-posix environ >> tests := test-errno tstgetopt testfnm runtests runptests \ Indeed the duplicated 'shm-directory' is wrong, I removed it.