From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0953A3852760 for ; Sun, 31 Jul 2022 11:57:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0953A3852760 Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-214-5A2kXUx9Nwiqk3btOnZBfg-1; Sun, 31 Jul 2022 07:57:40 -0400 X-MC-Unique: 5A2kXUx9Nwiqk3btOnZBfg-1 Received: by mail-qv1-f70.google.com with SMTP id a11-20020ad45c4b000000b004747a998b9eso5236912qva.9 for ; Sun, 31 Jul 2022 04:57:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=0gWldjY9Lya4D2u7spv+COGR2OV+y3mSZUis+yKeCTY=; b=aB+12fY76ntmKjxwCY0787WOAigbWypo4GEm8Q9iO/eGkYe4Hg/gji0FYZjbKRPl/R ZjCzXhfXtKfSQhldlfjnrS9bXpLY2I3ywLHaVKn6CRg39ggxm7op7hQiIJQ1Aj2ooh/v mJ0f2vsaXiV2PE09uYecwCqOL6/5W2DRfm4N9cGO89uSjgl3aprlKhqUUZm/0wseNyim XolTEqv7KT7NBd+wbVhV2ZHFT9Qgw8KPgkkKsflaCb8oPB+RDLY6AYVSGN7sE2QvWgyM w6vyDiXCSsmXMx7v5isgb92QR2SF3rBGmWpahwN1BG7gQPP1//DWbs+R5b6N6cw2akB5 Llyw== X-Gm-Message-State: AJIora8J4W4zkCKIOg/Kp+rVEe2cBWWDyY68+mBQ4YkX0EqpDu17TrOz Q/4JbTXklfBxFKf+5qOfPjbzkFsyu0+w8CByMDAsNcTevbVgZ4NiMSJQskEbwvD07xWJMVEYBHl vR9sXJAXei7WXAW8WvS0t X-Received: by 2002:a05:620a:2449:b0:6b5:f01e:d6cb with SMTP id h9-20020a05620a244900b006b5f01ed6cbmr8735903qkn.463.1659268659917; Sun, 31 Jul 2022 04:57:39 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t8jcIyi0DTq3E2VDe8lNKC03pvct4OgDzf4ADq+3v/wO/aMPalTq6tEZztU1xjf3UW31MPSw== X-Received: by 2002:a05:620a:2449:b0:6b5:f01e:d6cb with SMTP id h9-20020a05620a244900b006b5f01ed6cbmr8735897qkn.463.1659268659709; Sun, 31 Jul 2022 04:57:39 -0700 (PDT) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id m7-20020a378a07000000b006b648d016f3sm6397066qkd.126.2022.07.31.04.57.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 31 Jul 2022 04:57:39 -0700 (PDT) Message-ID: <46034175-1efe-5834-9946-aa85045634c6@redhat.com> Date: Sun, 31 Jul 2022 07:57:38 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] wcsmbs: Add missing test-c8rtomb/test-mbrtoc8 dependency To: "H.J. Lu" , libc-alpha@sourceware.org References: <20220729175056.268461-1-hjl.tools@gmail.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <20220729175056.268461-1-hjl.tools@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jul 2022 11:57:43 -0000 On 7/29/22 13:50, H.J. Lu via Libc-alpha wrote: > Make test-c8rtomb.out and test-mbrtoc8.out depend on $(gen-locales) for > > xsetlocale (LC_ALL, "de_DE.UTF-8"); > xsetlocale (LC_ALL, "zh_HK.BIG5-HKSCS"); > --- > wcsmbs/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/wcsmbs/Makefile b/wcsmbs/Makefile > index e6b9e8743a..3d19d5556f 100644 > --- a/wcsmbs/Makefile > +++ b/wcsmbs/Makefile > @@ -73,6 +73,8 @@ $(objpfx)tst-wcstol-locale.out: $(gen-locales) > $(objpfx)tst-wcstod-nan-locale.out: $(gen-locales) > $(objpfx)tst-c16-surrogate.out: $(gen-locales) > $(objpfx)tst-c32-state.out: $(gen-locales) > +$(objpfx)test-c8rtomb.out: $(gen-locales) > +$(objpfx)test-mbrtoc8.out: $(gen-locales) > endif > > $(objpfx)tst-wcstod-round: $(libm) LGTM. OK for 2.36 also. Reviewed-by: Carlos O'Donell -- Cheers, Carlos.