From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2e.google.com (mail-oa1-x2e.google.com [IPv6:2001:4860:4864:20::2e]) by sourceware.org (Postfix) with ESMTPS id 8F9433858C56 for ; Mon, 11 Jul 2022 12:49:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8F9433858C56 Received: by mail-oa1-x2e.google.com with SMTP id 586e51a60fabf-10bd4812c29so6511163fac.11 for ; Mon, 11 Jul 2022 05:49:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=oIRTdQ+UxfROuEUMybWSmcRI2nteMXfiZMdi1+Jymz0=; b=rRbSih9JmmtaK1GuLZcLJrlHQrjPE9kRJAQLQa6NDb17XQ6eCN+5UmPJEsfuEAc5/7 dCRZB9gHupT7Rxor5kYsn8sXJKvuhVyKPBynvNLkZkDH4Yp95hJS4j4vnSiKqa8S7nn+ uEJ37Uf1/BMCMMj+UANspMPXTDhAsSWMgV3rSWv8WzhKRMhxnVCouM/Za2tBTqomqZRf Qkl/iisRYKZsvt5j9bTLyxyQ3cvfV3UH9hRZeL6lpqqNnwo29Y1fvTrpkgtYpBX1Gw2R bSP6KVIfjX7rmaO8mHUgM8AVJ7DGYv6fpYNTWLLHQZwFCKQOLWvT3IfSytF3khFCbwC3 Tzfw== X-Gm-Message-State: AJIora9s8Rl2UPSrFieGBQ+Nd2V/t4QIXkvkVQtEtMSTOKJhUj4YdeyW g9j8ncQjzWisB84d3atCEl/8Vj7Z9tDDHQ== X-Google-Smtp-Source: AGRyM1sSEbiOZVFkpENPT+eDyi2t7xY5UppkgEV2m0LWq6QWWAnYujOG05zaCAL0gqqpudB/DtczCQ== X-Received: by 2002:a05:6870:c588:b0:10c:4b3a:68ec with SMTP id ba8-20020a056870c58800b0010c4b3a68ecmr6990060oab.223.1657543789079; Mon, 11 Jul 2022 05:49:49 -0700 (PDT) Received: from smtpclient.apple ([2804:431:c7cb:5bec:a591:bf2:d8b8:7a84]) by smtp.gmail.com with ESMTPSA id k12-20020a54440c000000b003263cf0f282sm2661213oiw.26.2022.07.11.05.49.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jul 2022 05:49:48 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Subject: Re: [PATCH v7 5/5] linux: Add mount_setattr From: Adhemerval Zanella In-Reply-To: <87zghg58qi.fsf@oldenburg.str.redhat.com> Date: Mon, 11 Jul 2022 09:49:46 -0300 Cc: Adhemerval Zanella via Libc-alpha , Andreas Schwab Content-Transfer-Encoding: 7bit Message-Id: <46921EC3-6197-4188-B5C4-F241DE6C1D8F@linaro.org> References: <20220624195919.435424-1-adhemerval.zanella@linaro.org> <20220624195919.435424-6-adhemerval.zanella@linaro.org> <0c64445d-a4f7-bb60-d165-e3c02d89549e@redhat.com> <6146A38B-2E47-46C1-BBFC-42646A8FF348@linaro.org> <87zghg58qi.fsf@oldenburg.str.redhat.com> To: Florian Weimer X-Mailer: Apple Mail (2.3696.100.31) X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jul 2022 12:49:52 -0000 > On 11 Jul 2022, at 05:55, Florian Weimer wrote: > > * Adhemerval Zanella via Libc-alpha: > >> I am not sure how to handle it, glibc sys/mount.h should be a standalone >> header. > > Is it really necessary to keep standalone? It's not even > a standard interface, and we don't have conform tests for this header as > far as I can see. > > So I think the usual __has_include approach should work here, too. The main problem is sys/mount.h defines interfaces for syscall added in multiple releases. It means that depending of the kernel version used by the compiler we will need to add some defines (for instance fsconfig_command). There is also a small difference where glibc header define the MS_* constant as a unnamed enum (not sure if this affects C++ mangling). I know that using kernel headers simplify some support, specially sync with newer releases; but this also adds more complexity where we need to handle integration outside glibc project.