From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc2f.google.com (mail-oo1-xc2f.google.com [IPv6:2607:f8b0:4864:20::c2f]) by sourceware.org (Postfix) with ESMTPS id 130FB3858D28 for ; Sat, 29 Jan 2022 19:59:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 130FB3858D28 Received: by mail-oo1-xc2f.google.com with SMTP id k23-20020a4abd97000000b002ebc94445a0so2241923oop.1 for ; Sat, 29 Jan 2022 11:59:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=TsoHmZEwAKl1Wa9yEw3h34CfPrMxUpsPHR2CqDwQy0s=; b=lHTcf6i8UAkL6guL3yZSoqIfsAEjLl8yI5y16qntw1gstgXWW92wBIJzGfDWizjwqI 6Oy9kVhcGsrFtGLNnxIUHgA1PfZJBiVeQk8L7O7Q9T6Kjavlx2aHNCOaibN+58u1FD4h JdJd6VjrSaQYk/FgpSpMvyqZ7CkLW/o1jxWPBLxwMafaQerjYXHpy174YFYgnlJoJpFi nhTp79jK0mLEOxlPcCsl+erDHwHYh/Ep3GbFIbug1+W9nrQEt63bd55KjRjtwK/pvtzj rEPRol4Y2ZRiOBCTZooCfdjbDXAQXI21c4LLWIXjAoE6y+v+43NuS+uzLYRIXzmLrIq8 V7Uw== X-Gm-Message-State: AOAM533PhGu4wRRRij4EWUogjUuSmt2gQawKJSU6YpQp/tXTIL+WSiWm p8f41hTCWunEwUhwkjEgVRaQ2Q== X-Google-Smtp-Source: ABdhPJwOzOSB/hGff7xshytEGUgvs8vlXyusKgKnr6N84WKQgEc+7sFPMRAauUCkUXkqJTy6bVsUNA== X-Received: by 2002:a4a:964d:: with SMTP id r13mr6858412ooi.53.1643486350405; Sat, 29 Jan 2022 11:59:10 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:709a:2377:9ffd:b28:b816? ([2804:431:c7ca:709a:2377:9ffd:b28:b816]) by smtp.gmail.com with ESMTPSA id m130sm13506118oif.21.2022.01.29.11.59.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 29 Jan 2022 11:59:10 -0800 (PST) Message-ID: <46a6e92a-3313-659b-6d01-5fe1f2d2b97a@linaro.org> Date: Sat, 29 Jan 2022 16:59:08 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH] posix: Replace posix_spawnattr_tc{get,set}pgrp_np with posix_spawn_file_actions_addtcsetpgrp_np Content-Language: en-US To: "H.J. Lu" Cc: Florian Weimer , GNU C Library References: <20220127141400.3364940-1-adhemerval.zanella@linaro.org> <87h79pma45.fsf@oldenburg.str.redhat.com> <6fc49d07-940d-a356-aebd-5b0de8c681f0@linaro.org> From: Adhemerval Zanella In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Jan 2022 19:59:12 -0000 On 29/01/2022 01:55, H.J. Lu wrote: > On Thu, Jan 27, 2022 at 9:05 AM Adhemerval Zanella via Libc-alpha > wrote: >> >> >> >> On 27/01/2022 13:11, Florian Weimer wrote: >>> * Adhemerval Zanella: >>> >>>> The posix_spawnattr_tcsetpgrp_np works on a file descriptor (the >>>> controlling terminal), so it would make more sense to actually fit >>>> it on the file actions API. >>>> >>>> Also, POSIX_SPAWN_TCSETPGROUP is not really required since it is >>>> implicit by the presence of tcsetpgrp file action. >>>> >>>> The posix/tst-spawn6.c is also fixed when TTY can is not present. > > I still got > > [hjl@gnu-tgl-2 build-x86_64-linux]$ cat posix/tst-spawn6.out > error: xopen.c:28: open64 ("/dev/tty", 0x0, 0600): No such device or address > error: 1 test failures > [hjl@gnu-tgl-2 build-x86_64-linux]$ > > It happened when I did > > $ nohup make check& > $ logout That's because I am using the wrong errno value to check if the tty is present (ENOENT). I have changed to ENXIO. > >>>> Checked on x86_64-linux-gnu and i686-linux-gnu. >>> >>> This has an ABI check failure on Hurd: >>> >>> --- ../sysdeps/mach/hurd/i386/libc.abilist 2022-01-27 10:04:20.120812828 -0500 >>> +++ /home/bmg/build/glibcs/i686-gnu/glibc/libc.symlist 2022-01-27 10:43:39.646804376 -0500 >>> @@ -2292,2 +2291,0 @@ GLIBC_2.35 posix_spawn_file_actions_addt >>> -GLIBC_2.35 posix_spawnattr_tcgetpgrp_np F >>> -GLIBC_2.35 posix_spawnattr_tcsetpgrp_np F >>> >>> The changes look okay to me. A second review is probably warranted at >>> this stage. >> >> Thanks. It is really annoying that hurd make update-abi adds a bunch of files >> and requires manual edit to get it right. > > >