From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) by sourceware.org (Postfix) with ESMTPS id 062A4383802F for ; Thu, 6 May 2021 19:40:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 062A4383802F Received: by mail-qt1-x82a.google.com with SMTP id p6so4940740qtk.13 for ; Thu, 06 May 2021 12:40:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bbCSQZDPgM34cpiJK3fRQqbD42/Azu6lGkw7p9kLq6U=; b=cUX/ETikqkdNn+8mSSrkMeKU/PCZ7HN+1AF2Db786H0vOIX1ox58RvL77jHX9529kZ SOnIcBhZc3iScA/rFPIr1MRafMGRXDzDY3tejf4SdH20gyomIJlhiw4n5u3JMGVsZKCs PTiWE+ol6a3QUX1mh5NrcT9qwLOkqhj+KkIKqcr3uLC/ICjXyJtBakcHqjrNXgIB+xBA /jnuln886nPC+G6pgU4eFVs7xvRzcjkAA7CPzrk8u0yLC6MA3ags5KgzoK5Gq3yMVy5f CClzNtL8mvAZAxzmPiCs2X3uLsExNIyJmraHo/3Mzrv2w3gVrpjaYVu21/5IgIeSioTP di5A== X-Gm-Message-State: AOAM531InkvJMSrpE1lOltIn97T2Ydd/Z7AoViDS9EWIcSI1SgMwaH/J PyknxLg0Kf++lO1jVWHWDasuhEhlFEE= X-Google-Smtp-Source: ABdhPJzwHz5hwuwQIT2JYaDK+yOnaoOLr7sX3PoP4CqIS4jQ0TkxYInxqTqspATRDe8dmYyu0lau1g== X-Received: by 2002:ac8:6c3a:: with SMTP id k26mr6374187qtu.146.1620330031510; Thu, 06 May 2021 12:40:31 -0700 (PDT) Received: from [192.168.0.41] (71-218-14-121.hlrn.qwest.net. [71.218.14.121]) by smtp.gmail.com with ESMTPSA id f5sm2856067qkk.12.2021.05.06.12.40.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 May 2021 12:40:30 -0700 (PDT) Subject: Re: [PATCH] more out of bounds checking improvements To: Joseph Myers Cc: Florian Weimer , Martin Sebor via Libc-alpha References: <176ba75f-4299-073f-8319-66dbf9fe3f42@gmail.com> <87k0ot9trs.fsf@oldenburg.str.redhat.com> <87v98d6ldm.fsf@oldenburg.str.redhat.com> <2a7e377d-60c8-313b-9422-6cd0b4f5224c@gmail.com> From: Martin Sebor Message-ID: <46e916dd-0fe2-6495-9b08-b69d862c7099@gmail.com> Date: Thu, 6 May 2021 13:40:29 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 May 2021 19:40:33 -0000 On 5/6/21 12:15 PM, Joseph Myers wrote: > On Thu, 6 May 2021, Martin Sebor via Libc-alpha wrote: > >> @@ -171,7 +172,18 @@ do_test (void) >> allocation. */ >> fails |= test_wrp2 (LIST (EINVAL, ENOMEM), mlock, (void *) -1, 1); >> fails |= test_wrp (EINVAL, nanosleep, &ts, &ts); >> + >> + DIAG_POP_NEEDS_COMMENT; >> + >> +#if __GNUC_PREREQ (9, 0) >> + /* Suppress valid GCC warning: >> + 'poll' specified size 18446744073709551608 exceeds maximum object size >> + */ >> + DIAG_IGNORE_NEEDS_COMMENT (9, "-Wstringop-overflow="); >> +#endif >> fails |= test_wrp (EINVAL, poll, &pollfd, -1, 0); >> + DIAG_POP_NEEDS_COMMENT; > > The first DIAG_POP_NEEDS_COMMENT looks like it should be > DIAG_PUSH_NEEDS_COMMENT. > Fixed! Thanks for double-checking the final patch! Martin