From: "Ying Huang" <ying.huang@oss.cipunited.com>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: "libc-alpha" <libc-alpha@sourceware.org>,
<yunqiang.su@oss.cipunited.com>,
"binutils" <binutils@sourceware.org>
Subject: Re: [PATCH v7] MIPS: Sync elf.h from binutils
Date: Tue, 22 Aug 2023 16:55:27 +0800 [thread overview]
Message-ID: <4765c662-1b02-d01a-77b6-8be4ca74719d@oss.cipunited.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2308211123450.49340@angie.orcam.me.uk>
[-- Attachment #1: Type: text/plain, Size: 2550 bytes --]
Hi Maciej,
Thanks for your detailed reply, and I have some questions about them.
在 2023/8/21 19:14, Maciej W. Rozycki 写道:
> On Mon, 21 Aug 2023, Ying Huang wrote:
>
>> Can you help commit these two patchs?
> To move forward you need to put the findings from the discussion in the
> change description, especially given the difficulty to figure out what the
> correct naming convention for the ELF file header flags is supposed to be.
> This is so that the next time this information is needed it is readily
> available rather than requiring chasing in the archives and/or depending
> on the presence of people who may still remember it as on this occasion.
>
> I think it will help if you split the glibc patch into self-contained
> functional subsets:
>
> 1. File header flags -- need documentation, as noted above.
>
> 2. SHT_MIPS_ABIFLAGS section type -- obviously correct, no need to
> elaborate on it.
>
> 3. Relocation types -- obviously correct, no need to elaborate on it.
>
> 4. GNU attribute stuff -- technically Tag_GNU_MIPS_ABI_FP along with the
> enumeration it comes with is a bug fix for commit 0bd956720c45 ("Add
> support for MIPS O32 FPXX and .MIPS.abiflags") which, conservatively,
> only added definitions actually used by the dynamic loader itself,
> despite that the header is a part of our public API for the MIPS psABI.
> I think that either said definitions ought to have been provided
> internally only or the whole of the API should have been exported at
> once (this applies to #2 above too).
Sorry, I am not very clear about this #4 above.
What is the whole API?
Did you mean not to submit the GNU attribute part or submit the whole API?
>
> Then the MSA stuff and Val_GNU_MIPS_ABI_FP_NAN2008 as later additions
> are distinct changes each. I think it is worth mentioning in the
> inline comment that the latter attribute value has been superseded by
> EF_MIPS_NAN2008.
Only to add comments before enum Val_GNU_MIPS_ABI_FP_NAN2008?
>
> I'd be tempted to say these would best be three distint changes then,
> but maybe other people would consider it overly pedantic.
What are these threee changes?
>
> Then the binutils change needs to document the switch from E_* to EF_*
> definitions accordingly.
>
> Maciej
I have submitted patch to binutils which is https://sourceware.org/pipermail/binutils/2023-August/129098.html.
Did you mean append commit message?
Thanks,
Ying
next prev parent reply other threads:[~2023-08-22 8:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 2:05 Ying Huang
2023-08-07 16:30 ` Florian Weimer
2023-08-08 3:36 ` Ying Huang
2023-08-08 9:40 ` Florian Weimer
2023-08-08 10:15 ` Ying Huang
2023-08-08 15:02 ` Florian Weimer
2023-08-09 16:20 ` Maciej W. Rozycki
2023-08-09 17:00 ` Florian Weimer
2023-08-11 17:43 ` Maciej W. Rozycki
2023-08-16 6:15 ` Ying Huang
2023-08-18 10:10 ` 黄莺
2023-08-21 6:27 ` Ying Huang
2023-08-21 11:14 ` Maciej W. Rozycki
2023-08-22 8:55 ` Ying Huang [this message]
2023-08-09 17:08 ` Richard Sandiford
2023-08-11 17:47 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4765c662-1b02-d01a-77b6-8be4ca74719d@oss.cipunited.com \
--to=ying.huang@oss.cipunited.com \
--cc=binutils@sourceware.org \
--cc=libc-alpha@sourceware.org \
--cc=macro@orcam.me.uk \
--cc=yunqiang.su@oss.cipunited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).