From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by sourceware.org (Postfix) with ESMTPS id DC7C63858C27 for ; Tue, 5 Apr 2022 11:50:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DC7C63858C27 Received: by mail-oi1-x230.google.com with SMTP id 12so13088633oix.12 for ; Tue, 05 Apr 2022 04:50:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=plqB1SegZVuLUKUEC6o9jEmLLj/oBDChoWdMPjNEstw=; b=NU+LyT3KHz5CIVAdKF8bQYyt11BrFXPMkn/Ed2kLVbEpLkUSethQBjUpTt5/KHlp0F FgUkXg+VCJFqejNfkJz86MejPsbOqC1xKXRqkFxAqUYhNp62PLWZmhYfG1xa6EJ87LJq 5HqPmEuFgbCZXPeGvyBt/yCn6BHohlCEr/m/If0p/B0bX0vUF6ViJoBeC8yIAtbllnHw d+LXtnFcwo1VARz1SZP92pfDdreBHsNqN3ZAx1SeCtuClU8WYQsjvSnTTY5sg+lUKtIz dDZiIJtlk27S5a86Q/FpYipfHNewflFjhyun6sTx2LVXSFkNyqhrJepBNUC5EY39eOkA s3dw== X-Gm-Message-State: AOAM533e/0Voe5Er5Flw8UR/So0RAs/eftBnvTA1zwtyNimLuWof2RW1 t2nyr81jPP4xElgDbhDDxkdY6GX749ycWw== X-Google-Smtp-Source: ABdhPJy7UKLm6hlH6Z0xZg9q0zgwTID1M/2KPqku2rmzYudr4H0BUPprmLD+ZxXTD/aP2QfXSFssiA== X-Received: by 2002:a05:6808:13c9:b0:2f9:2cf0:932a with SMTP id d9-20020a05680813c900b002f92cf0932amr1216169oiw.39.1649159418212; Tue, 05 Apr 2022 04:50:18 -0700 (PDT) Received: from ?IPV6:2804:431:c7cb:a6c0:26f4:3c2a:73ae:3e2? ([2804:431:c7cb:a6c0:26f4:3c2a:73ae:3e2]) by smtp.gmail.com with ESMTPSA id hg14-20020a056870790e00b000e1c070a73asm4591576oab.55.2022.04.05.04.50.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Apr 2022 04:50:17 -0700 (PDT) Message-ID: <4770fe55-59aa-6a25-dd3a-bc1b589b4270@linaro.org> Date: Tue, 5 Apr 2022 08:50:14 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] math: Add math-use-builtins-fabs Content-Language: en-US From: Adhemerval Zanella To: Joseph Myers Cc: libc-alpha@sourceware.org References: <20220404205805.701759-1-adhemerval.zanella@linaro.org> <06894f7e-df86-9ed0-8a61-d4077f920e9d@linaro.org> In-Reply-To: <06894f7e-df86-9ed0-8a61-d4077f920e9d@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2022 11:50:21 -0000 On 04/04/2022 22:55, Adhemerval Zanella wrote: > > > On 04/04/2022 19:41, Joseph Myers wrote: >> On Mon, 4 Apr 2022, Adhemerval Zanella via Libc-alpha wrote: >> >>> to support building glibc with clang, which does not support inline >>> __builtin_fabsf128. I change the patch to assume _Float128 support, >> >> And also not under another name (cf. how sysdeps/x86/bits/floatn.h uses >> __builtin_fabsq before GCC 7)? >> > > It does not seems to, it issues an undefined builtin error. So do you prefer I just assume long double and _Float128 abs builtin support or the patch is good as is?