From: Florian Weimer <fweimer@redhat.com>
To: Richard Henderson <rth@twiddle.net>, libc-alpha@sourceware.org
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Steven Munroe <sjmunroe@us.ibm.com>
Subject: Re: [PATCH 3/3] Add cache info for powerpc64
Date: Fri, 09 Jun 2017 06:59:00 -0000 [thread overview]
Message-ID: <477b6c8d-1c07-126e-e5db-dcf6dd1b77d4@redhat.com> (raw)
In-Reply-To: <20170608225728.26779-4-rth@twiddle.net>
On 06/09/2017 12:57 AM, Richard Henderson wrote:
> + case _SC_LEVEL1_ICACHE_SIZE:
> + return getauxval(AT_L1I_CACHESIZE);
Style (missing space) and potential namespace violation (should be
__getauxval).
Thanks,
Florian
next prev parent reply other threads:[~2017-06-09 6:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 22:57 [PATCH 0/3] Add some missing cache infomation Richard Henderson
2017-06-08 22:57 ` [PATCH 1/3] Guess L1 cache linesize for aarch64 Richard Henderson
2017-06-09 5:51 ` Siddhesh Poyarekar
2017-06-09 5:52 ` Andrew Pinski
2017-10-10 7:24 ` Siddhesh Poyarekar
2017-10-10 10:20 ` Szabolcs Nagy
2017-10-10 10:37 ` Siddhesh Poyarekar
2017-10-10 11:01 ` Szabolcs Nagy
2017-10-10 11:56 ` Siddhesh Poyarekar
2017-10-10 14:20 ` Richard Henderson
2017-10-11 5:28 ` Siddhesh Poyarekar
2017-10-10 17:19 ` Szabolcs Nagy
2017-06-08 22:57 ` [PATCH 3/3] Add cache info for powerpc64 Richard Henderson
2017-06-09 6:59 ` Florian Weimer [this message]
2017-06-09 13:12 ` Tulio Magno Quites Machado Filho
2017-06-09 20:07 ` Richard Henderson
2017-06-08 22:57 ` [PATCH 2/3] Add hidden_proto for getauxval Richard Henderson
2017-06-09 5:55 ` Siddhesh Poyarekar
2017-06-09 6:58 ` Florian Weimer
2017-06-09 17:45 ` Richard Henderson
2017-06-09 17:49 ` Florian Weimer
2017-06-09 22:11 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=477b6c8d-1c07-126e-e5db-dcf6dd1b77d4@redhat.com \
--to=fweimer@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=libc-alpha@sourceware.org \
--cc=rth@twiddle.net \
--cc=sjmunroe@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).