From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2a.google.com (mail-oa1-x2a.google.com [IPv6:2001:4860:4864:20::2a]) by sourceware.org (Postfix) with ESMTPS id D59A73858426 for ; Mon, 27 Mar 2023 13:06:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D59A73858426 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x2a.google.com with SMTP id 586e51a60fabf-177ca271cb8so9181702fac.2 for ; Mon, 27 Mar 2023 06:06:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679922390; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=QRs2ZubUQZvaw/3ahVz3ZHlOLHOAcrU5PqEbxJBFSLY=; b=ihW1Pjk46QUYtSLSI7bzqSBTx32+a7UkvxxGqSB3nDybY6px8FcUpraC/rG8/hHmLQ RLPS9ZZKlrQz41r55vwKxiqkp92/s3GQRP+QbL0LFhFs9l9m/TJ/4X6Zn7N2epZKWADh 4YEQEao3Hti4ZKjCLYDxkK1F0leU+WLxr3y3IjCqGBg2QAoURHoAOwCzcAGvJXsmrc64 GBKnru51M+SaH3pqgE3J3l4E7ODLxszQBkdzgwqWbS+4Glrl5cJqHGsw1efvTGkxaAzO SAwXo+hITPanNzBGZVoMjafV3rT8jSrEbOHY3XBFIdT9kWIbJEkbtxhvK6w7EvG/Twp8 KriQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679922390; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QRs2ZubUQZvaw/3ahVz3ZHlOLHOAcrU5PqEbxJBFSLY=; b=e6yZQJnCFa0bfrh+3zyhvs50DI8TQGUNitPSNnt2mmrJ+QRdWpDuEZra7CjrdGaDZB HeuzDq150GvvAJ4IagvsqL6IBjPMozedWZzn+1bChvlJHV3vdDvvIxEWv3ZuDp4Pq9eT OHSLHZSYTXvZyqevpsMvQpTRMtLQbNTc7OIQjC38DQwdKi0NPlCNafVeMXoflKU3f5lw YjfmWsxjhRilAYFDMhwH7b2Xfz945CTjWyTzNFCWcWGlJH2ULh+5uGn0h1R/bw4ILRTn E81EMywCyf2L2LNkEWjgwK0dn5KVtXYk9EdXJYQKChFQ+JLBrSutpTQse7qyxH/83Dyr PX1A== X-Gm-Message-State: AO0yUKX5HhVifBpJvOjV4/BKcLifLIBIJNJaQpjqJ2LuUSBDEvLkG2qK wyifZ/ihg/D1S4SDTzuR58Ombg== X-Google-Smtp-Source: AKy350a1snacRVuJB9MphiWy36qWZy7PqjgIsWsFWCVXV3sRO0SrIwnI4JlUPuzJ4yW1Bui4xyerAg== X-Received: by 2002:a05:6870:ac27:b0:177:b62d:cc21 with SMTP id kw39-20020a056870ac2700b00177b62dcc21mr8145132oab.13.1679922389949; Mon, 27 Mar 2023 06:06:29 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c1:60f9:9d7f:7b90:a6ae:401d? ([2804:1b3:a7c1:60f9:9d7f:7b90:a6ae:401d]) by smtp.gmail.com with ESMTPSA id wi22-20020a056871a71600b00176d49bb898sm9718412oab.44.2023.03.27.06.06.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Mar 2023 06:06:29 -0700 (PDT) Message-ID: <479c6860-7c34-4baf-aec9-8eafb310b879@linaro.org> Date: Mon, 27 Mar 2023 10:06:26 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 5/5] aarch64: Define __ASSUME_SYSCALL_NAMED_WORKS for Linux Content-Language: en-US To: Xi Ruoyao , libc-alpha@sourceware.org Cc: caiyinyu , Wang Xuerui , Andreas Schwab , Florian Weimer References: <20230325140815.4170296-1-xry111@xry111.site> <20230325140815.4170296-6-xry111@xry111.site> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20230325140815.4170296-6-xry111@xry111.site> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 25/03/23 11:08, Xi Ruoyao wrote: > AAPCS treats the variable arguments same as named ones, and when each > argument is an integer not wider than 8 bytes, the ith argument is in > register xi (0 <= i < 8), or the stack slot at (sp + 8 * (i - 8)) > (i >= 8) no matter how many arguments are passed. So we can define > __ASSUME_SYSCALL_NAMED_WORKS to avoid unnecessary stack stores in the > syscall wrappers caused by va_start. This triggered a build failure on i686 patchwork buildbot [1]. [1] https://www.delorie.com/trybots/32bit/18431/ > --- > sysdeps/unix/sysv/linux/aarch64/kernel-features.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/sysdeps/unix/sysv/linux/aarch64/kernel-features.h b/sysdeps/unix/sysv/linux/aarch64/kernel-features.h > index 3546f6de96..c39ff39da2 100644 > --- a/sysdeps/unix/sysv/linux/aarch64/kernel-features.h > +++ b/sysdeps/unix/sysv/linux/aarch64/kernel-features.h > @@ -21,3 +21,12 @@ > > #undef __ASSUME_CLONE_DEFAULT > #define __ASSUME_CLONE_BACKWARDS 1 > + > +/* Define this if the calling convention for passing x named arguments and y > + variable arguments is same as passing (x + y) named arguments, while each > + argument is either an integer of which the width is less than or equal to > + "long", or a pointer; and an argument can be fetched from the same register > + or the same offset from the stack pointer no matter how many (maybe zero) > + arguments are passed after it. It avoids useless stack stores caused by > + usage of va_start. */ > +#define __ASSUME_SYSCALL_NAMED_WORKS 1