Re: [PATCH] Makeconfig: Use $(error ...) to output error message

[Simon Marchi <simon.marchi@efficios.com>]

On 2020-04-29 5:25 a.m., Florian Weimer wrote:
> * Simon Marchi via Libc-alpha:
> 
>> On 2020-04-28 7:33 p.m., Joseph Myers wrote:
>>> On Tue, 28 Apr 2020, Simon Marchi via Libc-alpha wrote:
>>>
>>>> Being not familiar with the glibc repository, I typed "make" inside some
>>>> subdirectory that has a Makefile, and was met with:
>>>>
>>>>     $ make
>>>>     ../Makeconfig:42: *** missing separator.  Stop.
>>>>
>>>> At Makeconfig:42, we have:
>>>>
>>>>     objdir must be defined by the build-directory Makefile.
>>>>
>>>> Change that to use $(error ...), which I guess was the original
>>>> intention.  The result is:
>>>
>>> This patch is OK.
>>
>> Thanks, could you please push it for me?  I don't have write access to the
>> glibc repo (and don't plan to make enough contributions to justify it).
> 
> I have pushed this for you, although I don't think the error message
> is a clear improvement.  It still does not tell the casual user what
> they did wrong.
> 

Right, I thought about displaying the error message, not so much about the error
message itself.  You are probably better placed than I am to come up with a
meaningful error message, but here's my proposal:

  $(error You must run `make` in the build directory, not the source directory)

Simon