From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) by sourceware.org (Postfix) with ESMTPS id 0655C38930CB for ; Wed, 29 Apr 2020 13:51:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0655C38930CB Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id A66A22939A5; Wed, 29 Apr 2020 09:51:33 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id q-Vhmm0TsZIQ; Wed, 29 Apr 2020 09:51:33 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 6E6FF2939A4; Wed, 29 Apr 2020 09:51:33 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 6E6FF2939A4 X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id f-QI5KDwi-J7; Wed, 29 Apr 2020 09:51:33 -0400 (EDT) Received: from [10.0.0.193] (unknown [192.222.164.54]) by mail.efficios.com (Postfix) with ESMTPSA id 45C892939A1; Wed, 29 Apr 2020 09:51:33 -0400 (EDT) Subject: Re: [PATCH] Makeconfig: Use $(error ...) to output error message To: Florian Weimer , Simon Marchi via Libc-alpha Cc: Joseph Myers References: <20200428222024.3266407-1-simon.marchi@efficios.com> <6fbf8a68-a6b3-ac8e-4ed8-94bae46b2e7d@efficios.com> <87tv12ej8b.fsf@mid.deneb.enyo.de> From: Simon Marchi Message-ID: <479f8cd6-f819-62f2-4d62-6293d7164fc5@efficios.com> Date: Wed, 29 Apr 2020 09:51:31 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <87tv12ej8b.fsf@mid.deneb.enyo.de> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2020 13:51:36 -0000 On 2020-04-29 5:25 a.m., Florian Weimer wrote: > * Simon Marchi via Libc-alpha: > >> On 2020-04-28 7:33 p.m., Joseph Myers wrote: >>> On Tue, 28 Apr 2020, Simon Marchi via Libc-alpha wrote: >>> >>>> Being not familiar with the glibc repository, I typed "make" inside some >>>> subdirectory that has a Makefile, and was met with: >>>> >>>> $ make >>>> ../Makeconfig:42: *** missing separator. Stop. >>>> >>>> At Makeconfig:42, we have: >>>> >>>> objdir must be defined by the build-directory Makefile. >>>> >>>> Change that to use $(error ...), which I guess was the original >>>> intention. The result is: >>> >>> This patch is OK. >> >> Thanks, could you please push it for me? I don't have write access to the >> glibc repo (and don't plan to make enough contributions to justify it). > > I have pushed this for you, although I don't think the error message > is a clear improvement. It still does not tell the casual user what > they did wrong. > Right, I thought about displaying the error message, not so much about the error message itself. You are probably better placed than I am to come up with a meaningful error message, but here's my proposal: $(error You must run `make` in the build directory, not the source directory) Simon