[PATCH] Makeconfig: Use $(error ...) to output error message

[PATCH] Makeconfig: Use $(error ...) to output error message

[Simon Marchi]

Being not familiar with the glibc repository, I typed "make" inside some
subdirectory that has a Makefile, and was met with:

    $ make
    ../Makeconfig:42: *** missing separator.  Stop.

At Makeconfig:42, we have:

    objdir must be defined by the build-directory Makefile.

Change that to use $(error ...), which I guess was the original
intention.  The result is:

    $ make
    ../Makeconfig:42: *** objdir must be defined by the build-directory Makefile.  Stop.
---
 Makeconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makeconfig b/Makeconfig
index ac567caddc10..dfda418aaccb 100644
--- a/Makeconfig
+++ b/Makeconfig
@@ -39,7 +39,7 @@ objpfx := $(patsubst %//,%/,$(objdir)/$(subdir)/)
 common-objpfx = $(objdir)/
 common-objdir = $(objdir)
 else
-objdir must be defined by the build-directory Makefile.
+$(error objdir must be defined by the build-directory Makefile)
 endif
 
 # Root of the sysdeps tree.
-- 
2.26.2

Re: [PATCH] Makeconfig: Use $(error ...) to output error message

[Joseph Myers]

On Tue, 28 Apr 2020, Simon Marchi via Libc-alpha wrote:

> Being not familiar with the glibc repository, I typed "make" inside some
> subdirectory that has a Makefile, and was met with:
> 
>     $ make
>     ../Makeconfig:42: *** missing separator.  Stop.
> 
> At Makeconfig:42, we have:
> 
>     objdir must be defined by the build-directory Makefile.
> 
> Change that to use $(error ...), which I guess was the original
> intention.  The result is:

This patch is OK.

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: [PATCH] Makeconfig: Use $(error ...) to output error message

[Simon Marchi]

On 2020-04-28 7:33 p.m., Joseph Myers wrote:
> On Tue, 28 Apr 2020, Simon Marchi via Libc-alpha wrote:
> 
>> Being not familiar with the glibc repository, I typed "make" inside some
>> subdirectory that has a Makefile, and was met with:
>>
>>     $ make
>>     ../Makeconfig:42: *** missing separator.  Stop.
>>
>> At Makeconfig:42, we have:
>>
>>     objdir must be defined by the build-directory Makefile.
>>
>> Change that to use $(error ...), which I guess was the original
>> intention.  The result is:
> 
> This patch is OK.

Thanks, could you please push it for me?  I don't have write access to the
glibc repo (and don't plan to make enough contributions to justify it).

Simon

Re: [PATCH] Makeconfig: Use $(error ...) to output error message

[Florian Weimer]

* Simon Marchi via Libc-alpha:

> On 2020-04-28 7:33 p.m., Joseph Myers wrote:
>> On Tue, 28 Apr 2020, Simon Marchi via Libc-alpha wrote:
>> 
>>> Being not familiar with the glibc repository, I typed "make" inside some
>>> subdirectory that has a Makefile, and was met with:
>>>
>>>     $ make
>>>     ../Makeconfig:42: *** missing separator.  Stop.
>>>
>>> At Makeconfig:42, we have:
>>>
>>>     objdir must be defined by the build-directory Makefile.
>>>
>>> Change that to use $(error ...), which I guess was the original
>>> intention.  The result is:
>> 
>> This patch is OK.
>
> Thanks, could you please push it for me?  I don't have write access to the
> glibc repo (and don't plan to make enough contributions to justify it).

I have pushed this for you, although I don't think the error message
is a clear improvement.  It still does not tell the casual user what
they did wrong.

Re: [PATCH] Makeconfig: Use $(error ...) to output error message

[Simon Marchi]

On 2020-04-29 5:25 a.m., Florian Weimer wrote:
> * Simon Marchi via Libc-alpha:
> 
>> On 2020-04-28 7:33 p.m., Joseph Myers wrote:
>>> On Tue, 28 Apr 2020, Simon Marchi via Libc-alpha wrote:
>>>
>>>> Being not familiar with the glibc repository, I typed "make" inside some
>>>> subdirectory that has a Makefile, and was met with:
>>>>
>>>>     $ make
>>>>     ../Makeconfig:42: *** missing separator.  Stop.
>>>>
>>>> At Makeconfig:42, we have:
>>>>
>>>>     objdir must be defined by the build-directory Makefile.
>>>>
>>>> Change that to use $(error ...), which I guess was the original
>>>> intention.  The result is:
>>>
>>> This patch is OK.
>>
>> Thanks, could you please push it for me?  I don't have write access to the
>> glibc repo (and don't plan to make enough contributions to justify it).
> 
> I have pushed this for you, although I don't think the error message
> is a clear improvement.  It still does not tell the casual user what
> they did wrong.
> 

Right, I thought about displaying the error message, not so much about the error
message itself.  You are probably better placed than I am to come up with a
meaningful error message, but here's my proposal:

  $(error You must run `make` in the build directory, not the source directory)

Simon

Re: [PATCH] Makeconfig: Use $(error ...) to output error message

[Maciej W. Rozycki]

Hi Simon,

> Thanks, could you please push it for me?  I don't have write access to the
> glibc repo (and don't plan to make enough contributions to justify it).

 FTR I don't think you need any additional credentials to push to any of 
the repos hosted at sourceware as long as you have an account there, and 
obviously you do.

  Maciej

Re: [PATCH] Makeconfig: Use $(error ...) to output error message

[Simon Marchi]

On 2020-04-30 6:31 p.m., Maciej W. Rozycki wrote:
> Hi Simon,
> 
>> Thanks, could you please push it for me?  I don't have write access to the
>> glibc repo (and don't plan to make enough contributions to justify it).
> 
>  FTR I don't think you need any additional credentials to push to any of 
> the repos hosted at sourceware as long as you have an account there, and 
> obviously you do.
> 
>   Maciej
> 

Oh, maybe you are right, I was able to fetch from ssh://sourceware.org/git/glibc.git.

Simon

Re: [PATCH] Makeconfig: Use $(error ...) to output error message

[Florian Weimer]

* Maciej W. Rozycki:

> Hi Simon,
>
>> Thanks, could you please push it for me?  I don't have write access to the
>> glibc repo (and don't plan to make enough contributions to justify it).
>
>  FTR I don't think you need any additional credentials to push to any of 
> the repos hosted at sourceware as long as you have an account there, and 
> obviously you do.

You need to be added to the project-specific POSIX group, though.