From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>,
Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH 04/11] nptl: Add pthread_attr_setaffinity_np failure test
Date: Wed, 26 May 2021 14:30:14 -0300 [thread overview]
Message-ID: <47ee641e-90d9-c803-b0f4-e4238d480fd3@linaro.org> (raw)
In-Reply-To: <87k0nlqult.fsf@oldenburg.str.redhat.com>
On 26/05/2021 14:21, Florian Weimer wrote:
> * Adhemerval Zanella via Libc-alpha:
>
>> It checks whether an invalid affinity mask does return an error,
>> similar to what sysdeps/pthread/tst-bad-schedattr.c does for
>> pthread_attr_setschedparam.
>>
>> Checked on x86_64-linux-gnu.
>> ---
>> nptl/Makefile | 1 +
>> nptl/tst-pthread-attr-affinity-fail.c | 54 +++++++++++++++++++++++++++
>> 2 files changed, 55 insertions(+)
>> create mode 100644 nptl/tst-pthread-attr-affinity-fail.c
>>
>> diff --git a/nptl/Makefile b/nptl/Makefile
>> index 16eaf58948..9a5628b751 100644
>> --- a/nptl/Makefile
>> +++ b/nptl/Makefile
>> @@ -286,6 +286,7 @@ tests = tst-attr2 tst-attr3 tst-default-attr \
>> tst-exec4 tst-exec5 \
>> tst-stack2 tst-stack3 tst-stack4 \
>> tst-pthread-attr-affinity \
>> + tst-pthread-attr-affinity-fail \
>> tst-dlsym1 \
>> tst-context1 \
>> tst-sched1 \
>> diff --git a/nptl/tst-pthread-attr-affinity-fail.c b/nptl/tst-pthread-attr-affinity-fail.c
>> new file mode 100644
>> index 0000000000..41a87ea8cb
>> --- /dev/null
>> +++ b/nptl/tst-pthread-attr-affinity-fail.c
>> @@ -0,0 +1,54 @@
>> +/* Check if invalid pthread_attr_getaffinity_np does not run any code
>> + in the thread function.
>> + Copyright (C) 2021 Free Software Foundation, Inc.
>> + This file is part of the GNU C Library.
>> +
>> + The GNU C Library is free software; you can redistribute it and/or
>> + modify it under the terms of the GNU Lesser General Public
>> + License as published by the Free Software Foundation; either
>> + version 2.1 of the License, or (at your option) any later version.
>> +
>> + The GNU C Library is distributed in the hope that it will be useful,
>> + but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>> + Lesser General Public License for more details.
>> +
>> + You should have received a copy of the GNU Lesser General Public
>> + License along with the GNU C Library; if not, see
>> + <https://www.gnu.org/licenses/>. */
>> +
>> +#include <errno.h>
>> +#include <support/check.h>
>> +#include <support/xunistd.h>
>> +#include <support/xthread.h>
>> +#include <stdlib.h>
>> +
>> +static void *
>> +thr_func (void *arg)
>> +{
>> + abort ();
>> + return NULL;
>> +}
>> +
>> +static int
>> +do_test (void)
>> +{
>> + int max_cpu = xsysconf (_SC_NPROCESSORS_CONF) + 1;
>> + /* Set a affinaty mask with an invalid CPU. */
>> + cpu_set_t *cpuset = CPU_ALLOC (max_cpu);
>
> Perhaps:
>
> TEST_VERIFY_EXIT (cpuset != NULL);
Ack.
>
>> + size_t cpusetsize = CPU_ALLOC_SIZE (max_cpu);
>> + CPU_ZERO_S (cpusetsize, cpuset);
>> + CPU_SET_S (max_cpu, cpusetsize, cpuset);
>
> You could check that sched_setaffinity with that mask fails. Like this:
>
> TEST_COMPARE (sched_setaffinity (0, cpusetsize, cpuset), -1);
> TEST_COMPARE (errno, EINVAL);
>
> But feel free to push this without this change.
I will integrate your suggestions.
next prev parent reply other threads:[~2021-05-26 17:30 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 16:57 [PATCH 00/11] nptl: pthread cancellation refactor Adhemerval Zanella
2021-05-26 16:57 ` [PATCH 01/11] nptl: Move Linux createthread to nptl Adhemerval Zanella
2021-05-26 17:14 ` Florian Weimer
2021-05-26 16:57 ` [PATCH 02/11] nptl: Move createthread to pthread_create Adhemerval Zanella
2021-05-26 17:16 ` Florian Weimer
2021-05-26 17:29 ` Adhemerval Zanella
2021-05-26 16:57 ` [PATCH 03/11] support: Add xpthread_attr_setaffinity_np wrapper Adhemerval Zanella
2021-05-26 17:17 ` Florian Weimer
2021-05-27 22:35 ` Joseph Myers
2021-05-28 1:08 ` Adhemerval Zanella
2021-05-26 16:57 ` [PATCH 04/11] nptl: Add pthread_attr_setaffinity_np failure test Adhemerval Zanella
2021-05-26 17:21 ` Florian Weimer
2021-05-26 17:30 ` Adhemerval Zanella [this message]
2021-05-26 16:57 ` [PATCH 05/11] nptl: Deallocate the thread stack on setup failure (BZ #19511) Adhemerval Zanella
2021-05-26 17:33 ` Florian Weimer
2021-05-26 17:51 ` Adhemerval Zanella
2021-05-26 17:58 ` Florian Weimer
2021-05-26 19:19 ` Adhemerval Zanella
2021-05-26 18:21 ` Andreas Schwab
2021-05-26 18:40 ` Adhemerval Zanella
2021-05-26 19:26 ` Adhemerval Zanella
2021-05-27 7:43 ` Florian Weimer
2021-05-26 16:57 ` [PATCH 06/11] nptl: Install cancellation handler on pthread_cancel Adhemerval Zanella
2021-05-26 17:38 ` Florian Weimer
2021-05-26 17:52 ` Adhemerval Zanella
2021-05-26 16:57 ` [PATCH 07/11] nptl: Remove CANCELING_BITMASK Adhemerval Zanella
2021-05-26 18:02 ` Florian Weimer
2021-06-15 22:07 ` Florian Weimer
2021-06-15 23:33 ` Adhemerval Zanella
2021-06-16 12:46 ` Adhemerval Zanella
2021-05-26 16:57 ` [PATCH 08/11] nptl: Move cancel state out of cancelhandling Adhemerval Zanella
2021-05-26 18:20 ` Florian Weimer
2021-05-27 16:40 ` Adhemerval Zanella
2021-05-27 16:48 ` Florian Weimer
2021-05-27 16:57 ` Adhemerval Zanella
2021-05-26 16:57 ` [PATCH 09/11] nptl: Move cancel type " Adhemerval Zanella
2021-05-26 16:57 ` [PATCH 10/11] nptl: Implement raise in terms of pthread_kill Adhemerval Zanella
2021-05-26 16:57 ` [PATCH 11/11] nptl: Use pthread_kill on pthread_cancel Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47ee641e-90d9-c803-b0f4-e4238d480fd3@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).